Change in coreboot[master]: mb/hp/280_g2/romstage.c: Correct CaVrefConfig setting - coreboot-gerrit

6 Apr 2021


      Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52110 )
Change subject: mb/hp/280_g2/romstage.c: Correct CaVrefConfig setting
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52110/comment/17aab61f_08b31cb8 
PS1, Line 9: With DDR4, CA Vref goes to channel 0, and CH1 Vref goes to channel 1.
Sorry, I do not fully grasp the explanation. If it’s related to DDR4, why can’t FSP detect it’s FSP and set the correct setting itself?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64606824b4f82affb0fcfc78e68ba29859a1cc69
Gerrit-Change-Number: 52110
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 05:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment