Attention is currently required from: Jakub Czapiga, Daniel Gröber, Julius Werner.
Daniel Gröber (dxld) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42612 )
Change subject: tests: Add stubs for spi tests ......................................................................
Patch Set 25:
(5 comments)
File tests/mocks/console/console.c:
https://review.coreboot.org/c/coreboot/+/42612/comment/79c4eaaf_fe19a3b8 PS2, Line 7: return -1;
Doing strlen(fmt) seems a bit overkill to me, especially since it's still not quite the correct retu […]
Our console stubs were superceded so this is no longer relevant.
File tests/mocks/drivers/spi-generic.c:
https://review.coreboot.org/c/coreboot/+/42612/comment/6dc3eeb6_45ac2b88 PS2, Line 23: return 0;
The real code returns at most buf_len here, so I'm not sure unconditionally returning UINT16_MAX is […]
Done
File tests/stubs/console/console.c:
PS22:
There already is implementation of (v)printk() stubs in tests/stubs/console. […]
Done
https://review.coreboot.org/c/coreboot/+/42612/comment/c3796ae0_a667248b PS22, Line 5: int do_printk(int msg_level, const char *fmt, ...)
Removed in CB:51887
Done
https://review.coreboot.org/c/coreboot/+/42612/comment/baa88175_9e3eb79c PS22, Line 10: do_vprintk
Removed in CB:51887
Done
-
Daniel Gröber (dxld) (Code Review)