Attention is currently required from: Jakub Czapiga, Daniel Gröber, Julius Werner.

View Change

5 comments:

• File tests/mocks/console/console.c:

  • Patch Set #2, Line 7: return -1;

    Doing strlen(fmt) seems a bit overkill to me, especially since it's still not quite the correct retu […]

    Our console stubs were superceded so this is no longer relevant.

• File tests/mocks/drivers/spi-generic.c:

  • Patch Set #2, Line 23: return 0;

    The real code returns at most buf_len here, so I'm not sure unconditionally returning UINT16_MAX is […]

    Done

• File tests/stubs/console/console.c:

  • Patch Set #22:

    There already is implementation of (v)printk() stubs in tests/stubs/console. […]

    Done

  • Patch Set #22, Line 5: int do_printk(int msg_level, const char *fmt, ...)

    Removed in CB:51887

    Done

  • Patch Set #22, Line 10: do_vprintk

    Removed in CB:51887

    Done

To view, visit change 42612. To unsubscribe, or for help writing mail filters, visit settings.