[M] Change in coreboot[master]: tests: Add debug() macro enabled by TEST_DEBUG env-var
Daniel Gröber (dxld) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44083 ) Change subject: tests: Add debug() macro enabled by TEST_DEBUG env-var ...................................................................... Patch Set 17: (2 comments) Patchset: PS17: Thanks for the reivew Jakub. File tests/debug.c: https://review.coreboot.org/c/coreboot/+/44083/comment/059ebed9_f7897c9c PS17, Line 11: if (argc > 1 && strcmp(argv[1], "--debug") == 0) : test_debug = 1; : }
There already is TEST_PRINT which enables printk() stubs. […] Right, I think that didn't exist when I first submitted this series two years ago :)
I'll drop this patch then. -- To view, visit https://review.coreboot.org/c/coreboot/+/44083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdea534e414c45cd9bc209636a03c6fadaa79e79 Gerrit-Change-Number: 44083 Gerrit-PatchSet: 17 Gerrit-Owner: Daniel Gröber (dxld) <coreboot@dxld.at> Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Daniel Gröber <dxld@darkboxed.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Mon, 27 Feb 2023 17:43:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz@semihalf.com> Gerrit-MessageType: comment
participants (1)
-
Daniel Gröber (dxld) (Code Review)