build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59737 )
Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/google/brya/variants/primus/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704): https://review.coreboot.org/c/coreboot/+/59737/comment/3beb3daf_922a6d66 PS2, Line 132: PAD_CFG_GPO(GPP_B4, 0, DEEP),q space required after that ',' (ctx:VxV)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704): https://review.coreboot.org/c/coreboot/+/59737/comment/062e9bd4_32804ad7 PS2, Line 43: if (board_ver <2) { spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704): https://review.coreboot.org/c/coreboot/+/59737/comment/8360c38b_24c5326e PS2, Line 52: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704): https://review.coreboot.org/c/coreboot/+/59737/comment/6b1c3566_d06979e2 PS2, Line 113: if (board_ver >1) { spaces required around that '>' (ctx:WxV)