View Change

4 comments:

• File src/mainboard/google/brya/variants/primus/gpio.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704):

    Patch Set #2, Line 132: PAD_CFG_GPO(GPP_B4, 0, DEEP),q

    space required after that ',' (ctx:VxV)

• File src/mainboard/google/brya/variants/primus/variant.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704):

    Patch Set #2, Line 43: if (board_ver <2) {

    spaces required around that '<' (ctx:WxV)

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704):

    Patch Set #2, Line 52: else {

    else should follow close brace '}'

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134704):

    Patch Set #2, Line 113: if (board_ver >1) {

    spaces required around that '>' (ctx:WxV)

To view, visit change 59737. To unsubscribe, or for help writing mail filters, visit settings.