Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Tim Wawrzynczak, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 )
Change subject: soc/intel/common: Add CPU related APIs ......................................................................
Patch Set 8:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59124/comment/cafc87a7_2d81962b PS7, Line 13: cpu_get_cpu_typ
`cpu_get_cpu_type`
Ack
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/59124/comment/b7cc56f8_6c23566e PS7, Line 34: #define CPUID_PROCESSOR_FREQUENCY 0x16 : : #define CPUID_HYBRID_INFORMATION 0x1a : : /* Structured Extended Feature Flags */ : #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 : #define HYBRID_FEATURE BIT(15)
please use tabs for indentation, and also align the right sides
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/5d8a7cf7_976303bf PS7, Line 199: cpu
CPU
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/1e866eed_7141833e PS7, Line 199: cpu
CPU
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/bdb021a5_ee99c2d7 PS7, Line 212:
nit: extra space
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/8912bd27_5deb7b7a PS7, Line 220: core_type
What are the possible return values?
10h(Reserved), 20h(Atom), 30h(Reserved),40h(Core)
https://review.coreboot.org/c/coreboot/+/59124/comment/4b503e79_abfd864b PS7, Line 224: cpu_get_bus_frequency
What unit is this in? MHz?
It is in MHz.
-
Sridhar Siricilla (Code Review)