Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Tim Wawrzynczak, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph.

7 comments:

Commit Message:
- Patch Set #7, Line 13: cpu_get_cpu_typ
  `cpu_get_cpu_type`
  Ack
File src/soc/intel/common/block/cpu/cpulib.c:
- Patch Set #7, Line 34:
```
#define CPUID_PROCESSOR_FREQUENCY 0x16

#define CPUID_HYBRID_INFORMATION       0x1a

/* Structured Extended Feature Flags */
#define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7
#define HYBRID_FEATURE	BIT(15)
```
  please use tabs for indentation, and also align the right sides
  Ack
- Patch Set #7, Line 199: cpu
  CPU
  Ack
- Patch Set #7, Line 199: cpu
  CPU
  Ack
- Patch Set #7, Line 212:
  nit: extra space
  Ack
- Patch Set #7, Line 220: core_type
  What are the possible return values?
  10h(Reserved), 20h(Atom), 30h(Reserved),40h(Core)
- Patch Set #7, Line 224: cpu_get_bus_frequency
  What unit is this in? MHz?
  It is in MHz.

To view, visit change 59124. To unsubscribe, or for help writing mail filters, visit settings.