Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS
I often find myself having to increase the CBFS size so that TianoCore fits. Raise the default CBFS size to 2 MiB to alleviate this issue.
Change-Id: I871bb95dee55cc5bad68bb6e71f89ddfa4823497 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46488/1
diff --git a/src/mainboard/asrock/b85m_pro4/Kconfig b/src/mainboard/asrock/b85m_pro4/Kconfig index 844604a..f55cf09 100644 --- a/src/mainboard/asrock/b85m_pro4/Kconfig +++ b/src/mainboard/asrock/b85m_pro4/Kconfig @@ -18,6 +18,10 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_NUVOTON_NCT6776
+config CBFS_SIZE + hex + default 0x200000 + config MAINBOARD_DIR string default "asrock/b85m_pro4"
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1: Code-Review+2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000 I would raise it to the maximum available size
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000
I would raise it to the maximum available size
IMO CBFS_SIZE should always be max. bios size. if there are reasons to lower it, it can always be adapted locally
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000
IMO CBFS_SIZE should always be max. bios size. […]
Michael, I purposefully made this patch to avoid having to work around things locally.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000
Michael, I purposefully made this patch to avoid having to work around things locally.
The help text on this Kconfig says "... It defaults to span the whole ROM on all but Intel systems that use an Intel Firmware Descriptor". Clearly it can't span the whole ROM on Intel systems with IFD because IFD and ME need space. However, this is expected to span as much as possible.
-> set the full bios region size to provide a sensible default for the general user
If you have special requirements, then you always can either use a config file or have a patch locally adapting that value.
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Abandoned
Getting things fixed upstream takes too much effort.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000
The help text on this Kconfig says "... […]
do as you wish... probably it's not that important
Angel Pons has restored this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Restored
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS
I often find myself having to increase the CBFS size so that TianoCore fits. Raise the default CBFS size to 2 MiB to alleviate this issue.
Change-Id: I871bb95dee55cc5bad68bb6e71f89ddfa4823497 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46488 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/mainboard/asrock/b85m_pro4/Kconfig b/src/mainboard/asrock/b85m_pro4/Kconfig index 844604a..f55cf09 100644 --- a/src/mainboard/asrock/b85m_pro4/Kconfig +++ b/src/mainboard/asrock/b85m_pro4/Kconfig @@ -18,6 +18,10 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_NUVOTON_NCT6776
+config CBFS_SIZE + hex + default 0x200000 + config MAINBOARD_DIR string default "asrock/b85m_pro4"
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Singer (Code Review)
-
Michael Niewöhner (Code Review)