Alec Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Add PEN to devicetree for boten
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index bd7d36e..fbc669f 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -2,6 +2,7 @@ def_bool n select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 select DPTF_USE_EISA_HID + select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_INTEL_DPTF diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c index 05a567f..f889c7f 100644 --- a/src/mainboard/google/dedede/variants/boten/gpio.c +++ b/src/mainboard/google/dedede/variants/boten/gpio.c @@ -7,6 +7,8 @@
/* Pad configuration in ramstage*/ static const struct pad_config gpio_table[] = { + /* C12 : AP_PEN_DET_ODL */ + PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE), /* C18 : AP_I2C_EMR_SDA */ PAD_NC(GPP_C18, NONE), /* C19 : AP_I2C_EMR_SCL */ diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 61dff93..b1fcbe6 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -9,9 +9,8 @@ #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | - #| I2C1 | Digitizer | + #| I2C1 | Stylus | #| I2C2 | Touchscreen | - #| I2C3 | Camera | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -28,14 +27,35 @@ .i2c[2] = { .speed = I2C_SPEED_FAST, }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, }" + + register "SerialIoI2cMode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + device domain 0 on + device pci 15.1 on + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_C12)" + register "key.wake_gpe" = "GPE0_DW2_12" + register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end + end # I2C 1 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/1/src/mainboard/google/dedede... PS1, Line 14: #| I2C3 | Camera | You should either update the commit message to include that you've removed the camera, or move the I2C3 changes into a separate CL.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#2).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Add PEN to devicetree for boten and removed I2C3 camera description
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/2
Hello build bot (Jenkins), Henry Sun, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#3).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Add PEN to devicetree for boten and removed unused I2C3 camera
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/3
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/1/src/mainboard/google/dedede... PS1, Line 14: #| I2C3 | Camera |
You should either update the commit message to include that you've removed the camera, or move the I […]
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 3: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG@9 PS3, Line 9: Add PEN to devicetree Is it garaged stylus. Did you verify the Stylus menu pops up when the PEN is ejected from the garage?
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG@9 PS3, Line 9: Add PEN to devicetree
Is it garaged stylus. […]
Yes, It is garaged stylus. We will verify after EVT, because we don't have boxed DUT to verify it.
Peichao Wang has uploaded a new patch set (#4) to the change originally created by Alec Wang. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C3 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/4
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/3//COMMIT_MSG@9 PS3, Line 9: Add PEN to devicetree
Yes, It is garaged stylus. […]
This CL need to be rebased.
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 4: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG@9 PS4, Line 9: I2C3 The stylus is on I2C1 now
Peichao Wang has uploaded a new patch set (#5) to the change originally created by Alec Wang. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C1 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/5
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG@9 PS4, Line 9: I2C3
The stylus is on I2C1 now
Hi Paul, thanks for your reminder, correct it.
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45807/4//COMMIT_MSG@9 PS4, Line 9: I2C3
Hi Paul, thanks for your reminder, correct it.
Done
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#6).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C1 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/6
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 7: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 7: Code-Review+1
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 12: | nit: please align the "|"
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 109: device pci 15.1 on As I know, USI stylus and touchscreen controller are supported by I2C 2 and the pen detection here is not on I2C bus so why do we need to enable i2c 1 here?
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 112: ACPI_GPIO_INPUT_ACTIVE_LOW Wondering to know whether we should monitor both edge for pen inserted and ejected?
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#8).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C1 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/8
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 12: |
nit: please align the "|"
Done
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 109: device pci 15.1 on
As I know, USI stylus and touchscreen controller are supported by I2C 2 and the pen detection here i […]
Done
https://review.coreboot.org/c/coreboot/+/45807/7/src/mainboard/google/dedede... PS7, Line 112: ACPI_GPIO_INPUT_ACTIVE_LOW
Wondering to know whether we should monitor both edge for pen inserted and ejected?
Done
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#9).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/9
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#10).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable stylus and remove unuse I2C1
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/10
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 10: Code-Review+1
Hi Alex, do you verify this CL in the real DUT and make sure pen detection is working?
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 10:
Patch Set 10: Code-Review+1
Hi Alex, do you verify this CL in the real DUT and make sure pen detection is working?
Hi Marco,
We will verify this CL after EVT because we don't have box DUT to test now.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... PS10, Line 12: stylus Nit: Stylus with a capital 'S'
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... PS10, Line 110: GPE0_DW2_12 GPE0_DW1_12
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#11).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C1 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/11
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... PS10, Line 12: stylus
Nit: Stylus with a capital 'S'
Done
https://review.coreboot.org/c/coreboot/+/45807/10/src/mainboard/google/deded... PS10, Line 110: GPE0_DW2_12
GPE0_DW1_12
Thanks for your reminder.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 11: Code-Review+2
I assume the removal of I2C 1 would be removed from https://review.coreboot.org/c/coreboot/+/46333 .
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/11/src/mainboard/google/deded... PS11, Line 38: [PchSerialIoIndexI2C1] = PchSerialIoPci, Sorry for missing this in my previous comment. Set it to PchSerialIoDisabled since you are disabling I2C1 in this CL.
Also as Marco mentioned, please either rebase CB:46333 on top of this CL or remove disabling I2C1 in that CL.
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#12).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable I2C1 for stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/12
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#13).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/13
Hello build bot (Jenkins), Peichao Wang, Henry Sun, Paul Fagerburg, Marco Chen, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45807
to look at the new patch set (#14).
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45807/14
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45807/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45807/11/src/mainboard/google/deded... PS11, Line 38: [PchSerialIoIndexI2C1] = PchSerialIoPci,
Sorry for missing this in my previous comment. […]
I have recovered it. Thanks.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 14: Code-Review+2
Thanks Karthik to catch the error and please mark addressed command as done.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 14: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
Patch Set 14: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45807 )
Change subject: mb/google/dedede: add PEN for Boten ......................................................................
mb/google/dedede: add PEN for Boten
Update devicetree of boten that enable stylus
BUG=b:160752604 BRANCH=NONE TEST=build bios and verify function for boten
Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: Ifbcac18fcf758f3d870a6af0d1b03e34369414c0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45807 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Jamie Chen jamie.chen@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/gpio.c M src/mainboard/google/dedede/variants/boten/overridetree.cb 3 files changed, 16 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Jamie Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 377702d..597516c 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -3,6 +3,7 @@ select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 select CR50_USE_LONG_INTERRUPT_PULSES select DPTF_USE_EISA_HID + select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_I2C_GENERIC select DRIVERS_I2C_GPIO_MUX select DRIVERS_I2C_HID diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c index 05a567f..f889c7f 100644 --- a/src/mainboard/google/dedede/variants/boten/gpio.c +++ b/src/mainboard/google/dedede/variants/boten/gpio.c @@ -7,6 +7,8 @@
/* Pad configuration in ramstage*/ static const struct pad_config gpio_table[] = { + /* C12 : AP_PEN_DET_ODL */ + PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE), /* C18 : AP_I2C_EMR_SDA */ PAD_NC(GPP_C18, NONE), /* C19 : AP_I2C_EMR_SCL */ diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 2ba6d9d..fa6cf22 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -10,7 +10,7 @@ #| | before memory is up | #| I2C0 | Trackpad | #| I2C1 | Digitizer | - #| I2C2 | Touchscreen | + #| I2C2 | Touchscreen, Stylus | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -107,6 +107,18 @@ end end # I2C 0 device pci 15.2 on + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_C12)" + register "key.wake_gpe" = "GPE0_DW1_12" + register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen""
-
Alec Wang (Code Review) -
Jamie Chen (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Peichao Wang (Code Review)