Change in coreboot[master]: mb/google/dedede: Add P-sensor for Boten

[Alec Wang (Code Review)]

Alec Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 15 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46333/1

diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb
index 2ba6d9d..1346470 100644
--- a/src/mainboard/google/dedede/variants/boten/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb
@@ -9,9 +9,9 @@
    #|                   | for TPM communication     |
    #|                   | before memory is up       |
    #| I2C0              | Trackpad                  |
-	#| I2C1              | Digitizer                 |
    #| I2C2              | Touchscreen               |
    #| I2C4              | Audio                     |
+        #| I2C5              | P-Sensor                  |
    #+-------------------+---------------------------+
    register "common_soc_config" = "{
    	.gspi[0] = {
@@ -21,15 +21,15 @@
    	.i2c[0] = {
    		.speed = I2C_SPEED_FAST,
    	},
-		.i2c[1] = {
-			.speed = I2C_SPEED_FAST,
-		},
    	.i2c[2] = {
    		.speed = I2C_SPEED_FAST,
    	},
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
    	},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+		},
    }"

# USB Port Configuration
@@ -39,7 +39,7 @@

register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,
-		[PchSerialIoIndexI2C1]  = PchSerialIoPci,
+		[PchSerialIoIndexI2C1]  = PchSerialIoDisabled,
    	[PchSerialIoIndexI2C2]  = PchSerialIoPci,
    	[PchSerialIoIndexI2C3]  = PchSerialIoDisabled,
    	[PchSerialIoIndexI2C4]  = PchSerialIoPci,
@@ -149,7 +149,16 @@
    			register "uid" = "1"
    			device i2c 29 on end
    		end
-		end
+		end # I2C 4
+		device pci 19.1 on
+			chip drivers/i2c/generic
+				register "hid" = ""STH9324""
+				register "name" = ""SEMTECH SX9324""
+				register "desc" = ""SAR Proximity Sensor""
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)"
+				device i2c 28 on end
+			end
+		end # I2C 5
    	device pci 1f.3 on end # Intel HDA
    end
 end

[Peichao Wang (Code Review)]

Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 1: Code-Review+1

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 12: 	#| I2C1              | Digitizer                 |
Conflict to https://review.coreboot.org/c/coreboot/+/45807 . And if really necessary for this change then please split to another CL since it is not what commit msg mentioned.

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 158: GPP_E11_IRQ
Could we check with SoC team about whether the GPIO config of this GP_E11 is correct or not?

[Peichao Wang (Code Review)]

Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 158: GPP_E11_IRQ
> Could we check with SoC team about whether the GPIO config of this GP_E11 is correct or not?

Dear Marco, I have check Boten Sch and confirm with LCFC team this section electric circuit no change, so I think GPP_E11 is correct for interrupt of P sensor, BTW I have request LCFC team confirm this section with Intel team again. Thanks a lot!

[Alec Wang (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Peichao Wang, Henry Sun, Marco Chen, Karthik Ramasubramanian, Gwendal Grignou,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46333

to look at the new patch set (#2).

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor and remove unuse I2C1

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 15 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46333/2

[Alec Wang (Code Review)]

Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 158: GPP_E11_IRQ
> Dear Marco, I have check Boten Sch and confirm with LCFC team this section electric circuit no chang […]

Intel have confirmed it.
It's correct.

[Alec Wang (Code Review)]

Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 12: 	#| I2C1              | Digitizer                 |
> Conflict to https://review.coreboot.org/c/coreboot/+/45807 . […]

add to commit message.

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede... 
PS1, Line 12: 	#| I2C1              | Digitizer                 |
> add to commit message.

https://review.coreboot.org/c/coreboot/+/45807 also try to remove the same thing so I suggest this CL can ignore this part especially when I2C1 / Stylus is not related to P Sensor here.

[Alec Wang (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Peichao Wang, Henry Sun, Marco Chen, Karthik Ramasubramanian, Gwendal Grignou,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46333

to look at the new patch set (#3).

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 15 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46333/3

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/3/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/3/src/mainboard/google/dedede... 
PS3, Line 12: 	#| I2C1              | Digitizer                 |
https://review.coreboot.org/c/coreboot/+/45807 also try to remove the same thing so I suggest this CL can ignore this part especially when I2C1 / Digitizer is not related to P Sensor here.

[Alec Wang (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Peichao Wang, Henry Sun, Marco Chen, Karthik Ramasubramanian, Gwendal Grignou,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46333

to look at the new patch set (#4).

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 17 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46333/4

[Alec Wang (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Peichao Wang, Henry Sun, Marco Chen, Karthik Ramasubramanian, Gwendal Grignou,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46333

to look at the new patch set (#5).

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/46333/5

[Alec Wang (Code Review)]

Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46333/3/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/boten/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46333/3/src/mainboard/google/dedede... 
PS3, Line 12: 	#| I2C1              | Digitizer                 |
> https://review.coreboot. […]

I have added a new CL for it.
Thanks.

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 5: Code-Review+2

Please remember to address the comment as done.

[Jamie Chen (Code Review)]

Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 5: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

Patch Set 5: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46333 )

Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................

mb/google/dedede: Add P-sensor for Boten

Add devicetree and device ID for P-sensor

BUG=b:161217096
BRANCH=NONE
TEST=We can get the data from P-sensor if touch the SAR antenna.

Signed-off-by: alec.wang 
Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46333
Tested-by: build bot (Jenkins) 
Reviewed-by: Marco Chen 
Reviewed-by: Jamie Chen 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/dedede/variants/boten/overridetree.cb
1 file changed, 14 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Marco Chen: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Jamie Chen: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb
index fa6cf22..4ec6457 100644
--- a/src/mainboard/google/dedede/variants/boten/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb
@@ -12,6 +12,7 @@
    #| I2C1              | Digitizer                 |
    #| I2C2              | Touchscreen, Stylus       |
    #| I2C4              | Audio                     |
+        #| I2C5              | P-Sensor                  |
    #+-------------------+---------------------------+
    register "common_soc_config" = "{
    	.gspi[0] = {
@@ -30,6 +31,9 @@
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
    	},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+		},
    }"

# USB Port Configuration
@@ -161,7 +165,16 @@
    			register "uid" = "1"
    			device i2c 29 on end
    		end
-		end
+		end # I2C 4
+		device pci 19.1 on
+			chip drivers/i2c/generic
+				register "hid" = ""STH9324""
+				register "name" = ""SEMTECH SX9324""
+				register "desc" = ""SAR Proximity Sensor""
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)"
+				device i2c 28 on end
+			end
+		end # I2C 5
    	device pci 1f.3 on end # Intel HDA
    end
 end