16 Oct
2020
16 Oct
'20
8:35 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46488 )
Change subject: mb/asrock/b85m_pro4/Kconfig: Default to 2 MiB CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/Kconfig:
https://review.coreboot.org/c/coreboot/+/46488/1/src/mainboard/asrock/b85m_p... PS1, Line 23: default 0x200000
I would raise it to the maximum available size
IMO CBFS_SIZE should always be max. bios size. if there are reasons to lower it, it can always be adapted locally
--
To view, visit https://review.coreboot.org/c/coreboot/+/46488
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I871bb95dee55cc5bad68bb6e71f89ddfa4823497
Gerrit-Change-Number: 46488
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 18:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment