Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the Woomax variant of the zork.
BUG=b:158343602 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/gpio.c A src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb A src/mainboard/google/zork/variants/woomax/spd/Makefile.inc 13 files changed, 334 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index f6061c5..4aac136 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -64,6 +64,7 @@ default "dalboz" if BOARD_GOOGLE_DALBOZ default "berknip" if BOARD_GOOGLE_BERKNIP default "vilboz" if BOARD_GOOGLE_VILBOZ + default "woomax" if BOARD_GOOGLE_WOOMAX
config MAINBOARD_PART_NUMBER string @@ -73,6 +74,7 @@ default "Dalboz" if BOARD_GOOGLE_DALBOZ default "Berknip" if BOARD_GOOGLE_BERKNIP default "Vilboz" if BOARD_GOOGLE_VILBOZ + default "Woomax" if BOARD_GOOGLE_WOOMAX
config DEVICETREE string diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 2f721d4..801c1b7 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -23,3 +23,7 @@ config BOARD_GOOGLE_BERKNIP bool "-> Berknip" select BOARD_GOOGLE_BASEBOARD_TREMBYLE + +config BOARD_GOOGLE_WOOMAX + bool "-> Woomax" + select BOARD_GOOGLE_BASEBOARD_TREMBYLE diff --git a/src/mainboard/google/zork/variants/woomax/Makefile.inc b/src/mainboard/google/zork/variants/woomax/Makefile.inc new file mode 100644 index 0000000..8142ac4 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/Makefile.inc @@ -0,0 +1,16 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +subdirs-y += ./spd + +ramstage-y += gpio.c diff --git a/src/mainboard/google/zork/variants/woomax/gpio.c b/src/mainboard/google/zork/variants/woomax/gpio.c new file mode 100644 index 0000000..222360e --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/gpio.c @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boardid.h> +#include <gpio.h> +#include <soc/gpio.h> +#include <ec/google/chromeec/ec.h> + +static const struct soc_amd_gpio woomax_gpio_set_stage_ram[] = { + /* GPIO_4 NC */ + PAD_GPI(GPIO_4, PULL_UP), + /* GPIO_5 NC */ + PAD_GPI(GPIO_5, PULL_UP), + /* GPIO_6 NC */ + PAD_GPI(GPIO_6, PULL_UP), + /* GPIO_11 NC */ + PAD_GPI(GPIO_11, PULL_UP), + /* GPIO_32 NC */ + PAD_GPI(GPIO_32, PULL_UP), + /* GPIO_69 NC */ + PAD_GPI(GPIO_69, PULL_UP), + /* RAM_ID_4 */ + PAD_GPI(GPIO_84, PULL_NONE), + /* GPIO_141 NC */ + PAD_GPI(GPIO_141, PULL_UP), + /* GPIO_143 NC */ + PAD_GPI(GPIO_143, PULL_UP), +}; + +const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) +{ + *size = ARRAY_SIZE(woomax_gpio_set_stage_ram); + return woomax_gpio_set_stage_ram; +} diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl new file mode 100644 index 0000000..71a4920 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..63eb280 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..a401b3a --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/sleep.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..a7e511c --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/ec.h b/src/mainboard/google/zork/variants/woomax/include/variant/ec.h new file mode 100644 index 0000000..fbd60dc --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/ec.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h b/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h new file mode 100644 index 0000000..726d255 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h b/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h new file mode 100644 index 0000000..addce73 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb new file mode 100644 index 0000000..c6a3ff0 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -0,0 +1,142 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #55593 Chapter 3.2 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "2" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "25000" #mw + register "fast_ppt_limit" = "30000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "200" #second + register "sustained_power_limit" = "15000" #mw + + register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_offset" = "0" + register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_offset" = "0" + + # End : OPN Performance Configuration + + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 21, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 76, /* 2.31 to 0 */ + }" + + # Enable I2C3 for H1 400kHz + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 37, /* 1.26v to 0 */ + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 1.6 off end # GPP Bridge 5 + device pci 1.7 on end # GPP Bridge 6 - NVME + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on + chip drivers/usb/acpi + register "desc" = ""Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Left Type-C Port"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(1, 1)" + device usb 2.0 on end + end + chip drivers/usb/acpi + register "desc" = ""Left Type-A Port"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device usb 2.1 on end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-C Port"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 2.3 on end + end + chip drivers/usb/acpi + register "desc" = ""User-Facing Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.4 on end + end + chip drivers/usb/acpi + register "desc" = ""Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""Left Type-C Port"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(1, 1)" + device usb 3.0 on end + end + chip drivers/usb/acpi + register "desc" = ""Left Type-A Port"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device usb 3.1 on end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-C Port"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(2, 1)" + device usb 3.3 on end + end + chip drivers/usb/acpi + register "desc" = ""AR Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 3.4 on end + end + end + end + end # USB 3.1 + device pci 0.4 on end # USB 3.1 + end + device pci 14.6 off end # Non-Functional SDHCI + end # domain + + device mmio 0xfedc4000 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "wake" = "22" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "probed" = "1" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" + register "reset_delay_ms" = "20" + register "has_power_resource" = "1" + device i2c 10 on end + end + end + +end # chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc new file mode 100644 index 0000000..79fac45 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc @@ -0,0 +1,37 @@ +## +## This file is part of the coreboot project. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +# Ordered List of APCB entries, upto 16. +# Entries should match this pattern {NAME}_x{1,2} +# There should be a matching SPD hex file in SPD_SOURCES_DIR +# matching the pattern {NAME}.spd.hex +# The _x{1,2} suffix denotes single or dual channel +# TODO: Remove channel suffix when b:141434940 is fixed +# Alternatively, generated APCBs stored at +# CONFIG_APCB_BLOB_DIR/APCB_{NAME}.bin can be included. +APCB_SOURCES = micron-MT40A512M16TB-062E-J_x1 # 0b00000 +APCB_SOURCES += hynix-H5AN8G6NCJR-XNC_x1 # 0b00001 +APCB_SOURCES += micron-MT40A1G16KD-062E-E_x1 # 0b00010 +APCB_SOURCES += samsung-K4AAG165WA-BCWE_x1 # 0b00011 +APCB_SOURCES += empty # 0b00100 +APCB_SOURCES += empty # 0b00101 +APCB_SOURCES += empty # 0b00110 +APCB_SOURCES += empty # 0b00111 +APCB_SOURCES += micron-MT40A512M16TB-062E-J_x2 # 0b01000 +APCB_SOURCES += hynix-H5AN8G6NCJR-XNC_x2 # 0b01001 +APCB_SOURCES += micron-MT40A1G16KD-062E-E_x2 # 0b01010 +APCB_SOURCES += samsung-K4AAG165WA-BCWE_x2 # 0b01011 +APCB_SOURCES += empty # 0b01100 +APCB_SOURCES += empty # 0b01101 +APCB_SOURCES += empty # 0b01110 +APCB_SOURCES += empty # 0b01111
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42680/1/src/mainboard/google/zork/v... PS1, Line 14: # Ordered List of APCB entries, upto 16. 'upto' may be misspelled - perhaps 'up to'?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42680/1//COMMIT_MSG@9 PS1, Line 9: Create the Woomax variant of the zork. Created how? By script or by copying existing variant?
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42680/1//COMMIT_MSG@9 PS1, Line 9: Create the Woomax variant of the zork.
Created how? By script or by copying existing variant?
Create by script and add configuration settings for Woomax
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#2).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 11 files changed, 183 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#3).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 11 files changed, 183 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/3
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#4).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 11 files changed, 183 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 4:
(11 comments)
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... PS4, Line 146: default 2 if BOARD_GOOGLE_VILBOZ This will have to be set as per the board id for Woomax build.
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... PS4, Line 152: default 3 if BOARD_GOOGLE_VILBOZ This too.
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : # # SPDX-License-Identifier: GPL-2.0-or-later
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl:
PS4: This file is not required anymore: https://review.coreboot.org/c/coreboot/+/43042
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ : /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/thermal.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : # # SPDX-License-Identifier: GPL-2.0-or-later
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#5).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1 Is this correct? My understanding is that board id 1 does not really have the hardware change for active low wifi power. (It went in v3.51 for Trembyle reference schematics).
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Is this correct? My understanding is that board id 1 does not really have the hardware change for ac […]
Woomax mainboard design in proto stage reference Trembyle schematics v3.4 . The wifi power is going to active high . The wifi power of Woomax mainboard in EVT stage will change to active low .
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Woomax mainboard design in proto stage reference Trembyle schematics v3.4 . […]
So, this will have to be set to 2.
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
So, this will have to be set to 2.
We will set board id to be 1 on Woomax mainboard of EVT stage . Should we set it to be 2 instead of 1 ?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
We will set board id to be 1 on Woomax mainboard of EVT stage . […]
No, I meant current revision of hardware is using board ID 1 and it follow v3+ schematics. So, VARIANT_MIN_BOARD_ID_V3_SCHEMATICS is set to 1 for BOARD_GOOGLE_WOOMAX. Since WiFi power enable will be changed to active low in next revision of hardware, VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW needs to be set to 2.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
No, I meant current revision of hardware is using board ID 1 and it follow v3+ schematics. […]
Regarding board id assignment for different stages - can you please raise a separate bug. Let's continue discussion on the bug.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Regarding board id assignment for different stages - can you please raise a separate bug. […]
Actually, I just looked back into the CBI bug for Woomax: https://b.corp.google.com/issues/157448008#comment17 and it looks like current build is using ID 0 and next build would be using ID 1. In that case, VARIANT_MIN_BOARD_ID_V3_SCHEMATICS should be set to 0 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW should be set to 1.
Does that align with your understanding?
Ken Lu has uploaded a new patch set (#7) to the change originally created by Kane Chen. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/7
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Actually, I just looked back into the CBI bug for Woomax: https://b.corp.google. […]
Yes , you are right . I should set VARIANT_MIN_BOARD_ID_V3_SCHEMATICS to be 0 and VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW to be 1. Thanks for your clarification .
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Yes , you are right . […]
Modification complete .
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/6/src/mainboard/google/zork/K... PS6, Line 155: 1
Modification complete .
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 7:
https://qa.coreboot.org/job/coreboot-gerrit/133695/ : UNSTABLE
I have pushed some changes that should address the breakage that you are seeing with VARIANT_MIN_BOARD_ID_V3_SCHEMATICS being set to 0: https://review.coreboot.org/c/coreboot/+/43224
Can you please rebase this change on top of the patch series ending at https://review.coreboot.org/c/coreboot/+/43225? And then you just need to set VARIANT_MIN_BOARD_ID_WIFI_POWER_ACTIVE_LOW to 1. VARIANT_MIN_BOARD_ID_V3_SCHEMATICS needs to be set only if the variant has to support PRE_V3 schematics. Since woomax doesn't need it, you can skip setting of VARIANT_MIN_BOARD_ID_V3_SCHEMATICS altogether.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#8).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/8
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... PS8, Line 176: default 1 if BOARD_GOOGLE_VILBOZ : default 0 if BOARD_GOOGLE_WOOMAX This is not required anymore.
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... PS8, Line 187: default y if BOARD_GOOGLE_VILBOZ You need: default y if BOARD_GOOGLE_WOOMAX here
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#9).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/9
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42680
to look at the new patch set (#10).
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/42680/10
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... PS8, Line 176: default 1 if BOARD_GOOGLE_VILBOZ : default 0 if BOARD_GOOGLE_WOOMAX
This is not required anymore.
Done
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K... PS8, Line 187: default y if BOARD_GOOGLE_VILBOZ
You need: […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 10: Code-Review+2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... PS4, Line 146: default 2 if BOARD_GOOGLE_VILBOZ
This will have to be set as per the board id for Woomax build.
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/K... PS4, Line 152: default 3 if BOARD_GOOGLE_VILBOZ
This too.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 10:
(9 comments)
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : #
# SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl:
PS4:
This file is not required anymore: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ :
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/thermal.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : #
# SPDX-License-Identifier: GPL-2. […]
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
mb/google/zork: Create Woomax variant
Create the woomax variant of the zork reference board by copying the template(coreboot-zork/util/mainboard/google/trembyle) files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.1.1).
BUG=b:158343602 BRANCH=None TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42680 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/woomax/Makefile.inc A src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/woomax/include/variant/ec.h A src/mainboard/google/zork/variants/woomax/include/variant/gpio.h A src/mainboard/google/zork/variants/woomax/include/variant/thermal.h A src/mainboard/google/zork/variants/woomax/overridetree.cb 10 files changed, 84 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 50cc6f8..891f2b8 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -67,6 +67,7 @@ default "dalboz" if BOARD_GOOGLE_DALBOZ default "berknip" if BOARD_GOOGLE_BERKNIP default "vilboz" if BOARD_GOOGLE_VILBOZ + default "woomax" if BOARD_GOOGLE_WOOMAX
config MAINBOARD_PART_NUMBER string @@ -76,6 +77,7 @@ default "Dalboz" if BOARD_GOOGLE_DALBOZ default "Berknip" if BOARD_GOOGLE_BERKNIP default "Vilboz" if BOARD_GOOGLE_VILBOZ + default "Woomax" if BOARD_GOOGLE_WOOMAX
config DEVICETREE string @@ -181,6 +183,7 @@ default y if VARIANT_SUPPORTS_PRE_V3_SCHEMATICS default y if BOARD_GOOGLE_BERKNIP default y if BOARD_GOOGLE_VILBOZ + default y if BOARD_GOOGLE_WOOMAX default n help Whether this variant supports active high power enable for @@ -197,6 +200,7 @@ depends on VARIANT_SUPPORTS_WIFI_POWER_ACTIVE_HIGH default 3 if BOARD_GOOGLE_BERKNIP default 2 if BOARD_GOOGLE_VILBOZ + default 1 if BOARD_GOOGLE_WOOMAX default VARIANT_MIN_BOARD_ID_V3_SCHEMATICS help Minimum board version where the variant starts supporting diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 2f721d4..801c1b7 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -23,3 +23,7 @@ config BOARD_GOOGLE_BERKNIP bool "-> Berknip" select BOARD_GOOGLE_BASEBOARD_TREMBYLE + +config BOARD_GOOGLE_WOOMAX + bool "-> Woomax" + select BOARD_GOOGLE_BASEBOARD_TREMBYLE diff --git a/src/mainboard/google/zork/variants/woomax/Makefile.inc b/src/mainboard/google/zork/variants/woomax/Makefile.inc new file mode 100644 index 0000000..9dc5159 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ../baseboard/spd diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..8177a9d --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/sleep.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/ec.h b/src/mainboard/google/zork/variants/woomax/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h b/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h b/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb new file mode 100644 index 0000000..7b58df1 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #55593 Chapter 3.2 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "2" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "25000" #mw + register "fast_ppt_limit" = "30000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "200" #second + register "sustained_power_limit" = "15000" #mw + + register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_offset" = "0" + register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_offset" = "0" + + # End : OPN Performance Configuration + + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 21, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 76, /* 2.31 to 0 */ + }" + + # Enable I2C3 for H1 400kHz + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 37, /* 1.26v to 0 */ + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 1.6 off end # GPP Bridge 5 + device pci 1.7 on end # GPP Bridge 6 - NVME + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on end # USB 3.1 + device pci 0.4 on end # USB 3.1 + end + device pci 14.6 off end # Non-Functional SDHCI + end # domain + + device mmio 0xfedc4000 on end + +end # chip soc/amd/picasso
-
build bot (Jenkins) (Code Review) -
Furquan Shaikh (Code Review)
-
Kane Chen (Code Review)
-
Ken Lu (Code Review)
-
Paul Menzel (Code Review)