Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K...
PS8, Line 176: default 1 if BOARD_GOOGLE_VILBOZ
: default 0 if BOARD_GOOGLE_WOOMAX
This is not required anymore.
Done
https://review.coreboot.org/c/coreboot/+/42680/8/src/mainboard/google/zork/K...
PS8, Line 187: default y if BOARD_GOOGLE_VILBOZ
You need: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bb8ce1851f4064d24e48fd8957e2f9fe1e80b53
Gerrit-Change-Number: 42680
Gerrit-PatchSet: 10
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Jul 2020 07:09:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment