Change in coreboot[master]: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant...
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update() ......................................................................
mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update()
CB:43224 ("mb/google/zork: Add helpers for v3 schematics and wifi power enable") added helper functions for determining if a board uses v3 schematics. However, it introduced a regression by adding a wrong check for variant_uses_v3_schematics() in variant_audio_update(). This change fixes the check to ensure that dmic_gpio is updated when variant is not using v3 schematics.
BUG=b:161141258,b:161128964 TEST=Verified on trembyle that trackpad works again (it was broken because of the regression).
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I0e6ad844f68cface7b545f1547bd94470c30dde4 --- M src/mainboard/google/zork/variants/baseboard/ramstage_common.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/43415/1
diff --git a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c index 143c1b4..f7f11b8 100644 --- a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c +++ b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c @@ -10,7 +10,7 @@ struct soc_amd_picasso_config *cfg = config_of_soc(); struct acpi_gpio *gpio = &cfg->dmic_select_gpio;
- if (!variant_uses_v3_schematics()) + if (variant_uses_v3_schematics()) return;
if (CONFIG(BOARD_GOOGLE_BASEBOARD_TREMBYLE))
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update() ......................................................................
Patch Set 1: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update() ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update() ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43415/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update() nit: this is a little long.
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43415
to look at the new patch set (#2).
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() ......................................................................
mb/google/zork: Fix check for variant_uses_v3_schematics()
CB:43224 ("mb/google/zork: Add helpers for v3 schematics and wifi power enable") added helper functions for determining if a board uses v3 schematics. However, it introduced a regression by adding a wrong check for variant_uses_v3_schematics() in variant_audio_update(). This change fixes the check to ensure that dmic_gpio is updated when variant is not using v3 schematics.
BUG=b:161141258,b:161128964 TEST=Verified on trembyle that trackpad works again (it was broken because of the regression).
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I0e6ad844f68cface7b545f1547bd94470c30dde4 --- M src/mainboard/google/zork/variants/baseboard/ramstage_common.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/43415/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43415/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43415/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork: Fix check for variant_uses_v3_schematics() in variant_audio_update()
nit: this is a little long.
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() ......................................................................
Patch Set 2:
Submitting this before the 24-hour deadline because this fixes a regression and is restricted to zork-only.
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43415 )
Change subject: mb/google/zork: Fix check for variant_uses_v3_schematics() ......................................................................
mb/google/zork: Fix check for variant_uses_v3_schematics()
CB:43224 ("mb/google/zork: Add helpers for v3 schematics and wifi power enable") added helper functions for determining if a board uses v3 schematics. However, it introduced a regression by adding a wrong check for variant_uses_v3_schematics() in variant_audio_update(). This change fixes the check to ensure that dmic_gpio is updated when variant is not using v3 schematics.
BUG=b:161141258,b:161128964 TEST=Verified on trembyle that trackpad works again (it was broken because of the regression).
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I0e6ad844f68cface7b545f1547bd94470c30dde4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43415 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/baseboard/ramstage_common.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c index 143c1b4..f7f11b8 100644 --- a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c +++ b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c @@ -10,7 +10,7 @@ struct soc_amd_picasso_config *cfg = config_of_soc(); struct acpi_gpio *gpio = &cfg->dmic_select_gpio;
- if (!variant_uses_v3_schematics()) + if (variant_uses_v3_schematics()) return;
if (CONFIG(BOARD_GOOGLE_BASEBOARD_TREMBYLE))
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)
-
Raul Rangel (Code Review)
-
Rob Barnes (Code Review)