Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43304 )
Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledee ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... PS4, Line 77: 100
And this came from a SiS datasheet somewhere? It's sad when these have to be so high.
Karthik pulled the value here from the discussion on Waddledoo, I'm betting. It's very likely the value is the same, but the partner could provide a better datasheet here.
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... PS4, Line 82: 7
This came from the regulator spec?
Here's where the 7 came from: https://buganizer.corp.google.com/issues/152936541#comment10