Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43304 )
Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledee
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
PS4, Line 77: 100
And this came from a SiS datasheet somewhere? It's sad when these have to be so high.
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
PS4, Line 82: 7
This came from the regulator spec?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42fdc5e8243d2c70c953b2f516c10f84a041c035
Gerrit-Change-Number: 43304
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 17:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment