Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42680 )
Change subject: mb/google/zork: Create Woomax variant ......................................................................
Patch Set 10:
(9 comments)
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : #
# SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/audio.asl:
PS4:
This file is not required anymore: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/sleep.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ :
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/acpi/thermal.asl:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/include/variant/thermal.h:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42680/4/src/mainboard/google/zork/v... PS4, Line 1: # : # This file is part of the coreboot project. : # : # This program is free software; you can redistribute it and/or modify : # it under the terms of the GNU General Public License as published by : # the Free Software Foundation; version 2 of the License. : # : # This program is distributed in the hope that it will be useful, : # but WITHOUT ANY WARRANTY; without even the implied warranty of : # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : # GNU General Public License for more details. : #
# SPDX-License-Identifier: GPL-2. […]
Done