Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37850 )
Change subject: mb/**/hda_verb.c: Correct codec ID on subvendor verbs ......................................................................
mb/**/hda_verb.c: Correct codec ID on subvendor verbs
Looks like the subvendor verb for codec #3 is erroneously using zero as its codec number. Fix that.
Change-Id: I760533c229287627dd0548a06300c376e045302c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/parrot/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37850/1
diff --git a/src/mainboard/google/parrot/hda_verb.c b/src/mainboard/google/parrot/hda_verb.c index 1cb469c..fff530d 100644 --- a/src/mainboard/google/parrot/hda_verb.c +++ b/src/mainboard/google/parrot/hda_verb.c @@ -122,7 +122,7 @@ 4, /* Number of jacks (NID entries) */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101), AZALIA_PIN_CFG(3, 0x05, 0x18560010), AZALIA_PIN_CFG(3, 0x06, 0x18560020), AZALIA_PIN_CFG(3, 0x07, 0x18560030), diff --git a/src/mainboard/intel/baskingridge/hda_verb.c b/src/mainboard/intel/baskingridge/hda_verb.c index 7eca321..d8cdb05 100644 --- a/src/mainboard/intel/baskingridge/hda_verb.c +++ b/src/mainboard/intel/baskingridge/hda_verb.c @@ -48,7 +48,7 @@ 4, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/emeraldlake2/hda_verb.c b/src/mainboard/intel/emeraldlake2/hda_verb.c index 2750a5b..d898bf4 100644 --- a/src/mainboard/intel/emeraldlake2/hda_verb.c +++ b/src/mainboard/intel/emeraldlake2/hda_verb.c @@ -48,7 +48,7 @@ 4, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/wtm2/hda_verb.c b/src/mainboard/intel/wtm2/hda_verb.c index ec7db84..48affa6 100644 --- a/src/mainboard/intel/wtm2/hda_verb.c +++ b/src/mainboard/intel/wtm2/hda_verb.c @@ -48,7 +48,7 @@ 4, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/kontron/ktqm77/hda_verb.c b/src/mainboard/kontron/ktqm77/hda_verb.c index ebd496c..bb05a86 100644 --- a/src/mainboard/kontron/ktqm77/hda_verb.c +++ b/src/mainboard/kontron/ktqm77/hda_verb.c @@ -98,7 +98,7 @@ 4, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x58560010), diff --git a/src/mainboard/samsung/stumpy/hda_verb.c b/src/mainboard/samsung/stumpy/hda_verb.c index 3e011ca..d6a3e51 100644 --- a/src/mainboard/samsung/stumpy/hda_verb.c +++ b/src/mainboard/samsung/stumpy/hda_verb.c @@ -48,7 +48,7 @@ 4, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010),
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37850 )
Change subject: mb/**/hda_verb.c: Correct codec ID on subvendor verbs ......................................................................
Patch Set 1: Code-Review+2
Hello HAOUAS Elyes, Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37850
to look at the new patch set (#2).
Change subject: mb/**/hda_verb.c: Correct codec ID on subvendor verbs ......................................................................
mb/**/hda_verb.c: Correct codec ID on subvendor verbs
Looks like the subvendor verb for codec #3 is erroneously using zero as its codec number. Fix that.
Change-Id: I760533c229287627dd0548a06300c376e045302c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/parrot/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37850/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37850 )
Change subject: mb/**/hda_verb.c: Correct codec ID on subvendor verbs ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37850 )
Change subject: mb/**/hda_verb.c: Correct codec ID on subvendor verbs ......................................................................
mb/**/hda_verb.c: Correct codec ID on subvendor verbs
Looks like the subvendor verb for codec #3 is erroneously using zero as its codec number. Fix that.
Change-Id: I760533c229287627dd0548a06300c376e045302c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37850 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/parrot/hda_verb.c M src/mainboard/intel/baskingridge/hda_verb.c M src/mainboard/intel/emeraldlake2/hda_verb.c M src/mainboard/intel/wtm2/hda_verb.c M src/mainboard/kontron/ktqm77/hda_verb.c M src/mainboard/samsung/stumpy/hda_verb.c 6 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/parrot/hda_verb.c b/src/mainboard/google/parrot/hda_verb.c index 6a015e7..c91cd29 100644 --- a/src/mainboard/google/parrot/hda_verb.c +++ b/src/mainboard/google/parrot/hda_verb.c @@ -117,7 +117,7 @@ 0x00000004, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/baskingridge/hda_verb.c b/src/mainboard/intel/baskingridge/hda_verb.c index bfa49dc..9a29297 100644 --- a/src/mainboard/intel/baskingridge/hda_verb.c +++ b/src/mainboard/intel/baskingridge/hda_verb.c @@ -50,7 +50,7 @@ 0x00000004, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/emeraldlake2/hda_verb.c b/src/mainboard/intel/emeraldlake2/hda_verb.c index bfa49dc..9a29297 100644 --- a/src/mainboard/intel/emeraldlake2/hda_verb.c +++ b/src/mainboard/intel/emeraldlake2/hda_verb.c @@ -50,7 +50,7 @@ 0x00000004, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/intel/wtm2/hda_verb.c b/src/mainboard/intel/wtm2/hda_verb.c index fc04e0f..8718e5f 100644 --- a/src/mainboard/intel/wtm2/hda_verb.c +++ b/src/mainboard/intel/wtm2/hda_verb.c @@ -50,7 +50,7 @@ 0x00000004, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010), diff --git a/src/mainboard/kontron/ktqm77/hda_verb.c b/src/mainboard/kontron/ktqm77/hda_verb.c index d612f37..9935ca4 100644 --- a/src/mainboard/kontron/ktqm77/hda_verb.c +++ b/src/mainboard/kontron/ktqm77/hda_verb.c @@ -100,7 +100,7 @@ 0x00000004, /* Number of jacks */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x58560010), diff --git a/src/mainboard/samsung/stumpy/hda_verb.c b/src/mainboard/samsung/stumpy/hda_verb.c index 3d39fca..e3677de 100644 --- a/src/mainboard/samsung/stumpy/hda_verb.c +++ b/src/mainboard/samsung/stumpy/hda_verb.c @@ -50,7 +50,7 @@ 0x00000004, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ - AZALIA_SUBVENDOR(0, 0x80860101), + AZALIA_SUBVENDOR(3, 0x80860101),
/* Pin Complex (NID 0x05) Digital Out at Int HDMI */ AZALIA_PIN_CFG(3, 0x05, 0x18560010),
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)