Patrick Georgi submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

mb/**/hda_verb.c: Correct codec ID on subvendor verbs

Looks like the subvendor verb for codec #3 is erroneously using zero as
its codec number. Fix that.

Change-Id: I760533c229287627dd0548a06300c376e045302c
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37850
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
---
M src/mainboard/google/parrot/hda_verb.c
M src/mainboard/intel/baskingridge/hda_verb.c
M src/mainboard/intel/emeraldlake2/hda_verb.c
M src/mainboard/intel/wtm2/hda_verb.c
M src/mainboard/kontron/ktqm77/hda_verb.c
M src/mainboard/samsung/stumpy/hda_verb.c
6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/google/parrot/hda_verb.c b/src/mainboard/google/parrot/hda_verb.c
index 6a015e7..c91cd29 100644
--- a/src/mainboard/google/parrot/hda_verb.c
+++ b/src/mainboard/google/parrot/hda_verb.c
@@ -117,7 +117,7 @@
 	0x00000004,	// Number of jacks
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x18560010),
diff --git a/src/mainboard/intel/baskingridge/hda_verb.c b/src/mainboard/intel/baskingridge/hda_verb.c
index bfa49dc..9a29297 100644
--- a/src/mainboard/intel/baskingridge/hda_verb.c
+++ b/src/mainboard/intel/baskingridge/hda_verb.c
@@ -50,7 +50,7 @@
 	0x00000004,	// Number of jacks
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x18560010),
diff --git a/src/mainboard/intel/emeraldlake2/hda_verb.c b/src/mainboard/intel/emeraldlake2/hda_verb.c
index bfa49dc..9a29297 100644
--- a/src/mainboard/intel/emeraldlake2/hda_verb.c
+++ b/src/mainboard/intel/emeraldlake2/hda_verb.c
@@ -50,7 +50,7 @@
 	0x00000004,	// Number of jacks
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x18560010),
diff --git a/src/mainboard/intel/wtm2/hda_verb.c b/src/mainboard/intel/wtm2/hda_verb.c
index fc04e0f..8718e5f 100644
--- a/src/mainboard/intel/wtm2/hda_verb.c
+++ b/src/mainboard/intel/wtm2/hda_verb.c
@@ -50,7 +50,7 @@
 	0x00000004,	// Number of jacks
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x18560010),
diff --git a/src/mainboard/kontron/ktqm77/hda_verb.c b/src/mainboard/kontron/ktqm77/hda_verb.c
index d612f37..9935ca4 100644
--- a/src/mainboard/kontron/ktqm77/hda_verb.c
+++ b/src/mainboard/kontron/ktqm77/hda_verb.c
@@ -100,7 +100,7 @@
 	0x00000004,	/* Number of jacks */
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x58560010),
diff --git a/src/mainboard/samsung/stumpy/hda_verb.c b/src/mainboard/samsung/stumpy/hda_verb.c
index 3d39fca..e3677de 100644
--- a/src/mainboard/samsung/stumpy/hda_verb.c
+++ b/src/mainboard/samsung/stumpy/hda_verb.c
@@ -50,7 +50,7 @@
 	0x00000004,	// Number of jacks
 
 	/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */
-	AZALIA_SUBVENDOR(0, 0x80860101),
+	AZALIA_SUBVENDOR(3, 0x80860101),
 
 	/* Pin Complex (NID 0x05) Digital Out at Int HDMI */
 	AZALIA_PIN_CFG(3, 0x05, 0x18560010),

To view, visit change 37850. To unsubscribe, or for help writing mail filters, visit settings.