coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3034 discussions

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the wireless
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87105?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the wireless ...................................................................... mb/starlabs/starbook/*: Tidy GPIO comments for the wireless This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I5643fe19f349facffab218e0e8da02d88f192e73 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87105 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/kbl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 9 files changed, 66 insertions(+), 96 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index c71a390..8653f4b 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -39,6 +39,16 @@ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), /* BRI Data */ + PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), /* BRI Response */ + PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), /* RGI Data */ + PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), /* RGI Response */ + PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), /* RF Reset */ + PAD_CFG_NF(GPP_F5, NONE, DEEP, NF2), /* Modem Clock Request */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -64,8 +74,6 @@ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Type C VBUS OverCurrent */ PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15: Test Point 3 */ @@ -241,8 +249,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 7 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -286,18 +292,6 @@ /* E23: Not Connected */ PAD_NC(GPP_E23, NONE), - /* F0: CNV BRI Data */ - PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), - /* F1: CNV BRI Response */ - PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), - /* F2: CNV RGI Data */ - PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), - /* F3: CNV RGI Response */ - PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), - /* F4: CNV RF Reset */ - PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), - /* F5: Not used MODEM_CLKREQ */ - PAD_CFG_NF(GPP_F5, NONE, DEEP, NF2), /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), /* F7: TBT LSX VCCIO Weak Internal PD 20K diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 4e067de..60786b5 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -44,6 +44,12 @@ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ + /* Wireless */ + PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* Clock Request 1 */ + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -69,8 +75,6 @@ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -214,8 +218,6 @@ PAD_NC(GPP_D4, NONE), /* D5: Clock Request 0 */ PAD_NC(GPP_D5, NONE), - /* D7: Clock Request 2 Wireless LAN */ - PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* D8: Clock Request 3 LAN */ PAD_NC(GPP_D8, NONE), /* D9: GSPI 2 FPS */ @@ -245,8 +247,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -341,8 +341,6 @@ /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), - /* H2: Wireless LAN Reset */ - PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H6: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index 18fdbe0..8f2ca82 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -42,6 +42,16 @@ /* SSD */ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* Clock Request 1 */ + /* Wireless */ + PAD_CFG_NF(GPP_F4, UP_20K, DEEP, NF1), /* BRI Data */ + PAD_CFG_NF(GPP_F5, UP_20K, DEEP, NF1), /* BRI Response */ + PAD_CFG_NF(GPP_F6, UP_20K, DEEP, NF1), /* RGI Data */ + PAD_CFG_NF(GPP_F7, UP_20K, DEEP, NF1), /* RGI Response */ + PAD_CFG_NF(GPP_H1, UP_20K, DEEP, NF3), /* RF Reset */ + PAD_CFG_NF(GPP_H2, UP_20K, DEEP, NF3), /* Modem Clock Request */ + PAD_CFG_GPO(GPP_C2, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_B4, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -110,9 +120,7 @@ PAD_NC(GPP_B1, NONE), /* B2: Not Connected */ PAD_NC(GPP_B2, NONE), - /* B4: BT_RF_KILL_N */ - PAD_CFG_GPO(GPP_B4, 1, DEEP), - /* B5: WLAN_CLKREQ# */ + /* B5: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), /* B7: LAN_CLKREQ# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), @@ -153,8 +161,6 @@ PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* C1: SMB_DATA */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), - /* C2: WIFI_RF_KILL_N */ - PAD_CFG_GPO(GPP_C2, 1, DEEP), /* C3: Not Connected */ PAD_NC(GPP_C3, NONE), /* C4: Not Connected */ @@ -292,14 +298,6 @@ PAD_NC(GPP_F2, NONE), /* F3: Not Connected */ PAD_NC(GPP_F3, NONE), - /* F4: CNV_BRI_DT_R */ - PAD_CFG_NF(GPP_F4, UP_20K, DEEP, NF1), - /* F5: CNV_BRI_RSP */ - PAD_CFG_NF(GPP_F5, UP_20K, DEEP, NF1), - /* F6: CNV_RGI_DT_R */ - PAD_CFG_NF(GPP_F6, UP_20K, DEEP, NF1), - /* F7: CNV_RGI_RSP */ - PAD_CFG_NF(GPP_F7, UP_20K, DEEP, NF1), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: Not Connected */ @@ -352,10 +350,6 @@ /* H0: Not Connected */ PAD_NC(GPP_H0, NONE), - /* H1: GPPC_H1_SSP2_SFRM */ - PAD_CFG_NF(GPP_H1, UP_20K, DEEP, NF3), - /* H2: GPPC_H2_SSP2_TXD */ - PAD_CFG_NF(GPP_H2, UP_20K, DEEP, NF3), /* H3: Not Connected */ PAD_NC(GPP_H3, UP_20K), /* H4: GSENSOR_I2C_SDA */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index 957ca9a..47864e8 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -33,6 +33,10 @@ /* SSD */ PAD_CFG_NF(GPP_B10, DN_20K, DEEP, NF1), /* Clock Request 5 */ + /* Wireless */ + // PAD_CFG_GPO(GPP_D20, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_TERM_GPO(GPP_B4, 1, UP_20K, DEEP), /* Bluetooth RF Kill */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), /* GPD6: Not Connected */ @@ -101,8 +105,6 @@ PAD_NC(GPP_B2, DN_20K), /* GPP_B3: Not Connected */ PAD_NC(GPP_B3, DN_20K), - /* GPP_B4: BT_OFF_N_MCP */ - PAD_CFG_TERM_GPO(GPP_B4, 1, UP_20K, DEEP), /* GPP_B5: SRCCLKREQ0# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), /* GPP_B6: CLKREQ1# */ @@ -217,8 +219,6 @@ PAD_NC(GPP_D18, DN_20K), /* GPP_D19: Not Connected */ PAD_NC(GPP_D19, DN_20K), - /* GPP_D20: WIFI_OFF_N_MCP */ - PAD_CFG_TERM_GPO(GPP_D20, 1, UP_20K, DEEP), /* GPP_D21: Not Connected */ PAD_NC(GPP_D21, DN_20K), /* GPP_D22: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 3b15bb8..89670dd 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -49,6 +49,12 @@ PAD_CFG_GPO(GPP_H00, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_H07, 1, PLTRST), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_D21, NONE, DEEP, NF2), /* Clock Request 5 */ + PAD_CFG_GPO(GPP_H02, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_B19, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_B18, 1, DEEP), /* Bluetooth RF Kill */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -250,8 +256,6 @@ * LOW: DISABLED * WEAK INTERNAL PD 20K */ PAD_CFG_GPO(GPP_H01, 0, DEEP), - /* H02: WLAN_RST_N */ - PAD_CFG_GPO(GPP_H02, 1, PLTRST), /* H03: */ PAD_NC(GPP_H03, NONE), /* H04: */ @@ -416,10 +420,6 @@ PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2), /* B17: */ PAD_NC(GPP_B17, NONE), - /* B18: BT_RF_KILL_N */ - PAD_CFG_GPO(GPP_B18, 1, DEEP), - /* B19: WIFI_RF_KILL_N */ - PAD_CFG_GPO(GPP_B19, 1, DEEP), /* B20: */ PAD_NC(GPP_B20, NONE), /* B21: */ @@ -474,9 +474,6 @@ PAD_NC(GPP_D18, NONE), /* D19: */ PAD_NC(GPP_D19, NONE), - /* D21: CLKREQ5 - * WLAN */ - PAD_CFG_NF(GPP_D21, NONE, DEEP, NF2), /* D22: */ PAD_NC(GPP_D22, NONE), /* D23: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 309da16..6e90173 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -44,6 +44,12 @@ PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D14, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* Clock Request 2 */ + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -70,8 +76,6 @@ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_NC(GPP_A12, NONE), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -217,8 +221,6 @@ PAD_NC(GPP_D5, NONE), /* D6: Clock Request 1 PCH M.2 SSD */ PAD_NC(GPP_D6, NONE), - /* D7: Clock Request 2 Wireless LAN */ - PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* D8: Clock Request 3 LAN */ PAD_NC(GPP_D8, NONE), /* D9: GSPI 2 FPS */ @@ -248,8 +250,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Retimer Force Power */ PAD_CFG_GPO(GPP_E4, 0, DEEP), /* E5: Not Connected */ @@ -344,8 +344,6 @@ PAD_NC(GPP_H0, NONE), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), - /* H2: Wireless LAN Reset */ - PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H6: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index ca081ff..8998541 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -35,6 +35,13 @@ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), /* BRI Data */ + PAD_CFG_NF(GPP_F1, NONE, DEEP, NF1), /* BRI Response */ + PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), /* RGI Data */ + PAD_CFG_NF(GPP_F3, NONE, DEEP, NF1), /* RGI Response */ + PAD_NC(GPP_F6, NONE), /* Modem Clock Request */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -256,20 +263,10 @@ /* E23: Not Connected */ PAD_NC(GPP_E23, NONE), - /* F0: CNV_BRI_DT_BT_UART0_RTS_R */ - PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), - /* F1: CNV_BRI_RSP_BT_UART0_RX_R */ - PAD_CFG_NF(GPP_F1, NONE, DEEP, NF1), - /* F2: CNV_RGI_DT_BT_UART0_TX_R */ - PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), - /* F3: CNV_RGI_RSP_BT_UART0_CTS */ - PAD_CFG_NF(GPP_F3, NONE, DEEP, NF1), /* F4: Not Connected */ PAD_NC(GPP_F4, NONE), /* F5: GPPC_F5_MODEM_CLKREQ */ PAD_NC(GPP_F5, NONE), - /* F6: Not Connected */ - PAD_NC(GPP_F6, NONE), /* F7: BIOS_REC */ PAD_CFG_GPO(GPP_F7, 1, PLTRST), /* F8: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 080f95d..0bf4412 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -54,6 +54,12 @@ PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D14, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* Clock Request 1 */ + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -79,8 +85,6 @@ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -220,8 +224,6 @@ PAD_NC(GPP_D4, NONE), /* D5: Clock Request 0 */ PAD_NC(GPP_D5, NONE), - /* D7: Clock Request 2 Wireless LAN */ - PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* D8: Clock Request 3 LAN */ PAD_NC(GPP_D8, NONE), /* D9: PWD_AMP_IN */ @@ -249,8 +251,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Retimer Force Power */ PAD_CFG_GPO(GPP_E4, 0, DEEP), /* E5: Not Connected */ @@ -339,8 +339,6 @@ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), - /* H2: Wireless LAN Reset */ - PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H6: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 6a0db68..63bda1d 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -39,6 +39,16 @@ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* Wireless */ + PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), /* BRI Data */ + PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), /* BRI Response */ + PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), /* RGI Data */ + PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), /* RGI Response */ + PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), /* RF Reset */ + PAD_CFG_NF(GPP_F5, NONE, DEEP, NF2), /* Modem Clock Request */ + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -64,8 +74,6 @@ PAD_NC(GPP_A11, NONE), /* A12: Not Connected */ PAD_NC(GPP_A12, NONE), - /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Camera Power Enable */ PAD_NC(GPP_A14, NONE), /* A15: Camera Reset */ @@ -239,8 +247,6 @@ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: P Offset */ PAD_NC(GPP_E4, NONE), /* E5: P Out */ @@ -284,18 +290,6 @@ /* E23: Not Connected */ PAD_NC(GPP_E23, NONE), - /* F0: CNV BRI Data */ - PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), - /* F1: CNV BRI Response */ - PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), - /* F2: CNV RGI Data */ - PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), - /* F3: CNV RGI Response */ - PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), - /* F4: CNV RF Reset */ - PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), - /* F5: Not used MODEM_CLKREQ */ - PAD_CFG_NF(GPP_F5, NONE, DEEP, NF2), /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), /* F7: TBT LSX VCCIO Weak Internal PD 20K -- To view, visit https://review.coreboot.org/c/coreboot/+/87105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5643fe19f349facffab218e0e8da02d88f192e73 Gerrit-Change-Number: 87105 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the wireless
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87105?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the wireless ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5643fe19f349facffab218e0e8da02d88f192e73 Gerrit-Change-Number: 87105 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 19:26:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87103?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD ...................................................................... mb/starlabs/starbook/*: Tidy GPIO comments for the SSD This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ifd24ca28d66e5e987129a44b6682efab9b64049b Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87103 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/kbl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 9 files changed, 41 insertions(+), 47 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index dbbd7da..c71a390 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -34,6 +34,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* SSD */ + PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* Clock Request 0 */ + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -203,8 +208,6 @@ PAD_NC(GPP_D3, NONE), /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D5: Clock Request 0 PCH M.2 SSD */ - PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* D6: Clock Request 1 Wireless LAN */ PAD_NC(GPP_D6, NONE), /* D7: Clock Request 2 LAN 1 */ @@ -225,8 +228,6 @@ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not Connected */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -336,8 +337,6 @@ /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 38aefd0e..4e067de 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -39,6 +39,11 @@ PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* Clock Request 1 */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -209,8 +214,6 @@ PAD_NC(GPP_D4, NONE), /* D5: Clock Request 0 */ PAD_NC(GPP_D5, NONE), - /* D6: Clock Request 1 PCH M.2 SSD */ - PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D7: Clock Request 2 Wireless LAN */ PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* D8: Clock Request 3 LAN */ @@ -229,8 +232,6 @@ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -338,8 +339,6 @@ /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index 7958b40..18fdbe0 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -39,6 +39,9 @@ PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* Clock Request 1 */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -111,8 +114,6 @@ PAD_CFG_GPO(GPP_B4, 1, DEEP), /* B5: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), - /* B6: CLKREQ1_SSD_N */ - PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* B7: LAN_CLKREQ# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* B8: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index d9a075b..957ca9a 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -30,6 +30,9 @@ PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_C23, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_B10, DN_20K, DEEP, NF1), /* Clock Request 5 */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), /* GPD6: Not Connected */ @@ -110,8 +113,6 @@ PAD_CFG_NF(GPP_B8, DN_20K, DEEP, NF1), /* GPP_B9: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), - /* GPP_B10: CLKREQ5# */ - PAD_CFG_NF(GPP_B10, DN_20K, DEEP, NF1), /* GPP_B11: Not Connected */ PAD_NC(GPP_B11, DN_20K), /* GPP_B12 SLP_S0_N */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 468b4a7..3b15bb8 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -44,6 +44,11 @@ PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC(GPP_B00, NONE, DEEP, LEVEL, INVERT), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1), /* Clock Request 8 */ + PAD_CFG_GPO(GPP_H00, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_H07, 1, PLTRST), /* Enable */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -240,8 +245,6 @@ * Start: GPP_H00 * End: GPP_H23 */ - /* H00: M.2_PCH_SSD_RESET_N */ - PAD_CFG_GPO(GPP_H00, 1, PLTRST), /* H01: FLASH RECOVERY * HIGH: ENABLED * LOW: DISABLED @@ -257,8 +260,6 @@ PAD_NC(GPP_H05, NONE), /* H06: */ PAD_NC(GPP_H06, NONE), - /* H07: M.2_CPU_SSD_PWREN */ - PAD_CFG_GPO(GPP_H07, 1, DEEP), /* H10: */ PAD_NC(GPP_H10, NONE), /* H11: */ @@ -473,9 +474,6 @@ PAD_NC(GPP_D18, NONE), /* D19: */ PAD_NC(GPP_D19, NONE), - /* D20: CLKREQ8 - * SSD */ - PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1), /* D21: CLKREQ5 * WLAN */ PAD_CFG_NF(GPP_D21, NONE, DEEP, NF2), diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 96e9797..309da16 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -39,6 +39,11 @@ PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), /* Clock Request 4 */ + PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D14, 1, DEEP), /* Enable */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -226,8 +231,6 @@ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), - /* D14: CPU M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D14, 1, DEEP), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ @@ -330,8 +333,6 @@ PAD_NC(GPP_F18, NONE), /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), - /* F20: CPU M.2 SSD Reset */ - PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ @@ -369,8 +370,6 @@ PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), - /* H19: Clock Request 4 CPU M.2 SSD */ - PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), /* H20: Not Connected */ PAD_NC(GPP_H20, NONE), /* H21: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index f8e178d..ca081ff 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -30,6 +30,11 @@ PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_NC(GPP_D8, NONE), /* Clock Request 3 */ + PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -52,8 +57,6 @@ PAD_CFG_NF(GPP_A9, NONE, DEEP, NF2), /* A10: WLAN_PCM_IN */ PAD_NC(GPP_A10, NONE), - /* A11: M2_CPU_SSD_RST_N */ - PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* A12: SATAGP_1 */ PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* A13: Not Connected */ @@ -183,8 +186,6 @@ PAD_NC(GPP_D6, NONE), /* D7: LAN_CLKREQ# */ PAD_NC(GPP_D7, NONE), - /* D8: Not Connected */ - PAD_NC(GPP_D8, NONE), /* D9: Not Connected */ PAD_NC(GPP_D9, NONE), /* D10: Not Connected */ @@ -199,8 +200,6 @@ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: CPU_SSD_PWREN */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not Connected */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 5cb167a..080f95d 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -49,6 +49,11 @@ PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ PAD_CFG_GPI_APIC_LOW(GPP_D11, NONE, PLTRST), /* Interrupt */ + /* SSD */ + PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* Clock Request 5 */ + PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D14, 1, DEEP), /* Enable */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -215,8 +220,6 @@ PAD_NC(GPP_D4, NONE), /* D5: Clock Request 0 */ PAD_NC(GPP_D5, NONE), - /* D6: Clock Request 1 PCH M.2 SSD */ - PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D7: Clock Request 2 Wireless LAN */ PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), /* D8: Clock Request 3 LAN */ @@ -229,8 +232,6 @@ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), - /* D14: CPU M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D14, 1, DEEP), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ @@ -327,8 +328,6 @@ PAD_NC(GPP_F18, NONE), /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), - /* F20: CPU M.2 SSD Reset */ - PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 64e7b83..6a0db68 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -34,6 +34,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* SSD */ + PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* Clock Request 0 */ + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* Reset */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -201,8 +206,6 @@ PAD_NC(GPP_D3, NONE), /* D4: Camera Image Clock Output */ PAD_NC(GPP_D4, NONE), - /* D5: Clock Request 0 PCH M.2 SSD */ - PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* D6: Clock Request 1 Wireless LAN */ PAD_NC(GPP_D6, NONE), /* D7: Clock Request 2 */ @@ -223,8 +226,6 @@ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Bluetooth Wake */ @@ -334,8 +335,6 @@ /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd24ca28d66e5e987129a44b6682efab9b64049b Gerrit-Change-Number: 87103 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD
by Matt DeVillier (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87103?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd24ca28d66e5e987129a44b6682efab9b64049b Gerrit-Change-Number: 87103 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 03 Apr 2025 19:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87103?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the SSD ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd24ca28d66e5e987129a44b6682efab9b64049b Gerrit-Change-Number: 87103 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 19:01:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the touchpad
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87102?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the touchpad ...................................................................... mb/starlabs/starbook/*: Tidy GPIO comments for the touchpad This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I9563f1d3f464b3be35d18d6cd6fbbcee314fce28 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87102 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/kbl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c 7 files changed, 35 insertions(+), 42 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 0e6816d..38aefd0e 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -34,6 +34,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* Touchpad */ + PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -259,8 +264,6 @@ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), - /* E12: Touchpad Interrupt */ - PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E14: EDP HPD */ @@ -343,10 +346,6 @@ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H4: I2C 0 SDA Touchpad */ - PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), - /* H5: I2C 0 SDL Touchpad */ - PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), /* H7: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index da73483..7958b40 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -34,6 +34,11 @@ PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* Touchpad */ + PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -102,8 +107,6 @@ PAD_NC(GPP_B1, NONE), /* B2: Not Connected */ PAD_NC(GPP_B2, NONE), - /* B3: CLICK_PAD_INT_R_N */ - PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST), /* B4: BT_RF_KILL_N */ PAD_CFG_GPO(GPP_B4, 1, DEEP), /* B5: WLAN_CLKREQ# */ @@ -177,10 +180,6 @@ PAD_NC(GPP_C14, NONE), /* C15: TBT_RST_N */ PAD_NC(GPP_C15, NONE), - /* C16: I2C0_SDA */ - PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), - /* C17: I2C0_SCL */ - PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* C18: TOUCH_I2C_SDA */ PAD_NC(GPP_C18, NONE), /* C19: TOUCH_I2C_SDL */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index 6cffc5f..d9a075b 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -25,6 +25,11 @@ PAD_CFG_NF(GPD5, NONE, PWROK, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, PWROK, NF1), /* Bluetooth Suspend */ + /* Touchpad */ + PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_C23, NONE, PLTRST), /* Interrupt */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), /* GPD6: Not Connected */ @@ -165,18 +170,12 @@ PAD_NC(GPP_C14, UP_20K), /* GPP_C15: Not Connected */ PAD_NC(GPP_C15, UP_20K), - /* GPP_C16: DAT_I2C_TP */ - PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), - /* GPP_C17: CLK_I2C_TP */ - PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* GPP_C18: TOUCH_I2C_SDA */ PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* GPP_C19: TOUCH_I2C_CLK */ PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* GPP_C22: Not Connected */ PAD_NC(GPP_C22, NONE), - /* GPP_C23: TOUCHPAD_INT */ - PAD_CFG_GPI_APIC_LOW(GPP_C23, NONE, PLTRST), /* GPP_D0: Not Connected */ PAD_NC(GPP_D0, DN_20K), /* GPP_D1: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index c5e3c26..468b4a7 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -39,6 +39,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A05, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A06, NONE, DEEP, NF1), /* eSPI Reset */ + /* Touchpad */ + PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC(GPP_B00, NONE, DEEP, LEVEL, INVERT), /* Interrupt */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -272,10 +277,6 @@ PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: */ PAD_NC(GPP_H18, NONE), - /* H19: TCHPAD_I2C0_SDA_N */ - PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), - /* H20: TCHPAD_I2C0_SCL_N */ - PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1), /* H21: */ PAD_NC(GPP_H21, NONE), /* H22: */ @@ -373,8 +374,6 @@ * Start: GPP_B00 * End: GPP_B23 */ - /* B00: TCHPAD_INT_N */ - PAD_CFG_GPI_APIC(GPP_B00, NONE, DEEP, LEVEL, INVERT), /* B01: */ PAD_NC(GPP_B01, NONE), /* B02: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 817230a..96e9797 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -34,6 +34,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* Touchpad */ + PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -260,8 +265,6 @@ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), - /* E12: Touchpad Interrupt */ - PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), /* E14: EDP HPD */ @@ -344,10 +347,6 @@ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H4: I2C 0 SDA Touchpad */ - PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), - /* H5: I2C 0 SDL Touchpad */ - PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), /* H7: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 3c19970..f8e178d 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -25,6 +25,11 @@ PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* Touchpad */ + PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -139,8 +144,6 @@ PAD_CFG_NF(GPP_C6, NONE, PWROK, NF1), /* C7: SML1_DATA */ PAD_CFG_NF(GPP_C7, NONE, PWROK, NF1), - /* C8: CLICK_PAD_INT_N */ - PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST), /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), /* C10: Not Connected */ @@ -155,10 +158,6 @@ PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), /* C15: TPM_RST */ PAD_NC(GPP_C15, NONE), - /* C16: I2C0_SDA */ - PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), - /* C17: I2C0_SCL */ - PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1), /* C18: TOUCH_I2C_SDA */ PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* C19: TOUCH_I2C_CLK */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 4f46467..5cb167a 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -44,6 +44,11 @@ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* Touchpad */ + PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), /* Data */ + PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_GPI_APIC_LOW(GPP_D11, NONE, PLTRST), /* Interrupt */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -220,8 +225,6 @@ PAD_NC(GPP_D9, NONE), /* D10: TPM_IRQ */ PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), - /* D11: TCHPAD_INT_N */ - PAD_CFG_GPI_APIC_LOW(GPP_D11, NONE, PLTRST), /* D12: ES8336_INT_N */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ @@ -341,10 +344,6 @@ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H4: I2C 0 SDA Touchpad */ - PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), - /* H5: I2C 0 SDL Touchpad */ - PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), /* H7: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9563f1d3f464b3be35d18d6cd6fbbcee314fce28 Gerrit-Change-Number: 87102 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for the touchpad
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87102?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for the touchpad ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9563f1d3f464b3be35d18d6cd6fbbcee314fce28 Gerrit-Change-Number: 87102 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 19:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for eSPI
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87101?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for eSPI ...................................................................... mb/starlabs/starbook/*: Tidy GPIO comments for eSPI This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Id6a30adbc434c975cda1cdcffd164650910e1da3 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87101 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 7 files changed, 54 insertions(+), 55 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 3814deb..dbbd7da 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Webcam Camera Reset */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 619b315..0e6816d 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index c3b4c6d..c5e3c26 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -30,6 +30,15 @@ PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPP_V08, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A00, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A01, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A02, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A03, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A04, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A05, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A06, NONE, DEEP, NF1), /* eSPI Reset */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -129,20 +138,6 @@ * Start: GPP_A00 * End: GPP_A23 */ - /* A00: ESPI_IO0_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A00, UP_20K, DEEP, NF1), - /* A01: ESPI_IO1_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A01, UP_20K, DEEP, NF1), - /* A02: ESPI_IO2_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A02, UP_20K, DEEP, NF1), - /* A03: ESPI_IO3_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A03, UP_20K, DEEP, NF1), - /* A04: ESPI_CS0_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A04, UP_20K, DEEP, NF1), - /* A05: ESPI_CLK_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A05, UP_20K, DEEP, NF1), - /* A06: ESPI_RESET_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A06, NONE, DEEP, NF1), /* A07: */ PAD_NC(GPP_A07, NONE), /* A08: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 1aeb866..817230a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -39,11 +48,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -52,8 +56,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 08e2563..3c19970 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -38,12 +38,6 @@ /* GPD11: PM_LANPHY_EN */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1), - /* A0: ESPI_IO_0 */ - /* A1: ESPI_IO_1 */ - /* A2: ESPI_IO_2 */ - /* A3: ESPI_IO_3 */ - /* A4: ESPI_CS_L */ - /* A5: ESPI_CLK */ /* A6: Not Connected(TP764) */ /* A7: WLAN_PCM_CLK */ PAD_NC(GPP_A7, NONE), diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 3ffa198..4f46467 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -35,6 +35,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -48,11 +57,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -61,8 +65,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 4e96453..64e7b83 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Webcam Camera Reset */ PAD_NC(GPP_A11, NONE), /* A12: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6a30adbc434c975cda1cdcffd164650910e1da3 Gerrit-Change-Number: 87101 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/starbook/*: Tidy GPIO comments for deep GPIOs
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87100?usp=email ) Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for deep GPIOs ...................................................................... mb/starlabs/starbook/*: Tidy GPIO comments for deep GPIOs This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ic5c541a44ac9b34dad5430c994b1fa28e96d67f4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87100 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/kbl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 9 files changed, 71 insertions(+), 115 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index d3fa51b..3814deb 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -17,24 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_NC(GPD4, NONE), /* Sleep S3 */ + PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_NC(GPD4, NONE), - /* GPD5: Sleep S4 */ - PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), /* GPD10: Sleep S5 */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 493ec7b..619b315 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -17,24 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_NC(GPD4, NONE), /* Sleep S3 */ + PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_NC(GPD4, NONE), - /* GPD5: Sleep S4 */ - PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), /* GPD10: Sleep S5 */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index acdeeb4..da73483 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -26,26 +26,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* REFERENCE: EP PER SCHEMATIC */ + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ - /* GPD0: PCH_BATLOW# */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: AC_PRESENT */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), - /* GPD3: SIO_PWRBTN# */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: SIO_SLP_S3# */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), - /* GPD5: SIO_SLP_S4# */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* GPD6: SIO_SLP_A# */ PAD_CFG_NF(GPD6, NONE, DEEP, NF1), /* GPD7: PCH_TBT_PERST# */ PAD_CFG_GPO(GPD7, 0, PLTRST), - /* GPD8: SUSCLK */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: SIO_SLP_WLAN# */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: SIO_SLP_S5# */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index 71fc2dc..6cffc5f 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -17,24 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: PM_BATLOW_N */ - PAD_CFG_NF(GPD0, UP_20K, PWROK, NF1), - /* GPD1: AC_PRESENT */ - PAD_CFG_NF(GPD1, NATIVE, PWROK, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, UP_20K, PWROK, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NATIVE, PWROK, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, PWROK, NF1), /* Power Button */ + PAD_CFG_NF(GPD4, NONE, PWROK, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, PWROK, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, PWROK, NF1), /* Bluetooth Suspend */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), - /* GPD3: SOC_PWRBTN_N */ - PAD_CFG_NF(GPD3, UP_20K, PWROK, NF1), - /* GPD4: SLP_S3_N */ - PAD_CFG_NF(GPD4, NONE, PWROK, NF1), - /* GPD5: SLP_S4_N */ - PAD_CFG_NF(GPD5, NONE, PWROK, NF1), /* GPD6: Not Connected */ PAD_NC(GPD6, NONE), /* GPD7: Not Connected */ PAD_NC(GPD7, NONE), - /* GPD8: SUS_CLK */ - PAD_CFG_NF(GPD8, NONE, PWROK, NF1), /* GPD9: Not Connected */ PAD_NC(GPD9, NONE), /* GPD10: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index e7f66ff..c3b4c6d 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -22,29 +22,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* - * GPP_V - * Start: GPP_V00 - * End: GPP_V22 - */ - /* V00: PM_BATLOW_N */ - PAD_CFG_NF(GPP_V00, NONE, DEEP, NF1), - /* V01: CHG_ACOK */ - PAD_CFG_NF(GPP_V01, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPP_V00, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPP_V01, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPP_V03, UP_20K, DEEP, NF1), /* Power Button */ + PAD_CFG_NF(GPP_V04, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPP_V08, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), - /* V03: EC_PWRBTN_N */ - PAD_CFG_NF(GPP_V03, UP_20K, DEEP, NF1), - /* V04: PM_SLP_S3_N */ - PAD_CFG_NF(GPP_V04, NONE, DEEP, NF1), - /* V05: SLP S4# */ - PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1), /* V06: GPD_6_SLP_A_N */ PAD_NC(GPP_V06, NONE), /* V07: */ PAD_NC(GPP_V07, NONE), - /* V08: M.2_BTWIFI_SUS_CLK */ - PAD_CFG_NF(GPP_V08, NONE, DEEP, NF1), /* V09: GPD_9_SLP_WLAN_N */ PAD_NC(GPP_V09, NONE), /* V10: PM_SLP_S5_N */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index bae3564..1aeb866 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -17,26 +17,23 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_NC(GPD4, NONE), /* Sleep S3 */ + PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_NC(GPD4, NONE), - /* GPD5: Sleep S4 */ - PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), + /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 2a0a538..08e2563 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -17,26 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* REFERENCE: EP PER SCHEMATIC */ + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ - /* GPD0: PCH_BATLOW# */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: AC_PRESENT */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), - /* GPD3: SIO_PWRBTN# */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: SIO_SLP_S3# */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), - /* GPD5: SIO_SLP_S4# */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* GPD6: SIO_SLP_A# */ PAD_CFG_NF(GPD6, NONE, DEEP, NF1), /* GPD7: PCH_TBT_PERST# */ PAD_CFG_GPO(GPD7, 0, PLTRST), - /* GPD8: SUSCLK */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: SIO_SLP_WLAN# */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: SIO_SLP_S5# */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 6890c27..3ffa198 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -27,24 +27,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_NC(GPD4, NONE), /* Sleep S3 */ + PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_NC(GPD4, NONE), - /* GPD5: Sleep S4 */ - PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 8dea7a5..4e96453 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -17,24 +17,20 @@ /* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_NC(GPD4, NONE), /* Sleep S3 */ + PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_NC(GPD4, NONE), - /* GPD5: Sleep S4 */ - PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), /* GPD10: Sleep S5 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c541a44ac9b34dad5430c994b1fa28e96d67f4 Gerrit-Change-Number: 87100 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Remove old incorrect comment
by Sean Rhodes (Code Review) 03 Apr '25

03 Apr '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87099?usp=email ) Change subject: mb/starlabs/*: Remove old incorrect comment ...................................................................... mb/starlabs/*: Remove old incorrect comment Change-Id: Ia3919bd2c41272bca03b464d31ed227c7579cb20 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87099 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/kbl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c 3 files changed, 0 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index 3ef1506..acdeeb4 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -2,11 +2,6 @@ #include <variants.h> -/* - * All definitions are taken from a comparison of the output of "inteltool -a" - * using the stock BIOS and with coreboot. - */ - /* Early pad configuration in bootblock */ const struct pad_config early_gpio_table[] = { /* Debug Connector */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index ae01749..71fc2dc 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -2,11 +2,6 @@ #include <variants.h> -/* - * All definitions are taken from a comparison of the output of "inteltool -a" - * using the stock BIOS and with coreboot. - */ - /* Early pad configuration in bootblock. */ const struct pad_config early_gpio_table[] = { /* Debug Connector */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 7e30109..2a0a538 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -2,11 +2,6 @@ #include <variants.h> -/* - * All definitions are taken from a comparison of the output of "inteltool -a" - * using the stock BIOS and with coreboot. - */ - /* Early pad configuration in bootblock */ const struct pad_config early_gpio_table[] = { /* Debug Connector */ -- To view, visit https://review.coreboot.org/c/coreboot/+/87099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3919bd2c41272bca03b464d31ed227c7579cb20 Gerrit-Change-Number: 87099 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025