coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[L] Change in coreboot[main]: Documentation: Add information about the site-local directory
by Nicholas Chin (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87185?usp=email ) Change subject: Documentation: Add information about the site-local directory ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Gerrit-Change-Number: 87185 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Apr 2025 22:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: Documentation: Add information about the site-local directory
by Nicholas Chin (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87185?usp=email ) Change subject: Documentation: Add information about the site-local directory ...................................................................... Patch Set 2: (1 comment) File Documentation/getting_started/index.md: https://review.coreboot.org/c/coreboot/+/87185/comment/e744f9b8_b340d802?us… : PS2, Line 13: CBMEM <cbmem.md> > Wrong patch? Oh, was looking at the wrong diff. -- To view, visit https://review.coreboot.org/c/coreboot/+/87185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Gerrit-Change-Number: 87185 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Apr 2025 22:02:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: Documentation: Reformat fw_config.md
by Nicholas Chin (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87190?usp=email ) Change subject: Documentation: Reformat fw_config.md ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I83925a4469e264da5887334e2584466cef089503 Gerrit-Change-Number: 87190 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Apr 2025 21:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: Documentation: Add information about the site-local directory
by Nicholas Chin (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87185?usp=email ) Change subject: Documentation: Add information about the site-local directory ...................................................................... Patch Set 2: (1 comment) File Documentation/getting_started/index.md: https://review.coreboot.org/c/coreboot/+/87185/comment/87edce7a_b99ff989?us… : PS2, Line 13: CBMEM <cbmem.md> Wrong patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/87185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Gerrit-Change-Number: 87185 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Apr 2025 21:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: Documentation: Add information about the site-local directory
by Martin L Roth (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Nicholas Chin. Hello Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87185?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Nicholas Chin, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Documentation: Add information about the site-local directory ...................................................................... Documentation: Add information about the site-local directory This adds a document about coreboot's site-local directory along with how and when to use it. Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Documentation/getting_started/index.md A Documentation/getting_started/site-local.md 2 files changed, 463 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/87185/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Gerrit-Change-Number: 87185 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: Documentation: Add information about the site-local directory
by Martin L Roth (Code Review) 06 Apr '25

06 Apr '25

Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87185?usp=email ) Change subject: Documentation: Add information about the site-local directory ...................................................................... Patch Set 1: (1 comment) File Documentation/getting_started/site-local.md: PS1: > Looking at the content in `managing_local_additions. […] I completely agree with what they have. It might be good to go back and rework our documentation at some point. Right now I'm focusing mostly on the `reference` area, which is something that we're sorely lacking. I've got some more that I plan to push in the upcoming week or so: - Chip operations - Device Operations - Resource Allocator - coreboot tables - cbmem_util And some I plan to do but haven't started yet: - coreboot toolchain - Make build targets Let me know if you have any other thoughts or think we need specific documentation. -- To view, visit https://review.coreboot.org/c/coreboot/+/87185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida176aa460be7673bad219f958f741dd68a8aa62 Gerrit-Change-Number: 87185 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Apr 2025 21:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: Documentation: Reformat fw_config.md
by Martin L Roth (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Nicholas Chin. Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87190?usp=email ) Change subject: Documentation: Reformat fw_config.md ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: Feel free to just make any changes to these commits as you see fit as well. File Documentation/lib/fw_config.md: https://review.coreboot.org/c/coreboot/+/87190/comment/4fe09069_55524ef6?us… : PS3, Line 154: field <name> <start-bit> <end-bit> [option...] end > I'd unindent all these by one level. […] Done https://review.coreboot.org/c/coreboot/+/87190/comment/ecf80438_f2f800e2?us… : PS3, Line 226: field <name> [option...] end > Enclose in text block for consistency with the rest of the file Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I83925a4469e264da5887334e2584466cef089503 Gerrit-Change-Number: 87190 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Apr 2025 21:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: Documentation: Reformat fw_config.md
by Martin L Roth (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87190?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation: Reformat fw_config.md ...................................................................... Documentation: Reformat fw_config.md This doesn't change any text - it just reformats the existing document. - reflow paragraphs to 72 characters - Put examples inside pre-formatted text blocks - Adds spacing before section markers Change-Id: I83925a4469e264da5887334e2584466cef089503 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Documentation/lib/fw_config.md 1 file changed, 288 insertions(+), 200 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/87190/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/87190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I83925a4469e264da5887334e2584466cef089503 Gerrit-Change-Number: 87190 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asus/p8x7x-series: Add p8b75-v variant
by Keith Hui (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Angel Pons, Felix Held. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85792?usp=email ) Change subject: mb/asus/p8x7x-series: Add p8b75-v variant ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85792/comment/44385805_52a10e80?us… : PS3, Line 21: to use both to build a 16MiB flash space but that's to be confirmed. > Of note: Asrock B85M Pro4 has 5 MB ME firmware and a 8 MiB flash chip Sounds plausible. coreboot+edk2 only takes about 1.2MB. 😊 With 16MiB and ME cleaned we should be trying to squeeze a Linux kernel in there. -- To view, visit https://review.coreboot.org/c/coreboot/+/85792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibb14c9efd1fb5b8826a646aae5f3fab9d9c08187 Gerrit-Change-Number: 85792 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Apr 2025 21:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>

1 0

[L] Change in coreboot[main]: Documentation: Add Threads
by Martin L Roth (Code Review) 06 Apr '25

06 Apr '25

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87188?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation: Add Threads ...................................................................... Documentation: Add Threads Change-Id: I49a273118f19e4b332ac7f51b1f34247acf66b85 Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Documentation/lib/index.md A Documentation/lib/threads.md 2 files changed, 311 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/87188/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/87188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49a273118f19e4b332ac7f51b1f34247acf66b85 Gerrit-Change-Number: 87188 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025