coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: [HACK] cpu/x86/smm: Use PML4E in SMM
by Shuo Liu (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Jérémy Compostella, Patrick Rudolph. Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87177?usp=email ) Change subject: [HACK] cpu/x86/smm: Use PML4E in SMM ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Will there be further changes to remove the [HACK] tag? -- To view, visit https://review.coreboot.org/c/coreboot/+/87177?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia493dc813f50df273d13053f1c9a0ae5335638d6 Gerrit-Change-Number: 87177 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 06:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: cpu/x86/mp_init: Add code to restart APs
by Shuo Liu (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Filip Lewiński, Jérémy Compostella, Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel. Shuo Liu has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82696?usp=email ) Change subject: cpu/x86/mp_init: Add code to restart APs ...................................................................... Patch Set 12: Code-Review+1 (1 comment) File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/82696/comment/4fa7180e_390600a3?us… : PS7, Line 1215: printk(BIOS_DEBUG, "%d/%d eventually checked in?\n", > @coreboot.org@gmail. […] Not sure if we can remove the mdelay in both here and mp_init (maybe in a separate patch) since in start_aps, there is already waits for AP to checkin. -- To view, visit https://review.coreboot.org/c/coreboot/+/82696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief2a7629d3075de29b363d05330e3a76cef48971 Gerrit-Change-Number: 82696 Gerrit-PatchSet: 12 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <miczyg94(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <miczyg94(a)gmail.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 06:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Filip Lewiński <filip.lewinski(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/variants/fatcat: Refactor X1 PCIe power enable GPIO
by Pranava Y N (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Jayvik Desai, Kapil Porwal, Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87154?usp=email ) Change subject: mb/google/fatcat/variants/fatcat: Refactor X1 PCIe power enable GPIO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f2a2540de30294c30c4f5182dab326a54b4583e Gerrit-Change-Number: 87154 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 05:55:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: arch/x86/postcar_loader: Add comment line for reloc_params assignment
by Shuo Liu (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Jérémy Compostella, NyeonWoo Kim, Paul Menzel. Shuo Liu has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/86866?usp=email ) Change subject: arch/x86/postcar_loader: Add comment line for reloc_params assignment ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86866/comment/6c37f6e8_ff6d5fae?us… : PS7, Line 10: to be loaded as reloc_params, e.g. with its cache flushed. > Done Seems that still has format issue. From logic point of view, LGTM. But please check with Paul for regulating the formats. -- To view, visit https://review.coreboot.org/c/coreboot/+/86866?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7d3f9cf514ce5a8efc2af9e78992cb39a91e537 Gerrit-Change-Number: 86866 Gerrit-PatchSet: 8 Gerrit-Owner: NyeonWoo Kim Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: NyeonWoo Kim Gerrit-Comment-Date: Mon, 07 Apr 2025 05:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: NyeonWoo Kim

1 0

[XS] Change in coreboot[main]: src/arch/x86/c_start: Delete duplicated code masking stack pointer
by Shuo Liu (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Jérémy Compostella, NyeonWoo Kim. Shuo Liu has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/87181?usp=email ) Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87181/comment/dc9c316d_63515737?us… : PS1, Line 32: ... Are you meaning ln77/94? -- To view, visit https://review.coreboot.org/c/coreboot/+/87181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Gerrit-Change-Number: 87181 Gerrit-PatchSet: 1 Gerrit-Owner: NyeonWoo Kim Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: NyeonWoo Kim Gerrit-Comment-Date: Mon, 07 Apr 2025 05:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: cpu/x86: Conditionally invalidate caches based on self-snooping support
by Shuo Liu (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Jérémy Compostella, Subrata Banik. Shuo Liu has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87182?usp=email ) Change subject: cpu/x86: Conditionally invalidate caches based on self-snooping support ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/87182/comment/3482655e_f617629f?us… : PS2, Line 35: Does arch_segment_loaded in cpu/x86/cache/cache.c needs to be handled as well? File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/87182/comment/8ab71815_d4bfc8e0?us… : PS2, Line 831: if (!self_snooping_supported()) { Do we need to check clflush_supported to do clflush over wbinvd? -- To view, visit https://review.coreboot.org/c/coreboot/+/87182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If32439752d0ceaa03b1d81873ea0bc562092e9d5 Gerrit-Change-Number: 87182 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 05:45:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
by Pranava Y N (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Mac Chiang, Paul Menzel, Varun Upadhyay, Weimin Wu. Pranava Y N has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/fatcat/variants/felino/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85572/comment/217f1f84_1775f9bb?us… : PS6, Line 297: MIPI_DEV_ID_REALTEK_ALC712 This part ID is not defined. Please fix this. -- To view, visit https://review.coreboot.org/c/coreboot/+/85572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Gerrit-Change-Number: 85572 Gerrit-PatchSet: 6 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 05:31:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add WFC for AZWAVE/AM-3BA5533-B module
by Eric Lai (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Daniel Peng, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro. Eric Lai has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87054?usp=email ) Change subject: mb/google/nissa/var/guren: Add WFC for AZWAVE/AM-3BA5533-B module ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2ab019fe76c503cc669ebf4aa8b3d7ae72269c1 Gerrit-Change-Number: 87054 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 05:24:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/brya: Create epic variant
by Dinesh Gehlot (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Yunlong Jia. Dinesh Gehlot has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/87041?usp=email ) Change subject: mb/google/brya: Create epic variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87041?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09e5f3c28b95ae8ef318b7af1dd8634279345ce0 Gerrit-Change-Number: 87041 Gerrit-PatchSet: 2 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 03:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/meliks: Replace SPD for RAMID 2 with Samsung K3KL...
by Dinesh Gehlot (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Nick Vaccaro, Paul Menzel, SH Kim. Dinesh Gehlot has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/87002?usp=email ) Change subject: mb/google/nissa/var/meliks: Replace SPD for RAMID 2 with Samsung K3KL8L80CM-MGCT ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87002?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7c05b79ca018f68260e71d4f749ecb8573987358 Gerrit-Change-Number: 87002 Gerrit-PatchSet: 2 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: NyeonWoo Kim Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 03:23:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025