coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[XS] Change in coreboot[main]: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87049?usp=email ) Change subject: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil ...................................................................... mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil The SoC code requires for GPE DW config values to be different. Assign the default values of PMC GPIO_CONF register as GPIO GPEs are not used on this platform. Fixes the assertion in soc/intel/elkhartalke/pmutil. TEST=Boot Protectli VP2420 to Ubuntu 24.04. Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87049 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/protectli/vault_ehl/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Felix Held: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/protectli/vault_ehl/devicetree.cb b/src/mainboard/protectli/vault_ehl/devicetree.cb index 10782b2..0db005f 100644 --- a/src/mainboard/protectli/vault_ehl/devicetree.cb +++ b/src/mainboard/protectli/vault_ehl/devicetree.cb @@ -18,9 +18,9 @@ # route, i.e., if this route changes then the affected GPE # offset bits also need to be changed. This sets the PMC register # GPE_CFG fields. - #register "pmc_gpe0_dw1" = "PMC_GPE_SCC_63_32" - #register "pmc_gpe0_dw2" = "PMC_GPE_N_31_0" - #register "pmc_gpe0_dw3" = "PMC_GPE_SCC_31_0" + register "pmc_gpe0_dw0" = "PMC_GPP_A" + register "pmc_gpe0_dw1" = "PMC_GPP_R" + register "pmc_gpe0_dw2" = "PMC_GPD" register "tcc_offset" = "5" # TCC of 95C -- To view, visit https://review.coreboot.org/c/coreboot/+/87049?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Gerrit-Change-Number: 87049 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Add missing minimum D-state for SMBUS
by Sean Rhodes (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jérémy Compostella, Kapil Porwal, Subrata Banik, Tarun. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86605?usp=email ) Change subject: soc/intel/meteorlake: Add missing minimum D-state for SMBUS ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > I just noticed it was missing whilst trying to fix the below which happens after S3: […] Shall I abandon? We don't use s0ix so don't mind! -- To view, visit https://review.coreboot.org/c/coreboot/+/86605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73f84c09bece297194813202f17666741ad33d3a Gerrit-Change-Number: 86605 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Always configure PsysPmax
by Sean Rhodes (Code Review) 07 Apr '25

07 Apr '25

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86738?usp=email ) Change subject: soc/intel/meteorlake: Always configure PsysPmax ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e402b72690b5a676d7dd7c9cb372eba8a1e3f8a Gerrit-Change-Number: 86738 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/kbl: Re-add the GPE configuration
by Sean Rhodes (Code Review) 07 Apr '25

07 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87200?usp=email ) Change subject: mb/starlabs/starbook/kbl: Re-add the GPE configuration ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1256b57192d2f8987bb476cbcc7fd7e81f314d6d Gerrit-Change-Number: 87200 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:37:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starfighter: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 07 Apr '25

07 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87164?usp=email ) Change subject: mb/starlabs/starfighter: Disconnect unused GPIOs ...................................................................... Patch Set 1: (1 comment) File src/mainboard/starlabs/starfighter/variants/rpl/gpio.c: https://review.coreboot.org/c/coreboot/+/87164/comment/2fc5dad8_08ac8796?us… : PS1, Line 199: GPP_C3 Mind triple-checking? Hard to trace, tests fine though -- To view, visit https://review.coreboot.org/c/coreboot/+/87164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e58a0e7545167db2c4034499bb99d3bfffc2277 Gerrit-Change-Number: 87164 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:34:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mainboard/protectli/vault_ehl/Kconfig: Configure TPM PIRQ
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Michał Żygowski, Piotr Król. Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/87051?usp=email ) Change subject: mainboard/protectli/vault_ehl/Kconfig: Configure TPM PIRQ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87051?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia23319680cff927f10b44d7a5d07928cc30dbc9d Gerrit-Change-Number: 87051 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:31:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Michał Żygowski, Piotr Król. Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/87049?usp=email ) Change subject: mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87049?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9 Gerrit-Change-Number: 87049 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:31:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/cml: Re-add the GPE configuration
by Sean Rhodes (Code Review) 07 Apr '25

07 Apr '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87199?usp=email ) Change subject: mb/starlabs/starbook/cml: Re-add the GPE configuration ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/87199?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3af197cd995bd947c6e72bf5593fc966c85c3e3a Gerrit-Change-Number: 87199 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:18:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by Alicja Michalska (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu, Vasiliy Khoruzhick, yuchi.chen(a)intel.com. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email ) Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ...................................................................... Patch Set 11: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86131/comment/32e46098_76be02d1?us… : PS9, Line 26: TigerLake-H > Tiger Lake-H Done https://review.coreboot.org/c/coreboot/+/86131/comment/d880e4e5_56fef81d?us… : PS9, Line 28: > Should you respin the patch, I’d love to see also the Linux messages pasted before and after the cha […] I don't have access to test hardware right now, but it essentially boils down to: `[drm] Using a reduced BAR size of 256MiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.` After applying the patch, BAR gets resized to 8192MB File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/86131/comment/9ac843ee_bc49a446?us… : PS9, Line 1019: Required for modern graphics cards, such as Intel Arc. > Maybe give some more background for a user building coreboot. Not sure what else to add, any suggestions? https://review.coreboot.org/c/coreboot/+/86131/comment/031d3081_722d476f?us… : PS9, Line 1021: GRUB doesn't > Interesting. […] I meant using GRUB as a payload of course, GRUB used as bootloader (loaded from MBR or BOOTX64.EFI) doesn't cause issues since framebuffer is already initialized by the payload (i.e EDK2) -- To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Gerrit-Change-Number: 86131 Gerrit-PatchSet: 11 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: superio/fintek: Add support for f81966d
by Erik van den Bogaert (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Frans Hendriks, Harrie Paijmans. Erik van den Bogaert has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email ) Change subject: superio/fintek: Add support for f81966d ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7 Gerrit-Change-Number: 87198 Gerrit-PatchSet: 1 Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:11:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025