coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[XL] Change in coreboot[main]: Documentation/internals: Add devicetree language documentation
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Martin L Roth. Felix Held has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84710?usp=email ) Change subject: Documentation/internals: Add devicetree language documentation ...................................................................... Patch Set 5: (2 comments) File Documentation/internals/devicetree_language.md: https://review.coreboot.org/c/coreboot/+/84710/comment/152203fe_a404cc21?us… : PS5, Line 447: /eSPI eSPI doesn't support legacy DMA any more. ISA had it, and it was optional, but usually implemented in LPC. CB:87204 https://review.coreboot.org/c/coreboot/+/84710/comment/0ff30bd8_8ade6cf6?us… : PS5, Line 974: Currently, only a single segment is supported not true; we support more than one pci segment group. CB:87206 -- To view, visit https://review.coreboot.org/c/coreboot/+/84710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If868ad9a87cb2903bf144996fe3b87d29d4fc755 Gerrit-Change-Number: 84710 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 21:24:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: doc/internals/devicetree_language: multiple segment groups supported
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87206?usp=email ) Change subject: doc/internals/devicetree_language: multiple segment groups supported ...................................................................... doc/internals/devicetree_language: multiple segment groups supported coreboot supports more than just one PCI segment group by having more than one domain in the devicetree, so update the PCI device description. Change-Id: I9911b5e43732dd32638d540fcec6ca57b34d4fbc Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Documentation/internals/devicetree_language.md 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/87206/1 diff --git a/Documentation/internals/devicetree_language.md b/Documentation/internals/devicetree_language.md index ab1b646..43a2233 100644 --- a/Documentation/internals/devicetree_language.md +++ b/Documentation/internals/devicetree_language.md @@ -973,11 +973,11 @@ Resources for all PCI devices are assigned automatically, or must be assigned in code if they're non-standard. -Currently, only a single segment is supported, but there is work to make -multiple different segments supported, each with a bus 0. Because the -bus is not specified, It's assumed that all pci devices that are not -behind a pci bridge device are on bus 0. If there are additional pci -busses in a chip, they can be added behind their bridge device. +Only a single segment group is supported per domain, but there can be multiple +domains to support the case of multiple segment groups, each with a bus 0. +Because the bus is not specified, It's assumed that all pci devices that are +not behind a pci bridge device are on bus 0. If there are additional pci busses +in a chip, they can be added behind their bridge device. Examples: -- To view, visit https://review.coreboot.org/c/coreboot/+/87206?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9911b5e43732dd32638d540fcec6ca57b34d4fbc Gerrit-Change-Number: 87206 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: doc/internals/devicetree_language: describe I2C identifier
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87205?usp=email ) Change subject: doc/internals/devicetree_language: describe I2C identifier ...................................................................... doc/internals/devicetree_language: describe I2C identifier Even when the identifier of an I2C device doesn't have a '0x' prefix, it's still interpreted as a hexadecimal number. Change-Id: I0e5a7e39ac56e25499493a16eefa49e4f8d79337 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Documentation/internals/devicetree_language.md 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/87205/1 diff --git a/Documentation/internals/devicetree_language.md b/Documentation/internals/devicetree_language.md index d189844..ab1b646 100644 --- a/Documentation/internals/devicetree_language.md +++ b/Documentation/internals/devicetree_language.md @@ -690,6 +690,8 @@ * Introduced in: Initial sconfig implementation, pre coreboot 4.0 * Usage: `device I2c <identifier> [alias <alias ID>] <status modifier> ... end` +The identifier is the device's address encoded as hexadecimal number. + Example: ```text -- To view, visit https://review.coreboot.org/c/coreboot/+/87205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e5a7e39ac56e25499493a16eefa49e4f8d79337 Gerrit-Change-Number: 87205 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: doc/internals/devicetree_language: eSPI doesn't support legacy DRQ
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87204?usp=email ) Change subject: doc/internals/devicetree_language: eSPI doesn't support legacy DRQ ...................................................................... doc/internals/devicetree_language: eSPI doesn't support legacy DRQ In contracts to the ISA and LPC bus, eSPI doesn't support legacy ISA-style DMA any more, so don't list eSPI as interface in the 'drq' chapter. The Intel document #841685 "Enhanced Serial Peripheral Interface (eSPI) Interface Base Specification (for Client and Server Platforms)" revision 1.6 says this about the eSPI interface: "However, 8237 DMA and Firmware Hub (FWH) are not supported over this interface." Change-Id: I69d4b09688699dfc984a42671abfe3804d30ade9 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Documentation/internals/devicetree_language.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/87204/1 diff --git a/Documentation/internals/devicetree_language.md b/Documentation/internals/devicetree_language.md index 0609559..d189844 100644 --- a/Documentation/internals/devicetree_language.md +++ b/Documentation/internals/devicetree_language.md @@ -444,7 +444,7 @@ * Usage: `drq 0x<register #> = <drq line>` Drq is used to configure a legacy DMA Request line register for a device -on a legacy bus - ISA/LPC/eSPI. +on a legacy bus - ISA/LPC. The drq configuration is only allowed inside a pnp block. -- To view, visit https://review.coreboot.org/c/coreboot/+/87204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69d4b09688699dfc984a42671abfe3804d30ade9 Gerrit-Change-Number: 87204 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in coreboot[main]: doc/contributing/git_commit_messages: fix line length
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87203?usp=email ) Change subject: doc/contributing/git_commit_messages: fix line length ...................................................................... doc/contributing/git_commit_messages: fix line length The line length limit in the commit messages is 72 characters, not 75, so fix the value in the documentation. The 72 characters also matches what checkpatch checks for. Change-Id: I2ec0fbd78fd0b054eae7bf9d6bd30580f47deb8f Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Documentation/contributing/git_commit_messages.md 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/87203/1 diff --git a/Documentation/contributing/git_commit_messages.md b/Documentation/contributing/git_commit_messages.md index 4addf4c..a007b2a 100644 --- a/Documentation/contributing/git_commit_messages.md +++ b/Documentation/contributing/git_commit_messages.md @@ -13,14 +13,14 @@ ## Line length - The subject line should be <= 65 characters, with an absolute maximum - of 75 characters -- Prose in the commit message should be <= 75 characters -- If reflowing prose to 75 characters can reduce the length of the + of 72 characters +- Prose in the commit message should be <= 72 characters +- If reflowing prose to 72 characters can reduce the length of the commit message by 2 or more lines, please reflow it. Using the entire - 75 characters on a line when reasonable is recommended, but not + 72 characters on a line when reasonable is recommended, but not required. - Non-prose text in the body in the commit message does not need to be - wrapped at 75 characters. Examples: URLs, compiler output, or poetry. + wrapped at 72 characters. Examples: URLs, compiler output, or poetry. ## Both Subject & body -- To view, visit https://review.coreboot.org/c/coreboot/+/87203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ec0fbd78fd0b054eae7bf9d6bd30580f47deb8f Gerrit-Change-Number: 87203 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: mb/google/brya: Create epic variant
by Jayvik Desai (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Yunlong Jia. Jayvik Desai has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/87041?usp=email ) Change subject: mb/google/brya: Create epic variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87041?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09e5f3c28b95ae8ef318b7af1dd8634279345ce0 Gerrit-Change-Number: 87041 Gerrit-PatchSet: 2 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:31:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add WFC for AZWAVE/AM-3BA5533-B module
by Jayvik Desai (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Daniel Peng, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro. Jayvik Desai has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87054?usp=email ) Change subject: mb/google/nissa/var/guren: Add WFC for AZWAVE/AM-3BA5533-B module ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2ab019fe76c503cc669ebf4aa8b3d7ae72269c1 Gerrit-Change-Number: 87054 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incompatible pointer-to-integer conversion
by Jayvik Desai (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87091?usp=email ) Change subject: soc/intel/alderlake: Fix incompatible pointer-to-integer conversion ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1f8f19c6bb4636729ffe7be836c21db9a68d63d0 Gerrit-Change-Number: 87091 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:21:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Fix incompatible pointer-to-integer conversion
by Jérémy Compostella (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik. Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87091?usp=email ) Change subject: soc/intel/alderlake: Fix incompatible pointer-to-integer conversion ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1f8f19c6bb4636729ffe7be836c21db9a68d63d0 Gerrit-Change-Number: 87091 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:10:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/amd/common/cpu/noncar: Compute core info
by Felix Held (Code Review) 07 Apr '25

07 Apr '25

Attention is currently required from: Angel Pons, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki. Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/common/cpu/noncar: Compute core info ...................................................................... Patch Set 13: Code-Review+2 (2 comments) File src/soc/amd/common/block/cpu/noncar/cpu.c: https://review.coreboot.org/c/coreboot/+/85640/comment/b50e8810_b6fd6032?us… : PS12, Line 108: 16 > SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF Done https://review.coreboot.org/c/coreboot/+/85640/comment/47af373f_646f4da0?us… : PS12, Line 109: 24 > SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 13 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:09:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025