coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[XS] Change in coreboot[main]: soc/intel/cmn/cpu: Refactor USE_INTEL_FSP_MP_INIT enablement logic
by Subrata Banik (Code Review) 09 Apr '25

09 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87161?usp=email ) Change subject: soc/intel/cmn/cpu: Refactor USE_INTEL_FSP_MP_INIT enablement logic ...................................................................... soc/intel/cmn/cpu: Refactor USE_INTEL_FSP_MP_INIT enablement logic The Kconfig options `USE_INTEL_FSP_MP_INIT` and `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` are mutually exclusive ways for the FSP to handle MP initialization. This commit updates the `default` condition for `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` to `y if !USE_INTEL_FSP_MP_INIT`. This ensures that if `USE_INTEL_FSP_MP_INIT` is enabled, `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` will default to disabled, preventing potential conflicts in MP initialization. The explicit `depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` on `USE_INTEL_FSP_MP_INIT` is no longer strictly necessary due to this change in the default value, but it is kept for clarity and to explicitly state the mutual exclusivity. TEST=Able to choose USE_INTEL_FSP_MP_INIT Kconfig for google/fatcat. Change-Id: I9ecc7b50ed6a6b13c4ccde0a49f50a40b606a848 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87161 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/common/block/cpu/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Wonkyu Kim: Looks good to me, but someone else must approve build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Jérémy Compostella: Looks good to me, approved diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig index 0184452..e51110e 100644 --- a/src/soc/intel/common/block/cpu/Kconfig +++ b/src/soc/intel/common/block/cpu/Kconfig @@ -124,13 +124,12 @@ config USE_INTEL_FSP_MP_INIT bool "Perform MP Initialization by FSP" default n - depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI help This option allows FSP to perform multiprocessor initialization. config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI bool "Perform MP Initialization by FSP using coreboot MP PPI service" - default y + default y if !USE_INTEL_FSP_MP_INIT depends on MP_SERVICES_PPI help This option allows FSP to make use of MP services PPI published by -- To view, visit https://review.coreboot.org/c/coreboot/+/87161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ecc7b50ed6a6b13c4ccde0a49f50a40b606a848 Gerrit-Change-Number: 87161 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yidi Lin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email ) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... Patch Set 5: (1 comment) File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86352/comment/713799ec_1ca686b9?us… : PS5, Line 122: $(PI_IMG_OUT) The CONFIG_PI_IMG_FIRMWARE will be added twice. But eventually CBFS only keeps one copy ? -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 01:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: util/mtkheader: Rename to util/mediatek
by Yidi Lin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87225?usp=email ) Change subject: util/mtkheader: Rename to util/mediatek ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibc6ef9dddc541d2dd471898af431cadde231edca Gerrit-Change-Number: 87225 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 01:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Documentation,util: Run util_readme.sh to regen *.md
by Yidi Lin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87224?usp=email ) Change subject: Documentation,util: Run util_readme.sh to regen *.md ...................................................................... Patch Set 1: (1 comment) File Documentation/util.md: https://review.coreboot.org/c/coreboot/+/87224/comment/2c7f5297_2c2c12ee?us… : PS1, Line 73: c Why does `convert` become lower case ? -- To view, visit https://review.coreboot.org/c/coreboot/+/87224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d3f87517c445d650e9cea61448b28d005d46737 Gerrit-Change-Number: 87224 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 01:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Move TX TRACKING from MT8196 to common folder
by Vince Liu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87036?usp=email ) Change subject: soc/mediatek/mt8196: Move TX TRACKING from MT8196 to common folder ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87036/comment/49e260b1_0d465ea2?us… : PS2, Line 13: directory. > Can it move to above line ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3fdd9d2f7ab1bbdcc097510556929da2134f7d95 Gerrit-Change-Number: 87036 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 00:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Move TX TRACKING from MT8196 to common folder
by Vince Liu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87036?usp=email to look at the new patch set (#3). Change subject: soc/mediatek/mt8196: Move TX TRACKING from MT8196 to common folder ...................................................................... soc/mediatek/mt8196: Move TX TRACKING from MT8196 to common folder The configuration method of the reserved DRAM buffer used for HW TX TRACING on MT8196 is also applicable to other SoCs, such as MT8189. To facilitate reuse, we move the relevant files to the common directory. BUG=b:379008996 BRANCH=none TEST=Reserve memory ok Firmware shows the following log with 12GB DDR board: 00000001ffff0000-00000001ffffffff: RESERVED 000000037fff0000-000000037fffffff: RESERVED Change-Id: I3fdd9d2f7ab1bbdcc097510556929da2134f7d95 Signed-off-by: Mike Lin <mike.lin(a)mediatek.corp-partner.google.com> --- R src/soc/mediatek/common/dramc_info.c A src/soc/mediatek/common/include/soc/dramc_info.h M src/soc/mediatek/mt8196/Makefile.mk D src/soc/mediatek/mt8196/include/soc/dramc_info.h 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/87036/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3fdd9d2f7ab1bbdcc097510556929da2134f7d95 Gerrit-Change-Number: 87036 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yidi Lin. Hello Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86352?usp=email to look at the new patch set (#5). Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... soc/mediatek/mt8196: Add validity check for PI_IMG Call check-pi-img.py to perform validity check for the PI_IMG firmware file. BUG=none TEST=emerge-rauru coreboot BRANCH=rauru Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86352/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 5 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email ) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... Patch Set 4: (1 comment) File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86352/comment/557733be_088d5ce4?us… : PS1, Line 119: xxd > `xxd: not found` Changed to a Python script. -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 00:10:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: util/docker/coreboot-sdk: Add xxd
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Yu-Ping Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86366?usp=email ) Change subject: util/docker/coreboot-sdk: Add xxd ...................................................................... Abandoned Changed to use Python script in CB:86352 -- To view, visit https://review.coreboot.org/c/coreboot/+/86366?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc95d25504cdccae5967ecf9276b7c1f904a14a2 Gerrit-Change-Number: 86366 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: util/mediatek: Add check-pi-img.py
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87226?usp=email ) Change subject: util/mediatek: Add check-pi-img.py ...................................................................... util/mediatek: Add check-pi-img.py Add a script to perform validity check of the PI_IMG firmware. Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M Documentation/util.md M util/README.md A util/mediatek/check-pi-img.py M util/mediatek/description.md 4 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/87226/1 diff --git a/Documentation/util.md b/Documentation/util.md index 8a52557..6ac904a 100644 --- a/Documentation/util.md +++ b/Documentation/util.md @@ -88,6 +88,7 @@ * __[me_cleaner](https://github.com/corna/me_cleaner)__ - Tool for partial deblobbing of Intel ME/TXE firmware images `Python` * __mediatek__ + * check-pi-img.py - Check `PI_IMG` firmware. `Python3` * gen-bl-img.py - Generate MediaTek bootloader header. `Python3` * __mma__ - Memory Margin Analysis automation tests `Bash` diff --git a/util/README.md b/util/README.md index 0253a71..099845d 100644 --- a/util/README.md +++ b/util/README.md @@ -79,6 +79,7 @@ * __[me_cleaner](https://github.com/corna/me_cleaner)__ - Tool for partial deblobbing of Intel ME/TXE firmware images `Python` * __mediatek__ + * check-pi-img.py - Check `PI_IMG` firmware. `Python3` * gen-bl-img.py - Generate MediaTek bootloader header. `Python3` * __mma__ - Memory Margin Analysis automation tests `Bash` diff --git a/util/mediatek/check-pi-img.py b/util/mediatek/check-pi-img.py new file mode 100755 index 0000000..1587dbe --- /dev/null +++ b/util/mediatek/check-pi-img.py @@ -0,0 +1,35 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: GPL-2.0-only + +import argparse + + +HEADER_OFFSET = 0x200 +COOKIE = 0x17C3A6B4 + + +def check_pi_img(pi_img): + cookie_count = 0 + with open(pi_img, "rb") as f: + f.seek(HEADER_OFFSET) + while True: + data = f.read(4) + if not data: + break + value = int.from_bytes(data, byteorder="little", signed=False) + if value == COOKIE: + cookie_count += 1 + if cookie_count != 2: + raise ValueError("Invalid PI_IMG {}, {} cookies found" + .format(pi_img, cookie_count)) + + +def main(): + parser = argparse.ArgumentParser() + parser.add_argument("pi_img") + args = parser.parse_args() + check_pi_img(args.pi_img) + +if __name__ == '__main__': + main() diff --git a/util/mediatek/description.md b/util/mediatek/description.md index 67ff390..568c8bb 100644 --- a/util/mediatek/description.md +++ b/util/mediatek/description.md @@ -1,2 +1,3 @@ __mediatek__ + * check-pi-img.py - Check `PI_IMG` firmware. `Python3` * gen-bl-img.py - Generate MediaTek bootloader header. `Python3` -- To view, visit https://review.coreboot.org/c/coreboot/+/87226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d Gerrit-Change-Number: 87226 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025