coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
by Subrata Banik (Code Review) 09 Apr '25

09 Apr '25

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87236?usp=email ) Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE ...................................................................... mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE This patch refactors the eSOL enablement from SoC level to mainboard and provide chances for mainboard to decidxe not to pick eSOL if not supported. Enable the FSP_UGOP_EARLY_SIGN_OF_LIFE Kconfig option for the Fatcat and Felino boards. The option was previously selected at the SOC level for Pantherlake, but is now being enabled specifically for these mainboards. BUG=b:400550435 TEST=Build the Fatcat and Felino targets. Verify that the eSOL works fine. Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig M src/soc/intel/pantherlake/Kconfig 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/87236/1 diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 2679b14..08a5eba 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -62,6 +62,7 @@ select DRIVERS_GENERIC_BAYHUB_LV2 select DRIVERS_GENERIC_MAX98357A select DRIVERS_INTEL_TOUCH + select FSP_UGOP_EARLY_SIGN_OF_LIFE config BOARD_GOOGLE_FATCAT select BOARD_GOOGLE_MODEL_FATCAT @@ -81,6 +82,7 @@ config BOARD_GOOGLE_FELINO select BOARD_GOOGLE_BASEBOARD_FATCAT + select FSP_UGOP_EARLY_SIGN_OF_LIFE select HAVE_SLP_S0_GATE select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig index a884631..36417db 100644 --- a/src/soc/intel/pantherlake/Kconfig +++ b/src/soc/intel/pantherlake/Kconfig @@ -17,7 +17,6 @@ select FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW select FSP_COMPRESS_FSP_S_LZ4 select FSP_M_XIP - select FSP_UGOP_EARLY_SIGN_OF_LIFE select FSP_USES_CB_DEBUG_EVENT_HANDLER select FSPS_HAS_ARCH_UPD select GENERIC_GPIO_LIB -- To view, visit https://review.coreboot.org/c/coreboot/+/87236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Gerrit-Change-Number: 87236 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: [POC] Docs/lib/timestamp.md: Use Breathe to generate API documentation
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Nicholas Chin. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87231?usp=email to look at the new patch set (#2). Change subject: [POC] Docs/lib/timestamp.md: Use Breathe to generate API documentation ...................................................................... [POC] Docs/lib/timestamp.md: Use Breathe to generate API documentation API documentation written on doc.coreboot.org is likely to go out of date when the code is changed, whereas docstrings directly in the code are more likely to be updated. As a proof of concept, use Breathe to pull the Doxygen function documentation for `include/timestamp.h` into our markdown documentation. To view and build this, do one of the following: 1. Install the following python3 modules: - sphinx - myst-parser - sphinx_rtd_theme - breathe 2. Install Doxygen 3. Run `make` from the `Documentation` folder. The output will be in `Documentation/_build/html` Change-Id: Iae85a33f11fe9dbe11943e63a4f1dfc95ccc0bf9 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/lib/timestamp.md 1 file changed, 6 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/87231/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae85a33f11fe9dbe11943e63a4f1dfc95ccc0bf9 Gerrit-Change-Number: 87231 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in coreboot[main]: [RFC][POC] Docs: Integrate Breathe extension
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/87230?usp=email ) Change subject: [RFC][POC] Docs: Integrate Breathe extension ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Seems like the Doxyfile can use environment variables for the values of config options, so that migh […] There is also the issue of Doxygen being ran from the main project Makefile (I put it there so that the input paths in the Doxyfile would be defined relative to the root of the coreboot tree), which causes the top level `build` directory to be created (as well as some other subfiles/subdirectories). This is an issue in the container as the coreboot tree is mounted read only. -- To view, visit https://review.coreboot.org/c/coreboot/+/87230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9cdf93896184848e3ea450b774160ca30f1935c Gerrit-Change-Number: 87230 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:06:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: [RFC][POC] util/docker/doc.coreboot.org: Add Breathe and Doxygen
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/87229?usp=email ) Change subject: [RFC][POC] util/docker/doc.coreboot.org: Add Breathe and Doxygen ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I had also looked into Sphinx C Autodoc and Hawkmoth which are alternative Sphinx extensions to pull in docstrings from code. They don't rely on Doxygen which might make some things easier, but instead use clang which seems to require passing all the correct build options which might be a bit difficult to extract properly without defining them all manually. https://sphinx-c-autodoc.readthedocs.io/en/latest/ https://hawkmoth.readthedocs.io/en/stable/index.html -- To view, visit https://review.coreboot.org/c/coreboot/+/87229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I59cfe67ca476b370e6ea40323b7971b4f05ceb3d Gerrit-Change-Number: 87229 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 03:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: [RFC][POC] Docs: Integrate Breathe extension
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/87230?usp=email ) Change subject: [RFC][POC] Docs: Integrate Breathe extension ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This currently doesn't work in the doc.coreboot. […] Seems like the Doxyfile can use environment variables for the values of config options, so that might be a way to make this work. -- To view, visit https://review.coreboot.org/c/coreboot/+/87230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9cdf93896184848e3ea450b774160ca30f1935c Gerrit-Change-Number: 87230 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Apr 2025 03:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/guren: Add Stylus Pen Function
by Daniel Peng (Code Review) 09 Apr '25

09 Apr '25

Daniel Peng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87235?usp=email ) Change subject: mb/google/brya/var/guren: Add Stylus Pen Function ...................................................................... mb/google/brya/var/guren: Add Stylus Pen Function New Stylus Pen for MAXEYE/0585501490 module for Guren360 project. 1. Add STYLUS fw_config setting 2. Enable stylus device settings 3. Disable the stylus GPIO pins based on fw_config BUG=b:406168542 BRANCH=firmware-nissa-15217.B TEST=1. emerge-nissa coreboot 2. Confirm command evtest for stylus PRP0001:00 and workable. Change-Id: I46d679d29b35d0f4fc70d63b74975d3bdfc40b7b Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/brya/variants/guren/fw_config.c M src/mainboard/google/brya/variants/guren/gpio.c M src/mainboard/google/brya/variants/guren/overridetree.cb 3 files changed, 32 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/87235/1 diff --git a/src/mainboard/google/brya/variants/guren/fw_config.c b/src/mainboard/google/brya/variants/guren/fw_config.c index efebee2..63e55a3 100644 --- a/src/mainboard/google/brya/variants/guren/fw_config.c +++ b/src/mainboard/google/brya/variants/guren/fw_config.c @@ -27,6 +27,13 @@ PAD_NC(GPP_H23, NONE), }; +static const struct pad_config stylus_disable_pads[] = { + /* F13 : SOC_PEN_DETECT_R_ODL */ + PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), + /* F15 : SOC_PEN_DETECT_ODL */ + PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), +}; + void fw_config_gpio_padbased_override(struct pad_config *padbased_table) { if (!fw_config_probe(FW_CONFIG(DB_USB, DB_HDMI_LTE)) @@ -44,4 +51,10 @@ gpio_padbased_override(padbased_table, lte_disable_pads, ARRAY_SIZE(lte_disable_pads)); } + + if (fw_config_probe(FW_CONFIG(STYLUS, STYLUS_ABSENT))) { + printk(BIOS_INFO, "Disable Stylus GPIO pins.\n"); + gpio_padbased_override(padbased_table, stylus_disable_pads, + ARRAY_SIZE(stylus_disable_pads)); + } } diff --git a/src/mainboard/google/brya/variants/guren/gpio.c b/src/mainboard/google/brya/variants/guren/gpio.c index 0c46265..b5017c6 100644 --- a/src/mainboard/google/brya/variants/guren/gpio.c +++ b/src/mainboard/google/brya/variants/guren/gpio.c @@ -26,10 +26,6 @@ PAD_CFG_GPI(GPP_E5, NONE, DEEP), /* F12 : WWAN_RST_L */ PAD_CFG_GPO_LOCK(GPP_F12, 1, LOCK_CONFIG), - /* F13 : GSXSLOAD ==> NC */ - PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), - /* F15 : GSXSRESET# ==> NC */ - PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), /* H19 : SOC_I2C_SUB_INT_ODL */ PAD_CFG_GPI_APIC(GPP_H19, NONE, PLTRST, LEVEL, NONE), /* H22 : IMGCLKOUT3 ==> NC */ diff --git a/src/mainboard/google/brya/variants/guren/overridetree.cb b/src/mainboard/google/brya/variants/guren/overridetree.cb index 0e10689..fffb46c 100644 --- a/src/mainboard/google/brya/variants/guren/overridetree.cb +++ b/src/mainboard/google/brya/variants/guren/overridetree.cb @@ -21,6 +21,10 @@ option WIFI_SAR_ID_INTEL_CONVERTIBLE 0 option WIFI_SAR_ID_INTEL_CLAMSHELL 1 end + field STYLUS 15 + option STYLUS_ABSENT 0 + option STYLUS_PRESENT 1 + end field WFC 17 18 option WFC_ABSENT 0 option WFC_PRESENT 1 @@ -369,6 +373,21 @@ probe TOUCHSCREEN_SOURCE TOUCHSCREEN_ILIT2901 end end + + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_F13)" + register "key.wake_gpe" = "GPE0_DW2_15" + register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on + probe STYLUS STYLUS_PRESENT + end + end end #I2C1 device ref i2c2 on chip drivers/i2c/sx9324 -- To view, visit https://review.coreboot.org/c/coreboot/+/87235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46d679d29b35d0f4fc70d63b74975d3bdfc40b7b Gerrit-Change-Number: 87235 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add touch screen ILIT2901 support
by Subrata Banik (Code Review) 09 Apr '25

09 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87196?usp=email ) Change subject: mb/google/nissa/var/guren: Add touch screen ILIT2901 support ...................................................................... mb/google/nissa/var/guren: Add touch screen ILIT2901 support New Touchscreen function for Guren360 project. Touchscreen panel of MUTTO A153728S1Y(11') /K&D KD116N37-30TE-A002(11')/MUTTO B153797S1Y(12') are the same IC controller for ILITEK device, and set TOUCHSCREEN_ILIT2901 to value "2". BUG=b:406168542 BRANCH=firmware-nissa-15217.B TEST=1. emerge-nissa coreboot chromeos-bootimage 2. Confirm command evtest and touchscreen function is workable. Change-Id: I3435a8852b1fdb897d5f89c580b5f9bfca03dd8e Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87196 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/google/brya/variants/guren/overridetree.cb 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Daniel Peng: Looks good to me, but someone else must approve build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/guren/overridetree.cb b/src/mainboard/google/brya/variants/guren/overridetree.cb index 8b1adb1..0e10689 100644 --- a/src/mainboard/google/brya/variants/guren/overridetree.cb +++ b/src/mainboard/google/brya/variants/guren/overridetree.cb @@ -28,6 +28,7 @@ field TOUCHSCREEN_SOURCE 32 34 option TOUCHSCREEN_UNPROVISIONED 0 option TOUCHSCREEN_ELAN0001 1 + option TOUCHSCREEN_ILIT2901 2 end end @@ -349,6 +350,25 @@ end end + chip drivers/i2c/hid + register "generic.hid" = ""ILIT2901"" + register "generic.desc" = ""ILI Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" + register "generic.detect" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" + register "generic.reset_delay_ms" = "10" + register "generic.reset_off_delay_ms" = "4" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" + register "generic.enable_delay_ms" = "12" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" + register "generic.stop_delay_ms" = "105" + register "generic.stop_off_delay_ms" = "5" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 41 on + probe TOUCHSCREEN_SOURCE TOUCHSCREEN_ILIT2901 + end + end end #I2C1 device ref i2c2 on chip drivers/i2c/sx9324 -- To view, visit https://review.coreboot.org/c/coreboot/+/87196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3435a8852b1fdb897d5f89c580b5f9bfca03dd8e Gerrit-Change-Number: 87196 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add touch screen ILIT2901 support
by Daniel Peng (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Nick Vaccaro, Subrata Banik. Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87196?usp=email ) Change subject: mb/google/nissa/var/guren: Add touch screen ILIT2901 support ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: If no concern, please kindly help to submit the CL. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/87196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3435a8852b1fdb897d5f89c580b5f9bfca03dd8e Gerrit-Change-Number: 87196 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Apr 2025 03:38:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: util/mtkheader: Rename to util/mediatek
by Yidi Lin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87225?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/mtkheader: Rename to util/mediatek ...................................................................... Patch Set 1: (1 comment) File util/README.md: https://review.coreboot.org/c/coreboot/+/87225/comment/1dc47e4a_e8f7bdd0?us… : PS1, Line 83: `Python3` should move to the end of the above line ? -- To view, visit https://review.coreboot.org/c/coreboot/+/87225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibc6ef9dddc541d2dd471898af431cadde231edca Gerrit-Change-Number: 87225 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 03:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: [RFC][POC] Docs: Integrate Breathe extension
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/87230?usp=email ) Change subject: [RFC][POC] Docs: Integrate Breathe extension ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This currently doesn't work in the doc.coreboot.org container as Doxygen needs to be able to write its output somewhere, and the container mounts the tree as RO at /`/data-in` with `Documentation/_build/` being mounted RW at `/data-out`. Doxygen doesn't seem to have a flag to override the output directory in the Doxyfile so there isn't a trivial way to point it to `/data-out`. -- To view, visit https://review.coreboot.org/c/coreboot/+/87230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9cdf93896184848e3ea450b774160ca30f1935c Gerrit-Change-Number: 87230 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 03:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025