coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
by Subrata Banik (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87236?usp=email ) Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/87236/comment/ceeeca61_f4456019?us… : PS1, Line 10: decidxe > decide Acknowledged https://review.coreboot.org/c/coreboot/+/87236/comment/5f629651_5264140a?us… : PS1, Line 10: provide > provides Acknowledged https://review.coreboot.org/c/coreboot/+/87236/comment/d4197a19_a48fb460?us… : PS1, Line 16: SOC > SoC Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/87236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Gerrit-Change-Number: 87236 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 05:25:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
by Subrata Banik (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Hello Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87236?usp=email to look at the new patch set (#2). Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE ...................................................................... mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE This patch moves eSOL enablement from the SoC level to the mainboard level. This gives the mainboard the option to not use eSOL if it's not supported. The FSP_UGOP_EARLY_SIGN_OF_LIFE Kconfig option is now enabled for the Fatcat and Felino boards. This option was previously enabled at the SoC level for Pantherlake, but is now being enabled specifically for these mainboards. BUG=b:400550435 TEST=Build the Fatcat and Felino targets. Verify that the eSOL works fine. Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig M src/soc/intel/pantherlake/Kconfig 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/87236/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Gerrit-Change-Number: 87236 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
by Pranava Y N (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Kapil Porwal, Mac Chiang, Paul Menzel, Tongtong Pan, Varun Upadhyay, Weimin Wu. Pranava Y N has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df Gerrit-Change-Number: 85572 Gerrit-PatchSet: 7 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 05:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
by Jérémy Compostella (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87236?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/87236/comment/9c2b94eb_84aa3582?us… : PS1, Line 10: decidxe decide https://review.coreboot.org/c/coreboot/+/87236/comment/c6c38b36_4241f4d3?us… : PS1, Line 10: provide provides https://review.coreboot.org/c/coreboot/+/87236/comment/dd634123_2987cccb?us… : PS1, Line 16: SOC SoC -- To view, visit https://review.coreboot.org/c/coreboot/+/87236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Gerrit-Change-Number: 87236 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: doc/arch/x86: Add MP-Init documentation
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Maximilian Brune, Patrick Rudolph. Nicholas Chin has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86772?usp=email ) Change subject: doc/arch/x86: Add MP-Init documentation ...................................................................... Patch Set 5: (6 comments) File Documentation/arch/x86/mp_init.md: PS5: Please reflow lines to about 72 characters: https://doc.coreboot.org/getting_started/writing_documentation.html#basic-a… https://review.coreboot.org/c/coreboot/+/86772/comment/58a07d16_6eaadc4c?us… : PS5, Line 31: init_bsp() Enclose function name in backticks so that it renders as an inline code block ```suggestion First `init_bsp()` initializes the bootstrap processor. After this we are ready to initialize all other logical processors (the APs). On a hyperthreading CPU that means all physical threads. We need initialize all APs from scratch. Among other we need setup a stack, GDT, IDT, caching and a fewer other things. Since we need to setup a stack, we need to start in assembly for all APs. That is what the `src/cpu/x86/sipi_vector.S` is for. ``` https://review.coreboot.org/c/coreboot/+/86772/comment/ac977440_38fc02eb?us… : PS5, Line 36: ap_init() Same here ```suggestion The assembly code will do the bare minimum initialization before eventually jumping to c-code. That c-code is usually the `ap_init()` function. But first we need to tell the APs to wake up and start executing the SIPI vector code. We can use the "Interrupt Command Register" to issue interrupts to other local APICs (and therefore other logical processors) causing them to wake up and execute from an address of our choice (with certain restrictions). ``` https://review.coreboot.org/c/coreboot/+/86772/comment/6e0e524a_740fd0e7?us… : PS5, Line 56: setting Capitalize ```suggestion ### Setting up SMM ``` https://review.coreboot.org/c/coreboot/+/86772/comment/1e3ebf55_1af599ff?us… : PS5, Line 58: implemented in SMM. : Now Markdown requires a blank line in between paragraphs, otherwise it renders as the same paragraph. https://review.coreboot.org/c/coreboot/+/86772/comment/a5c8afa6_97f2a2b2?us… : PS5, Line 59: jumps. : Unf Same here, add a blank line -- To view, visit https://review.coreboot.org/c/coreboot/+/86772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e Gerrit-Change-Number: 86772 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email ) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/86352/comment/7ae274bf_23034ba5?us… : PS5, Line 122: $(PI_IMG_OUT) > The CONFIG_PI_IMG_FIRMWARE will be added twice. […] That's my mistake. However, now I realized that this approach is problematic, as `$(wildcard ...)` won't find anything in line 128 below. Decided to switch to a different approach. -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 7 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yu-Ping Wu (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86352?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... soc/mediatek/mt8196: Add validity check for PI_IMG Call check-pi-img.py to perform validity check for the PI_IMG firmware file. BUG=none TEST=emerge-rauru coreboot TEST=cbfstool coreboot.rom print | grep pi_img BRANCH=rauru Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86352/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 7 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: Documentation,util: Run util_readme.sh to regen *.md
by Nicholas Chin (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Yu-Ping Wu. Nicholas Chin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87224?usp=email ) Change subject: Documentation,util: Run util_readme.sh to regen *.md ...................................................................... Patch Set 1: (1 comment) File Documentation/util.md: https://review.coreboot.org/c/coreboot/+/87224/comment/dd1c4263_cbfe5b61?us… : PS1, Line 73: c > Why does `convert` become lower case ? util_readme.sh just copies whatever is in the `description.md` file for a utility. Looks like these series of commits occured: - Commit 81e0d689c078 ("Documentation: Move intelp2m from description.md to Documention") added the lowercase "convert the configuration DW0/1..." text to `util/intelp2m/description.md` - Commit 56846091f136 ("util, Documentation: Run util_readme.sh to regen util.md") updated Documentation/util.md to match using the script. - Commit da54bd60af60 ("Documentation: Update information about intelp2m") manually updated `Documentation/util.md` (without using the script) to the "Convert the inteltool ..." that's currently there, so in effect this patch effectively reverts da54bd60af60 and restores the text from 56846091f136. So I guess `util/intelp2m/description.md` should have been updated to the "Convert the inteltool register dump..." text before regenerating the *.md files using `util_readme.sh` so as to not lose the updated description from da54bd60af60 -- To view, visit https://review.coreboot.org/c/coreboot/+/87224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d3f87517c445d650e9cea61448b28d005d46737 Gerrit-Change-Number: 87224 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:31:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
by Kapil Porwal (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87236?usp=email ) Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103 Gerrit-Change-Number: 87236 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:30:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/asus/p8z77-v: Attempt to correctly route PCIe lanes
by Bill XIE (Code Review) 09 Apr '25

09 Apr '25

Attention is currently required from: Angel Pons, Keith Hui, Nicholas Chin. Bill XIE has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85413?usp=email ) Change subject: mb/asus/p8z77-v: Attempt to correctly route PCIe lanes ...................................................................... Patch Set 7: (1 comment) File src/mainboard/asus/p8x7x-series/variants/p8z77-v/early_init.c: https://review.coreboot.org/c/coreboot/+/85413/comment/3bfa8ee4_6bfd4c8e?us… : PS7, Line 104: 0x40 Let Setup = /sys/firmware/efi/efivars/Setup-ec87d643-eba4-4bb5-a1e5-3f3e36b20da9 , my result is: PCIEX1_2: Setup[0x820] == 0, Setup[0x824] == 2; ASM1061: Setup[0x820] == 0, Setup[0x824] == 0; x4: Setup[0x820] == 0, Setup[0x824] == 1; Besides, on patchset 7, when (force_asm1061 == false), if a card is present on PCIEX1_2 X_QSW_SEL2,3,4 is 111, and if not present, X_QSW_SEL2,3,4 is correctly 110. If a descriptor with (PCIEPCS1 == 1) is flashed with patchset 7, PCIEX16_3 can be confirmed working with x2, with on-board ASM1061 working with X_QSW_SEL2,3,4 being 010. PCIEX1_2 remains not working in this mode, with X_QSW_SEL2,3,4 being 011 and the following log: > [DEBUG] PCI: 00:00:1c.3 scanning... [DEBUG] PCI: pci_scan_bus for segment group 00 bus 06 [INFO ] POST: 0x24 [INFO ] POST: 0x25 [INFO ] PCI: 00:00:1c.3: Setting Max_Payload_Size to 128 for devices under this root port [WARN ] PCI: 00:00:1c.3: Has a slow downstream device. Enumeration failed. [DEBUG] scan_bus: bus PCI: 00:00:1c.3 finished in 26 msecs -- To view, visit https://review.coreboot.org/c/coreboot/+/85413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If41197a1f817a48c209d25fc1ae461ec97ccf16c Gerrit-Change-Number: 85413 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Apr 2025 04:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025