coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: treewide: Assume FMAP_SECTION_FLASH_START = 0
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Ana Carolina Cabral, Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jason Glenesk, Julius Werner, Jérémy Compostella, Martin L Roth, Matt DeVillier, Nick Kochlowski, Shuo Liu. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86771?usp=email ) Change subject: treewide: Assume FMAP_SECTION_FLASH_START = 0 ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86771/comment/d6c802c5_686f1946?us… : PS2, Line 8: > Before the changes, if we would like to get the host address of flash start we can check the fmap_co […] SOC and mainboard code should always know the flash mapping either way. common code can access the flash through `boot_device_ro()` or the relevant FMAP and CBFS functions (if you want to access FMAP regions or CBFS files). But In general common code should not need to know the actual MMIO address, besides being able to read and write the flash. cbfstool also should have knowledge about the mmap using the "--mmap" option (although I am not sure if all platforms actually use this one). -- To view, visit https://review.coreboot.org/c/coreboot/+/86771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieb1a23f9c0ae8c0e1c91287d7eb6f7f0abbf0c2c Gerrit-Change-Number: 86771 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 12 Apr 2025 13:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/brya: Optimize CBFE backed option API
by Paul Menzel (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro. Paul Menzel has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/87286?usp=email ) Change subject: mb/google/brya: Optimize CBFE backed option API ...................................................................... Patch Set 4: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/87286/comment/09e34546_a74c07d5?us… : PS4, Line 7: CBFE CBF*S* https://review.coreboot.org/c/coreboot/+/87286/comment/bd93b9f1_2c824706?us… : PS4, Line 9: Added Add https://review.coreboot.org/c/coreboot/+/87286/comment/a3b771ae_f598ba55?us… : PS4, Line 9: traversal Of what? https://review.coreboot.org/c/coreboot/+/87286/comment/8e69a6f2_009e9fef?us… : PS4, Line 10: look up lookup https://review.coreboot.org/c/coreboot/+/87286/comment/a4daa0b4_fdb4a1ab?us… : PS4, Line 10: then th*a*n https://review.coreboot.org/c/coreboot/+/87286/comment/b52031cf_44f94443?us… : PS4, Line 16: TEST=Verify option filter logic. Please add the measurements without and with your patch. File src/mainboard/google/brya/common.c: https://review.coreboot.org/c/coreboot/+/87286/comment/1187e4bd_6f101989?us… : PS4, Line 19: int size_t -- To view, visit https://review.coreboot.org/c/coreboot/+/87286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I37b33bc8fa14b3760d6d78102e0cf256310d9ac3 Gerrit-Change-Number: 87286 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 13:09:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: treewide: Assume FMAP_SECTION_FLASH_START = 0
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jason Glenesk, Julius Werner, Jérémy Compostella, Matt DeVillier, Maximilian Brune. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86771?usp=email ) Change subject: treewide: Assume FMAP_SECTION_FLASH_START = 0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieb1a23f9c0ae8c0e1c91287d7eb6f7f0abbf0c2c Gerrit-Change-Number: 86771 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 12 Apr 2025 13:01:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Julius Werner. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86770?usp=email ) Change subject: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > Yeah, that sounds like the right place. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 Gerrit-Change-Number: 86770 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 12 Apr 2025 12:57:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Maximilian Brune. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86770?usp=email to look at the new patch set (#3). Change subject: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 ...................................................................... include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 For simplicity we are going to impose this restriction to coreboot. Note however that this is only a restriction for coreboot itself. The FMAP tool itself is still a generic tool that does not require the FMAP to start at offset 0. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 --- M src/include/fmap.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/86770/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 Gerrit-Change-Number: 86770 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: util/cbfstool/fmaptool.c: Require FMAP_SECTION_FLASH_START == 0
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Maximilian Brune. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86770?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/cbfstool/fmaptool.c: Require FMAP_SECTION_FLASH_START == 0 ...................................................................... util/cbfstool/fmaptool.c: Require FMAP_SECTION_FLASH_START == 0 For simplicity we are going to impose this restriction to coreboot. Note however that this is only a restriction for coreboot itself. The FMAP tool itself is still a generic tool that does not require the FMAP to start at offset 0. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 --- M src/include/fmap.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/86770/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 Gerrit-Change-Number: 86770 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: src/arch/x86/c_start: Delete duplicated code masking stack pointer
by NyeonWoo Kim (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Jérémy Compostella, Shuo Liu. NyeonWoo Kim has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/87181?usp=email ) Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Could you track down to which commit the duplication got introduced and add it in the commit message […] Done.! -- To view, visit https://review.coreboot.org/c/coreboot/+/87181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Gerrit-Change-Number: 87181 Gerrit-PatchSet: 2 Gerrit-Owner: NyeonWoo Kim Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 12:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: src/arch/x86/c_start: Delete duplicated code masking stack pointer
by NyeonWoo Kim (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: NyeonWoo Kim, Shuo Liu. Hello Jérémy Compostella, Shuo Liu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87181?usp=email to look at the new patch set (#2). Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer ...................................................................... src/arch/x86/c_start: Delete duplicated code masking stack pointer I found duplicated code masking stack pointer. So, i'd like to remove the duplicate for refactoring :-). This is my build output of c_start.o, before vs after modifying. before modifying ... 44: f3 ab rep stos %eax,%es:(%edi) 46: bc 00 00 00 00 mov $0x0,%esp 4b: 83 e4 f0 and $0xfffffff0,%esp 4e: b0 6e mov $0x6e,%al 50: e6 80 out %al,$0x80 52: 83 e4 f0 and $0xfffffff0,%esp // deleted. 55: e8 fc ff ff ff call 56 <_start+0x56> ... after modifying ... 44: f3 ab rep stos %eax,%es:(%edi) 46: bc 00 00 00 00 mov $0x0,%esp 4b: 83 e4 f0 and $0xfffffff0,%esp 4e: b0 6e mov $0x6e,%al 50: e6 80 out %al,$0x80 52: e8 fc ff ff ff call 53 <_start+0x53> ... P.S. it is commits which introduced duplication. 32bit : 4d75dbd1c1d 64bit : 1c4c7ad1e5a Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Signed-off-by: NyeonWoo Kim <knw0507(a)naver.com> --- M src/arch/x86/c_start.S 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/87181/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Gerrit-Change-Number: 87181 Gerrit-PatchSet: 2 Gerrit-Owner: NyeonWoo Kim Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: NyeonWoo Kim

1 0

[XS] Change in coreboot[main]: treewide: Remove remainders of ROM_BASE
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87288?usp=email ) Change subject: treewide: Remove remainders of ROM_BASE ...................................................................... treewide: Remove remainders of ROM_BASE commit a7eb390796ef ("mb/*/*/*.fmd: Start flash at 0") caused a build failure for all mainboards that generate their FMAP from the IFD (so intel only) instead of providing one themselves. Jenkins didn't catch, because apparently all mainboards that have the IFD in the 3rdparty/blobs repository provide a custom FMAP. So there was no defconfig that jenkins tested that would come across this issue. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 --- M Makefile.mk M util/ifdtool/ifdtool.c 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/87288/1 diff --git a/Makefile.mk b/Makefile.mk index 19bac29..576cebd 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -1098,7 +1098,6 @@ # entire flash FMAP_ROM_SIZE := $(CONFIG_ROM_SIZE) # entire "BIOS" region (everything directly of concern to the host system) -# relative to ROM_BASE FMAP_BIOS_BASE := $(call int-align, $(call int-subtract, $(CONFIG_ROM_SIZE) $(CONFIG_CBFS_SIZE)), 0x10000) FMAP_BIOS_SIZE := $(call int-align-down, $(shell echo $(CONFIG_CBFS_SIZE) | tr A-F a-f), 0x10000) # position and size of flashmap, relative to BIOS_BASE @@ -1186,7 +1185,6 @@ # entire flash FMAP_ROM_SIZE := $(CONFIG_ROM_SIZE) # entire "BIOS" region (everything directly of concern to the host system) -# relative to ROM_BASE FMAP_BIOS_BASE := 0 FMAP_BIOS_SIZE := $(CONFIG_CBFS_SIZE) # position and size of flashmap, relative to BIOS_BASE diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 94105ef..b21a89c 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -1094,7 +1094,7 @@ exit(EXIT_FAILURE); } - char *bbuf = "FLASH@##ROM_BASE## ##ROM_SIZE## {\n"; + char *bbuf = "FLASH ##ROM_SIZE## {\n"; if (write(layout_fd, bbuf, strlen(bbuf)) < 0) { perror("Could not write to file"); exit(EXIT_FAILURE); -- To view, visit https://review.coreboot.org/c/coreboot/+/87288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 Gerrit-Change-Number: 87288 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: superio/fintek/f81866d: Undo set config mode for HWM
by Angel Pons (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Maxim Polyakov. Angel Pons has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/87274?usp=email ) Change subject: superio/fintek/f81866d: Undo set config mode for HWM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87274?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic27c9eee5a58727a70fc0ebe60a643f45a418d36 Gerrit-Change-Number: 87274 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 09:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025