coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: superio/fintek/f81866d: Fix HWM port address
by Maxim Polyakov (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Harrie Paijmans, Paul Menzel. Maxim Polyakov has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/87273?usp=email ) Change subject: superio/fintek/f81866d: Fix HWM port address ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87273/comment/7fb0847b_3beed9f7?us… : PS1, Line 14: > It’d be great if you could add a TEST= line. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If39400e56a7d0792a5bc8f312c29dd5e98a0b2d3 Gerrit-Change-Number: 87273 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 17:02:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: superio/fintek/f81866d: Fix HWM port address
by Maxim Polyakov (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Harrie Paijmans, Maxim Polyakov. Hello Angel Pons, Felix Held, Harrie Paijmans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87273?usp=email to look at the new patch set (#2). Change subject: superio/fintek/f81866d: Fix HWM port address ...................................................................... superio/fintek/f81866d: Fix HWM port address The HWM port is +5 to the base address stored in LDN 0x4 at index 0x60/0x61. Take this rule into account when configuring the monitor, as it was done for Fintek SIO chips in the superiotool utility [1]. [1] commit d92745b TEST=Run coreboot on the motherboard with the Fintek A81966 chip (which is architecturally compatible) with the same HWM initialization code: - the fans are regulated correctly; - superiotool prints the values of the configuration registers updated during initialization. Change-Id: If39400e56a7d0792a5bc8f312c29dd5e98a0b2d3 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M src/superio/fintek/f81866d/f81866d_hwm.c 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/87273/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If39400e56a7d0792a5bc8f312c29dd5e98a0b2d3 Gerrit-Change-Number: 87273 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com>

1 0

[XS] Change in coreboot[main]: src/arch/x86/c_start: Delete duplicated code masking stack pointer
by Shuo Liu (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Jérémy Compostella, NyeonWoo Kim, Paul Menzel. Shuo Liu has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/87181?usp=email ) Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: +Paul to review commit message and formats. -- To view, visit https://review.coreboot.org/c/coreboot/+/87181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Gerrit-Change-Number: 87181 Gerrit-PatchSet: 2 Gerrit-Owner: NyeonWoo Kim Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: NyeonWoo Kim Gerrit-Comment-Date: Sat, 12 Apr 2025 15:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: cpu/x86/smm: Add support for exception handling
by Shuo Liu (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Patrick Rudolph. Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87208?usp=email ) Change subject: cpu/x86/smm: Add support for exception handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87208?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ccaf8d23d508d773ce56912983884ad6832ede6 Gerrit-Change-Number: 87208 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 14:09:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: superio/fintek/f81866d: Fix HWM port address
by Paul Menzel (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Harrie Paijmans, Maxim Polyakov. Paul Menzel has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/87273?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: superio/fintek/f81866d: Fix HWM port address ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87273/comment/87469458_10278206?us… : PS1, Line 14: It’d be great if you could add a TEST= line. -- To view, visit https://review.coreboot.org/c/coreboot/+/87273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If39400e56a7d0792a5bc8f312c29dd5e98a0b2d3 Gerrit-Change-Number: 87273 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 14:02:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: superio/fintek/f81866d: Undo set config mode for HWM
by Paul Menzel (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Maxim Polyakov. Paul Menzel has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/87274?usp=email ) Change subject: superio/fintek/f81866d: Undo set config mode for HWM ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87274?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic27c9eee5a58727a70fc0ebe60a643f45a418d36 Gerrit-Change-Number: 87274 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Apr 2025 14:02:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/amd/common/cpu/noncar: Compute core info
by Paul Menzel (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki. Paul Menzel has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/common/cpu/noncar: Compute core info ...................................................................... Patch Set 16: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85640/comment/3bf6d634_be570b39?us… : PS16, Line 7: Compute core info It’d be great if you could be more specific. https://review.coreboot.org/c/coreboot/+/85640/comment/bb0e1c90_618ada1e?us… : PS16, Line 9: In some SoC like Glinda, have : 1. Different CPU cores have *In some … have, … have* is confusing to me. It’d be great if you could rephrase it. https://review.coreboot.org/c/coreboot/+/85640/comment/998ae708_4b27babf?us… : PS16, Line 13: function function*s* https://review.coreboot.org/c/coreboot/+/85640/comment/c0a22f19_85a9cb0c?us… : PS16, Line 19: Retrieves Imperative mood: Retrieve (also below) https://review.coreboot.org/c/coreboot/+/85640/comment/43d05052_b16367d8?us… : PS16, Line 26: 24MB What was it before? -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 16 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 12 Apr 2025 14:02:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-q35/Makefile.mk: Use all-y for memmap.c
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87290?usp=email ) Change subject: mb/emulation/qemu-q35/Makefile.mk: Use all-y for memmap.c ...................................................................... mb/emulation/qemu-q35/Makefile.mk: Use all-y for memmap.c Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I14cd19c6c0f458a8d9a4034bb6faff0b42577f54 --- M src/mainboard/emulation/qemu-q35/Makefile.mk 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/87290/1 diff --git a/src/mainboard/emulation/qemu-q35/Makefile.mk b/src/mainboard/emulation/qemu-q35/Makefile.mk index fc85e64..f0612ce 100644 --- a/src/mainboard/emulation/qemu-q35/Makefile.mk +++ b/src/mainboard/emulation/qemu-q35/Makefile.mk @@ -1,22 +1,19 @@ ## SPDX-License-Identifier: GPL-2.0-only bootblock-y += bootblock.c -bootblock-y += memmap.c romstage-y += ../qemu-i440fx/memmap.c -romstage-y += memmap.c postcar-y += ../qemu-i440fx/memmap.c postcar-y += ../qemu-i440fx/exit_car.S -postcar-y += memmap.c ramstage-y += ../qemu-i440fx/memmap.c ramstage-y += ../qemu-i440fx/northbridge.c ramstage-y += ../qemu-i440fx/rom_media.c -ramstage-y += memmap.c ramstage-y += cpu.c all-y += ../qemu-i440fx/bootmode.c +all-y += memmap.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c -- To view, visit https://review.coreboot.org/c/coreboot/+/87290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14cd19c6c0f458a8d9a4034bb6faff0b42577f54 Gerrit-Change-Number: 87290 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: soc/amd/mendocino/Makefile.mk: Fix syntax with trailing "/"
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87289?usp=email ) Change subject: soc/amd/mendocino/Makefile.mk: Fix syntax with trailing "/" ...................................................................... soc/amd/mendocino/Makefile.mk: Fix syntax with trailing "/" It doesn't cause any problems, because the next line is empty. But it is wrong nonetheless. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I8f1e99e06575e769f5698e4cd86e44f0b4df8a07 --- M src/soc/amd/mendocino/Makefile.mk 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/87289/1 diff --git a/src/soc/amd/mendocino/Makefile.mk b/src/soc/amd/mendocino/Makefile.mk index 69578d1..be7f4da 100644 --- a/src/soc/amd/mendocino/Makefile.mk +++ b/src/soc/amd/mendocino/Makefile.mk @@ -52,10 +52,10 @@ endif # ($(CONFIG_CBFS_VERIFICATION), y) MENDOCINO_FW_A_POSITION=$(call int-add, \ - $(call get_fmap_value,FMAP_SECTION_FW_MAIN_A_START) $(AMD_FW_AB_POSITION)) \ + $(call get_fmap_value,FMAP_SECTION_FW_MAIN_A_START) $(AMD_FW_AB_POSITION)) MENDOCINO_FW_B_POSITION=$(call int-add, \ - $(call get_fmap_value,FMAP_SECTION_FW_MAIN_B_START) $(AMD_FW_AB_POSITION)) \ + $(call get_fmap_value,FMAP_SECTION_FW_MAIN_B_START) $(AMD_FW_AB_POSITION)) MENDOCINO_FW_BODY_OFFSET := 0x100 -- To view, visit https://review.coreboot.org/c/coreboot/+/87289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f1e99e06575e769f5698e4cd86e44f0b4df8a07 Gerrit-Change-Number: 87289 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: treewide: Remove remainders of ROM_BASE
by Maximilian Brune (Code Review) 12 Apr '25

12 Apr '25

Attention is currently required from: David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Matt DeVillier, Shuo Liu. Hello David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Matt DeVillier, Shuo Liu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87288?usp=email to look at the new patch set (#2). Change subject: treewide: Remove remainders of ROM_BASE ...................................................................... treewide: Remove remainders of ROM_BASE commit a7eb390796ef ("mb/*/*/*.fmd: Start flash at 0") caused a build failure for all mainboards that generate their FMAP from the IFD (so intel only) instead of providing one themselves. Jenkins didn't catch that, because apparently all mainboards that have the IFD in the 3rdparty/blobs repository provide a custom FMAP. So there was no defconfig that jenkins tested that would come across this issue. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 --- M Makefile.mk M util/ifdtool/ifdtool.c 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/87288/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 Gerrit-Change-Number: 87288 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025