coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: soc/amd/*/include/aoac_defs.h: add I3C controller AOAC IDs
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Ana Carolina Cabral, Felix Held, Martin L Roth, Patrick Rudolph. Maximilian Brune has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/87279?usp=email ) Change subject: soc/amd/*/include/aoac_defs.h: add I3C controller AOAC IDs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87279?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I54d049c58756251506f94d220e1970ccec170918 Gerrit-Change-Number: 87279 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Apr 2025 17:26:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/amd: report I3C controller MMIO to resource allocator
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Ana Carolina Cabral, Felix Held, Martin L Roth, Patrick Rudolph. Maximilian Brune has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/87277?usp=email ) Change subject: soc/amd: report I3C controller MMIO to resource allocator ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebf709d2548f2535b2a2a03a4f6da9531559c238 Gerrit-Change-Number: 87277 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Apr 2025 16:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: vc/amd/fsp: Update DMI structs for glinda
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Paul Menzel. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87086?usp=email ) Change subject: vc/amd/fsp: Update DMI structs for glinda ...................................................................... Patch Set 4: (4 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/87086/comment/ca902073_0ce3f782?us… : PS3, Line 7: src/ > Remove. Done https://review.coreboot.org/c/coreboot/+/87086/comment/a0998987_4d020967?us… : PS3, Line 7: vendorcode > vc Done https://review.coreboot.org/c/coreboot/+/87086/comment/efed6f36_1af7594d?us… : PS3, Line 7: Update for glinda > It’d be great if you were more specific. Done https://review.coreboot.org/c/coreboot/+/87086/comment/a450d628_7ee03dd3?us… : PS3, Line 12: shows more accurate info > Maybe add output (excerpt) before and after. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I110039e160ada8899e3a414fcf32ee8236b510b4 Gerrit-Change-Number: 87086 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/guren: Add SPD ID for H58G56CK8BX146
by Kapil Porwal (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Brian Hsu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Paul Menzel, Subrata Banik. Kapil Porwal has posted comments on this change by Brian Hsu. ( https://review.coreboot.org/c/coreboot/+/87275?usp=email ) Change subject: mb/google/nissa/var/guren: Add SPD ID for H58G56CK8BX146 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4616b44a164391d7a14cc97efb059e731d35c308 Gerrit-Change-Number: 87275 Gerrit-PatchSet: 6 Gerrit-Owner: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: David Li <david_li(a)pegatron.corp-partner.google.com> Gerrit-CC: Samuel Chen <samuel_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:42:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/qualcomm/common: Avoid hardcoding SPI bus from QUP range
by Kapil Porwal (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Julius Werner, Subrata Banik. Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87270?usp=email ) Change subject: soc/qualcomm/common: Avoid hardcoding SPI bus from QUP range ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e9ec555a6d72d93bc23285e48eab52030978e1a Gerrit-Change-Number: 87270 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mainboard/asrock/imb-1222: Put options in CFR cbtable
by Maxim Polyakov (Code Review) 13 Apr '25

13 Apr '25

Maxim Polyakov has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/85981?usp=email ) Change subject: mainboard/asrock/imb-1222: Put options in CFR cbtable ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85981?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3b4cd089a45f4549ca0fe822b3c073d51ad52e7 Gerrit-Change-Number: 85981 Gerrit-PatchSet: 7 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:09:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: treewide: Remove remainders of ROM_BASE
by Angel Pons (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Maximilian Brune, Shuo Liu. Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87288?usp=email ) Change subject: treewide: Remove remainders of ROM_BASE ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Should we add a test case? -- To view, visit https://review.coreboot.org/c/coreboot/+/87288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 Gerrit-Change-Number: 87288 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:05:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: treewide: Remove remainders of ROM_BASE
by Angel Pons (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Maximilian Brune, Shuo Liu. Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87288?usp=email ) Change subject: treewide: Remove remainders of ROM_BASE ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 Gerrit-Change-Number: 87288 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Sun, 13 Apr 2025 15:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: util/amdfwtool: Move APOB_NV quirk to amdfwtool.c
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87294?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/amdfwtool: Move APOB_NV quirk to amdfwtool.c ...................................................................... util/amdfwtool: Move APOB_NV quirk to amdfwtool.c This moves the code to amdfwtool.c, because the subsequent patch needs it to be there in order to properly update the address_mode. This patch should not change the binary in ANY way on any platform. tested: Check that the binary is identical on guybrush, birman_plus, frostflow, bilby, crater, grunt, myst, onyx_poc, morphius Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I9c64c67ff8b9656516344fdafbfd2254abfceeef --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/data_parse.c 2 files changed, 42 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/87294/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9c64c67ff8b9656516344fdafbfd2254abfceeef Gerrit-Change-Number: 87294 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: util/amdfwtool/amdfwtool.c: Remove APOB_NV src address check
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87292?usp=email to look at the new patch set (#2). Change subject: util/amdfwtool/amdfwtool.c: Remove APOB_NV src address check ...................................................................... util/amdfwtool/amdfwtool.c: Remove APOB_NV src address check The current approach has two problems: - Just because the source address is 0 does not mean it is no specifically set. A bunch of mainboards specify their APOB_NV base address at 0 in their FMAP files. - There is no AMD SOC that has support for this binary, but doesn't give AMDFWTOOL the base address. It would also not work considering that AMD common/block/apob code gets the region from the FMAP. Therefore just remove the check since no mainboard will ever enter the else branch. tested: binary identical for at least 1 mainboard on each SOC generation. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ic85d6b25c95ab12dbcc72d17158591891dd04e97 --- M util/amdfwtool/amdfwtool.c 1 file changed, 5 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/87292/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic85d6b25c95ab12dbcc72d17158591891dd04e97 Gerrit-Change-Number: 87292 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025