coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: [WIP] arch/riscv/smp: Fix race condition
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87299?usp=email ) Change subject: [WIP] arch/riscv/smp: Fix race condition ...................................................................... [WIP] arch/riscv/smp: Fix race condition If the APs are much faster then the working hart, it is possible that it will enter HART_SLEEPING state before the working hart checks whether or not the APs woke up by checking the HART_AWAKE state. One can reproduce this issue by adding the following print message and testing it in QEMU. One will notice that it will get stuck. + printk(BIOS_SPEW, "waiting for hart %d\n", i); while (atomic_read(&OTHER_HLS(i)->entry.sync_a) != HART_AWAKE) Fix it by adding another sync step at the end of `smp_resume()`. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I1e0485831f71dde400d793b9f7bda88ae6519913 --- M src/arch/riscv/smp.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/87299/1 diff --git a/src/arch/riscv/smp.c b/src/arch/riscv/smp.c index 67dc13b..a08e16b 100644 --- a/src/arch/riscv/smp.c +++ b/src/arch/riscv/smp.c @@ -7,6 +7,22 @@ #include <console/console.h> #include <mcall.h> +/* + * BSP + * AP --------------------------------- <--- + * | sync_b=HART_SLEEPING | | + * ---> --------------------------------- --------------------------------- | + * | | sync_a=HART_SLEEPING | ----> | Wait for sync_a=HART_SLEEPING | | + * | --------------------------------- --------------------------------- | + * | | Wait for Interrupt | <---- | set_msip() | | + * | --------------------------------- --------------------------------- | + * | | sync_a=HART_AWAKE | ----> | Wait for sync_a=HART_AWAKE | | + * | --------------------------------- --------------------------------- | + * | | Wait for sync_b=HART_AWAKE | <---- | sync_b=HART_AWAKE | | + * ---- --------------------------------- --------------------------------- ---- + * + */ + // made up value to sync hart state #define HART_SLEEPING 0x1 #define HART_AWAKE 0x2 @@ -29,6 +45,11 @@ } while ((read_csr(mip) & MIP_MSIP) == 0); atomic_set(&HLS()->entry.sync_a, HART_AWAKE); // mark the hart as awake + + // wait for working_hart to notice that this hart is awake + while (atomic_read(&HLS()->entry.sync_b) != HART_AWAKE) + ; + HLS()->entry.fn(HLS()->entry.arg); } } @@ -55,6 +76,8 @@ if (i == working_hartid) continue; + atomic_set(&HLS()->entry.sync_b, HART_SLEEPING); + if (atomic_read(&OTHER_HLS(i)->entry.sync_a) != HART_SLEEPING) { /* * we assmue here that the time between smp_pause and smp_resume @@ -83,6 +106,8 @@ // wait for hart to publish its waking state while (atomic_read(&OTHER_HLS(i)->entry.sync_a) != HART_AWAKE) ; + // signal to hart that we noticed it woke up + atomic_set(&HLS()->entry.sync_b, HART_AWAKE); count_awake_harts++; } printk(BIOS_DEBUG, "all harts up and running...\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/87299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e0485831f71dde400d793b9f7bda88ae6519913 Gerrit-Change-Number: 87299 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: soc/amd/*/i2c: add missing iomap.h include
by Felix Held (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Ana Carolina Cabral, Elyes Haouas, Martin L Roth, Maximilian Brune, Patrick Rudolph. Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/87281?usp=email ) Change subject: soc/amd/*/i2c: add missing iomap.h include ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87281/comment/745a940e_edf1c6b6?us… : PS1, Line 9: APU_I2C*_BASE are efined in the soc's iomap.h, so include it. > are defined* Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87281?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7b1674914a045699d6df53b20e35028c3936f67 Gerrit-Change-Number: 87281 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 13 Apr 2025 19:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: soc/amd/*/i2c: add missing iomap.h include
by Felix Held (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Ana Carolina Cabral, Felix Held, Martin L Roth, Maximilian Brune, Patrick Rudolph. Hello Ana Carolina Cabral, Martin L Roth, Maximilian Brune, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87281?usp=email to look at the new patch set (#2). Change subject: soc/amd/*/i2c: add missing iomap.h include ...................................................................... soc/amd/*/i2c: add missing iomap.h include APU_I2C*_BASE are defined in the SoC's iomap.h, so include it. Change-Id: Id7b1674914a045699d6df53b20e35028c3936f67 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/cezanne/i2c.c M src/soc/amd/genoa_poc/i2c.c M src/soc/amd/glinda/i2c.c M src/soc/amd/mendocino/i2c.c M src/soc/amd/phoenix/i2c.c 5 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/87281/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87281?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7b1674914a045699d6df53b20e35028c3936f67 Gerrit-Change-Number: 87281 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: soc/amd/cezanne: Enable system wake up from ACPI S3 using USB keyboard
by Felix Held (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Anand Vaikar. Felix Held has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/87287?usp=email ) Change subject: soc/amd/cezanne: Enable system wake up from ACPI S3 using USB keyboard ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieed635a7199f53c2e7c69c8f17b3ef50b76b8d91 Gerrit-Change-Number: 87287 Gerrit-PatchSet: 1 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Apr 2025 19:29:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: doc/arch/x86: Add MP-Init documentation
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Nicholas Chin, Patrick Rudolph. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86772?usp=email ) Change subject: doc/arch/x86: Add MP-Init documentation ...................................................................... Patch Set 7: (1 comment) File Documentation/arch/x86/mp_init.md: PS5: > Please reflow lines to about 72 characters: https://doc.coreboot. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e Gerrit-Change-Number: 86772 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Apr 2025 19:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: doc/arch/x86: Add MP-Init documentation
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Nicholas Chin, Patrick Rudolph. Hello Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86772?usp=email to look at the new patch set (#7). Change subject: doc/arch/x86: Add MP-Init documentation ...................................................................... doc/arch/x86: Add MP-Init documentation Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I1d16d608981d83438999321b30c2921a526f307e --- M Documentation/arch/x86/index.md A Documentation/arch/x86/mp_init.gv A Documentation/arch/x86/mp_init.md A Documentation/arch/x86/mp_init.svg A Documentation/arch/x86/mp_init_entry.gv A Documentation/arch/x86/mp_init_entry.svg 6 files changed, 581 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/86772/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e Gerrit-Change-Number: 86772 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[L] Change in coreboot[main]: doc/arch/x86: Add MP-Init documentation
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Nicholas Chin, Patrick Rudolph. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86772?usp=email ) Change subject: doc/arch/x86: Add MP-Init documentation ...................................................................... Patch Set 5: (5 comments) File Documentation/arch/x86/mp_init.md: https://review.coreboot.org/c/coreboot/+/86772/comment/97380336_5711ef9b?us… : PS5, Line 31: init_bsp() > Enclose function name in backticks so that it renders as an inline code block […] Done https://review.coreboot.org/c/coreboot/+/86772/comment/c7a04be8_b6a84189?us… : PS5, Line 36: ap_init() > Same here […] Done https://review.coreboot.org/c/coreboot/+/86772/comment/640415bf_0a8c8389?us… : PS5, Line 56: setting > Capitalize […] Done https://review.coreboot.org/c/coreboot/+/86772/comment/17400af9_34468ae1?us… : PS5, Line 58: implemented in SMM. : Now > Markdown requires a blank line in between paragraphs, otherwise it renders as the same paragraph. Done https://review.coreboot.org/c/coreboot/+/86772/comment/ed2cc697_dc83e792?us… : PS5, Line 59: jumps. : Unf > Same here, add a blank line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e Gerrit-Change-Number: 86772 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Apr 2025 19:08:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: doc/arch/x86: Add MP-Init documentation
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Maximilian Brune, Patrick Rudolph. Hello Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86772?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc/arch/x86: Add MP-Init documentation ...................................................................... doc/arch/x86: Add MP-Init documentation Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I1d16d608981d83438999321b30c2921a526f307e --- M Documentation/arch/x86/index.md A Documentation/arch/x86/mp_init.gv A Documentation/arch/x86/mp_init.md A Documentation/arch/x86/mp_init.svg A Documentation/arch/x86/mp_init_entry.gv A Documentation/arch/x86/mp_init_entry.svg 6 files changed, 503 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/86772/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e Gerrit-Change-Number: 86772 Gerrit-PatchSet: 6 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in coreboot[main]: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Julius Werner. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86770?usp=email to look at the new patch set (#4). Change subject: include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 ...................................................................... include/fmap.h: Require FMAP_SECTION_FLASH_START == 0 For simplicity we are going to impose this restriction to coreboot. Note however that this is only a restriction for coreboot itself. The FMAP tool itself is still a generic tool that does not require the FMAP to start at offset 0. Add an defacto empty fmap_config.h to our test cases, since fmap.h now includes fmap_config.h. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 --- M src/include/fmap.h A tests/include/tests/lib/fmap_config.h M tests/lib/Makefile.mk 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/86770/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba04ebdcd5557664a865d2854028dd811f052249 Gerrit-Change-Number: 86770 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: soc/amd/common/cpu/noncar: Compute core info
by Maximilian Brune (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki. Maximilian Brune has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/common/cpu/noncar: Compute core info ...................................................................... Patch Set 16: (1 comment) File src/soc/amd/common/block/include/amdblocks/cpu.h: https://review.coreboot.org/c/coreboot/+/85640/comment/bccb4488_8a58b029?us… : PS16, Line 11: struct core_info { : /* Core max boost frequency */ : uint32_t max_frequency; : : /* L3 Cache block unique ID & size (in bytes) */ : uint16_t l3_cache_uid; : size_t l3_cache_size; : }; : put this into the `cpu.c` file, since its not used outside of that file. -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 16 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Apr 2025 17:41:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025