coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[L] Change in coreboot[main]: vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05
by Subrata Banik (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Ronak Kanabar, srinivas.kulkarni(a)intel.com. Subrata Banik has posted comments on this change by Alok Agarwal. ( https://review.coreboot.org/c/coreboot/+/87000?usp=email ) Change subject: vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05 ...................................................................... Patch Set 4: (1 comment) File src/vendorcode/intel/fsp/fsp2_0/pantherlake/MemInfoHob.h: https://review.coreboot.org/c/coreboot/+/87000/comment/c162e91c_35eb45ac?us… : PS3, Line 2: file contains definitions required for creation of : Memory S3 Save data, Memory Info data and Memory Platform : data hobs. : : @copyright : Copyright (c) 1999 - 2024, Intel Corporation. All rights reserved.<BR> : This program and the accompanying materials are licensed and made available under : the terms and conditions of the BSD License that accompanies this distribution. : The full text of the license may be found at : http://opensource.org/licenses/bsd-license.php. : THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, : : WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. : : @par Specification Reference: : **/ : : #ifndef _MEM_INFO_HOB_H_ : #define _MEM_INFO_HOB_H_ : > > Way too many changes here. It looks like you are changing the file encoding (unix vs. windows) […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/87000?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I054e419ef23ada67347750e7a68014c2bb112199 Gerrit-Change-Number: 87000 Gerrit-PatchSet: 4 Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: srinivas.kulkarni(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Attention: srinivas.kulkarni(a)intel.com Gerrit-Comment-Date: Mon, 14 Apr 2025 03:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[L] Change in coreboot[main]: vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05
by Alok Agarwal (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Ronak Kanabar, srinivas.kulkarni(a)intel.com. Hello Intel coreboot Reviewers, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, build bot (Jenkins), srinivas.kulkarni(a)intel.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87000?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by Jérémy Compostella, Verified-1 by build bot (Jenkins) Change subject: vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05 ...................................................................... vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05 Update header files for FSP for Panther Lake platform to version 3103_05, with the previous version being 3071_00. Changes include: - Updating UPD Offset in FspmUpd.h and FspsUpd.h - Updated MemInfoHob.h : Update MEMORY_INFO_DATA_HOB, child structures and their data for SMBIOS type 16/17 design change BUG=b:406375765 TEST=Able to build google/fatcat. Change-Id: I054e419ef23ada67347750e7a68014c2bb112199 Signed-off-by: Alok Agarwal <alok.agarwal(a)intel.corp-partner.google.com> --- M src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/pantherlake/MemInfoHob.h 3 files changed, 209 insertions(+), 252 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/87000/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/87000?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I054e419ef23ada67347750e7a68014c2bb112199 Gerrit-Change-Number: 87000 Gerrit-PatchSet: 4 Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: srinivas.kulkarni(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Attention: srinivas.kulkarni(a)intel.com

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Enable ARM Trusted Firmware integration
by Yidi Lin (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87003?usp=email ) Change subject: soc/mediatek/mt8189: Enable ARM Trusted Firmware integration ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The MT8189 ATF is not upstreamed yet. submodule updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/87003?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5c311bea10ad8cb0b8b7a5e48d9e36d0d569a7e Gerrit-Change-Number: 87003 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 02:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Enable ARM Trusted Firmware integration
by Yidi Lin (Code Review) 13 Apr '25

13 Apr '25

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87003?usp=email ) Change subject: soc/mediatek/mt8189: Enable ARM Trusted Firmware integration ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please rebase this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/87003?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5c311bea10ad8cb0b8b7a5e48d9e36d0d569a7e Gerrit-Change-Number: 87003 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 02:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Update arm-trusted-firmware submodule to upstream master
by Yidi Lin (Code Review) 13 Apr '25

13 Apr '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87269?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id e5a1f4abeec3: 2025-03-03 16:21:54 +0100 - (Merge "feat(mt8196): fix MT8196 gpio driver" into integration) to commit id 57ac3f74b34a: 2025-04-09 20:07:35 +0200 - (Merge "feat(stm32mp15-fdts): add Linux Automation GmbH TAC" into integration) This brings in 244 new commits. Change-Id: I22ec128c99e84fd80fbc7de06f2791c627ae790a Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87269 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index e5a1f4a..57ac3f7 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit e5a1f4abeec3311e65412a2905873a110a9abdd1 +Subproject commit 57ac3f74b34a3303f03deee264a1f2247c68008d -- To view, visit https://review.coreboot.org/c/coreboot/+/87269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22ec128c99e84fd80fbc7de06f2791c627ae790a Gerrit-Change-Number: 87269 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: util/scripts/update_submodules: Fix "branch: unbound variable" error
by Yidi Lin (Code Review) 13 Apr '25

13 Apr '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87268?usp=email ) Change subject: util/scripts/update_submodules: Fix "branch: unbound variable" error ...................................................................... util/scripts/update_submodules: Fix "branch: unbound variable" error After CB:86803, ${branch} variable is no longer valid. Use ${branch_name} instead ${branch} for generating the commit message. TEST=./util/scripts/update_submodules -R 3rdparty/arm-trusted-firmware/ The script generates the new commit successfully. Change-Id: Ia528379b8721e6d419984bab28de7cf427e42423 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87268 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/scripts/update_submodules 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yu-Ping Wu: Looks good to me, approved Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index cbf2364..9eeb383 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -132,7 +132,7 @@ cd "${TOP}" || exit 1 git add "${submodule}" > /dev/null 2>&1 || exit 1 git commit -s -F- > /dev/null 2>&1 <<-EOF - Update ${submodule##*/} submodule to upstream ${branch##*/} + Update ${submodule##*/} submodule to upstream ${branch_name##*/} Updating from commit id ${initial_commit_id}: $initial_commit_description -- To view, visit https://review.coreboot.org/c/coreboot/+/87268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia528379b8721e6d419984bab28de7cf427e42423 Gerrit-Change-Number: 87268 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Support x32 memory configuration
by Subrata Banik (Code Review) 13 Apr '25

13 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87212?usp=email ) Change subject: mb/google/nissa/var/telith: Support x32 memory configuration ...................................................................... mb/google/nissa/var/telith: Support x32 memory configuration Use GPP_E19 level to determine whether x32 memory configuration is supported. BUG=b:405303038 TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87212 Reviewed-by: Jayvik Desai <jayvik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Reviewed-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/telith/Makefile.mk M src/mainboard/google/brya/variants/telith/gpio.c A src/mainboard/google/brya/variants/telith/memory.c 4 files changed, 27 insertions(+), 0 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved Dinesh Gehlot: Looks good to me, approved build bot (Jenkins): Verified Jayvik Desai: Looks good to me, but someone else must approve Qinghong Zeng: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 5331f0e..50a2959 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -631,6 +631,7 @@ select DRIVERS_INTEL_MIPI_CAMERA select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD select SOC_INTEL_TWINLAKE + select ENFORCE_MEM_CHANNEL_DISABLE config BOARD_GOOGLE_TEREID select BOARD_GOOGLE_BASEBOARD_NISSA diff --git a/src/mainboard/google/brya/variants/telith/Makefile.mk b/src/mainboard/google/brya/variants/telith/Makefile.mk index e7ef021..b67f308 100644 --- a/src/mainboard/google/brya/variants/telith/Makefile.mk +++ b/src/mainboard/google/brya/variants/telith/Makefile.mk @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only bootblock-y += gpio.c +romstage-y += memory.c romstage-y += gpio.c ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/telith/gpio.c b/src/mainboard/google/brya/variants/telith/gpio.c index 0043111..75f7617 100644 --- a/src/mainboard/google/brya/variants/telith/gpio.c +++ b/src/mainboard/google/brya/variants/telith/gpio.c @@ -69,6 +69,9 @@ /* R7 : DMIC_DATA_1A ==> NC */ PAD_NC_LOCK(GPP_R7, NONE, LOCK_CONFIG), + /* E19 : DDP1_CTRLDATA ==> GPP_E19_STRAP */ + PAD_CFG_GPI_LOCK(GPP_E19, DN_20K, LOCK_CONFIG), + /* Configure the virtual CNVi Bluetooth I2S GPIO pads */ /* BT_I2S_BCLK */ PAD_CFG_NF(GPP_VGPIO_30, NONE, DEEP, NF3), @@ -112,6 +115,8 @@ PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* H11 : UART0_TXD ==> UART_SOC_TX_DBG_RX */ PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), + /* E19 : DDP1_CTRLDATA ==> GPP_E19_STRAP */ + PAD_CFG_GPI_LOCK(GPP_E19, DN_20K, LOCK_CONFIG), }; const struct pad_config *variant_gpio_override_table(size_t *num) diff --git a/src/mainboard/google/brya/variants/telith/memory.c b/src/mainboard/google/brya/variants/telith/memory.c new file mode 100644 index 0000000..51a7ff5 --- /dev/null +++ b/src/mainboard/google/brya/variants/telith/memory.c @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <gpio.h> +#include <soc/romstage.h> + +uint8_t mb_get_channel_disable_mask(void) +{ + /* + * GPP_E19 High -> One RAM Chip + * GPP_E19 Low -> Two RAM Chip + */ + if (gpio_get(GPP_E19)) { + /* Disable all other channels except first two on each controller */ + return (BIT(2) | BIT(3)); + } + + return 0; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/87212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Gerrit-Change-Number: 87212 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146
by Subrata Banik (Code Review) 13 Apr '25

13 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87252?usp=email ) Change subject: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146 ...................................................................... mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146 Add the new memory support: Hynix H58G56CK8BX146 BUG=b:404452285 BRANCH=firmware-nissa-15217.B TEST=Run command "go run ./util/spd_tools/src/part_id_gen/\ part_id_gen.go ADL lp5 \ src/mainboard/google/brya/variants/glassway/memory/ \ src/mainboard/google/brya/variants/glassway/memory/\ mem_parts_used.txt" Change-Id: I1d6bbb778e75f6f32012e0cf6f427101d3616246 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87252 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/brya/variants/glassway/memory/Makefile.mk M src/mainboard/google/brya/variants/glassway/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Daniel Peng: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Jayvik Desai: Looks good to me, approved Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brya/variants/glassway/memory/Makefile.mk b/src/mainboard/google/brya/variants/glassway/memory/Makefile.mk index c3f12fb..63f419c 100644 --- a/src/mainboard/google/brya/variants/glassway/memory/Makefile.mk +++ b/src/mainboard/google/brya/variants/glassway/memory/Makefile.mk @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# /tmp/go-build4204010061/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/glassway/memory/ src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt +# /tmp/go-build4146048213/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/glassway/memory/ src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt SPD_SOURCES = SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 0(0b0000) Parts = K3KL8L80CM-MGCT @@ -10,3 +10,4 @@ SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 3(0b0011) Parts = H9JCNNNBK3MLYR-N6E SPD_SOURCES += spd/lp5/set-0/spd-6.hex # ID = 4(0b0100) Parts = H58G66AK6BX070 SPD_SOURCES += spd/lp5/set-0/spd-8.hex # ID = 5(0b0101) Parts = K3KL9L90CM-MGCT +SPD_SOURCES += spd/lp5/set-0/spd-11.hex # ID = 6(0b0110) Parts = H58G56CK8BX146 diff --git a/src/mainboard/google/brya/variants/glassway/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/glassway/memory/dram_id.generated.txt index 424f320..7f1ca2b 100644 --- a/src/mainboard/google/brya/variants/glassway/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/glassway/memory/dram_id.generated.txt @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# /tmp/go-build4204010061/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/glassway/memory/ src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt +# /tmp/go-build4146048213/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/glassway/memory/ src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt DRAM Part Name ID to assign K3KL8L80CM-MGCT 0 (0000) @@ -11,3 +11,4 @@ H58G66AK6BX070 4 (0100) K3KL9L90CM-MGCT 5 (0101) K3LKBKB0BM-MGCP 2 (0010) +H58G56CK8BX146 6 (0110) diff --git a/src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt index a7e8120..796d10a 100644 --- a/src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/glassway/memory/mem_parts_used.txt @@ -16,3 +16,4 @@ H58G66AK6BX070 K3KL9L90CM-MGCT K3LKBKB0BM-MGCP +H58G56CK8BX146 -- To view, visit https://review.coreboot.org/c/coreboot/+/87252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d6bbb778e75f6f32012e0cf6f427101d3616246 Gerrit-Change-Number: 87252 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/guren: Add Stylus Pen Function
by Subrata Banik (Code Review) 13 Apr '25

13 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87235?usp=email ) Change subject: mb/google/brya/var/guren: Add Stylus Pen Function ...................................................................... mb/google/brya/var/guren: Add Stylus Pen Function New Stylus Pen for MAXEYE/0585501490 module for Guren360 project. 1. Add STYLUS fw_config setting 2. Enable stylus device settings 3. Disable the stylus GPIO pins based on fw_config BUG=b:406168542 BRANCH=firmware-nissa-15217.B TEST=1. emerge-nissa coreboot 2. Confirm command evtest for stylus PRP0001:00 and workable. Change-Id: I46d679d29b35d0f4fc70d63b74975d3bdfc40b7b Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87235 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/guren/fw_config.c M src/mainboard/google/brya/variants/guren/gpio.c M src/mainboard/google/brya/variants/guren/overridetree.cb 3 files changed, 32 insertions(+), 4 deletions(-) Approvals: Daniel Peng: Looks good to me, but someone else must approve Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brya/variants/guren/fw_config.c b/src/mainboard/google/brya/variants/guren/fw_config.c index efebee2..63e55a3 100644 --- a/src/mainboard/google/brya/variants/guren/fw_config.c +++ b/src/mainboard/google/brya/variants/guren/fw_config.c @@ -27,6 +27,13 @@ PAD_NC(GPP_H23, NONE), }; +static const struct pad_config stylus_disable_pads[] = { + /* F13 : SOC_PEN_DETECT_R_ODL */ + PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), + /* F15 : SOC_PEN_DETECT_ODL */ + PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), +}; + void fw_config_gpio_padbased_override(struct pad_config *padbased_table) { if (!fw_config_probe(FW_CONFIG(DB_USB, DB_HDMI_LTE)) @@ -44,4 +51,10 @@ gpio_padbased_override(padbased_table, lte_disable_pads, ARRAY_SIZE(lte_disable_pads)); } + + if (fw_config_probe(FW_CONFIG(STYLUS, STYLUS_ABSENT))) { + printk(BIOS_INFO, "Disable Stylus GPIO pins.\n"); + gpio_padbased_override(padbased_table, stylus_disable_pads, + ARRAY_SIZE(stylus_disable_pads)); + } } diff --git a/src/mainboard/google/brya/variants/guren/gpio.c b/src/mainboard/google/brya/variants/guren/gpio.c index 0c46265..b5017c6 100644 --- a/src/mainboard/google/brya/variants/guren/gpio.c +++ b/src/mainboard/google/brya/variants/guren/gpio.c @@ -26,10 +26,6 @@ PAD_CFG_GPI(GPP_E5, NONE, DEEP), /* F12 : WWAN_RST_L */ PAD_CFG_GPO_LOCK(GPP_F12, 1, LOCK_CONFIG), - /* F13 : GSXSLOAD ==> NC */ - PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), - /* F15 : GSXSRESET# ==> NC */ - PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), /* H19 : SOC_I2C_SUB_INT_ODL */ PAD_CFG_GPI_APIC(GPP_H19, NONE, PLTRST, LEVEL, NONE), /* H22 : IMGCLKOUT3 ==> NC */ diff --git a/src/mainboard/google/brya/variants/guren/overridetree.cb b/src/mainboard/google/brya/variants/guren/overridetree.cb index 3306e8a..8c50fd7 100644 --- a/src/mainboard/google/brya/variants/guren/overridetree.cb +++ b/src/mainboard/google/brya/variants/guren/overridetree.cb @@ -21,6 +21,10 @@ option WIFI_SAR_ID_INTEL_CONVERTIBLE 0 option WIFI_SAR_ID_INTEL_CLAMSHELL 1 end + field STYLUS 15 + option STYLUS_ABSENT 0 + option STYLUS_PRESENT 1 + end field WFC 17 18 option WFC_ABSENT 0 option WFC_PRESENT 1 @@ -389,6 +393,21 @@ probe TOUCHSCREEN_SOURCE TOUCHSCREEN_FTSC1000 end end + + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_F13)" + register "key.wake_gpe" = "GPE0_DW2_15" + register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on + probe STYLUS STYLUS_PRESENT + end + end end #I2C1 device ref i2c2 on chip drivers/i2c/sx9324 -- To view, visit https://review.coreboot.org/c/coreboot/+/87235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46d679d29b35d0f4fc70d63b74975d3bdfc40b7b Gerrit-Change-Number: 87235 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/guren: Add touch screen FTSC1000 support
by Subrata Banik (Code Review) 13 Apr '25

13 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87238?usp=email ) Change subject: mb/google/nissa/var/guren: Add touch screen FTSC1000 support ...................................................................... mb/google/nissa/var/guren: Add touch screen FTSC1000 support New Touchscreen function for Guren project. Touchscreen panel: HKO RB116AS01-2, and set TOUCHSCREEN_FTSC1000 to value "3". BUG=b:391281767 BRANCH=firmware-nissa-15217.B TEST=1. emerge-nissa coreboot chromeos-bootimage 2. Confirm command evtest and touchscreen function is workable. Change-Id: Icfe5f57c69d1bd98e0852a1aa3baed8c1444e4d9 Signed-off-by: Brian Hsu <Brian_Hsu(a)pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87238 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/guren/overridetree.cb 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Daniel Peng: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/guren/overridetree.cb b/src/mainboard/google/brya/variants/guren/overridetree.cb index 0e10689..3306e8a 100644 --- a/src/mainboard/google/brya/variants/guren/overridetree.cb +++ b/src/mainboard/google/brya/variants/guren/overridetree.cb @@ -29,6 +29,7 @@ option TOUCHSCREEN_UNPROVISIONED 0 option TOUCHSCREEN_ELAN0001 1 option TOUCHSCREEN_ILIT2901 2 + option TOUCHSCREEN_FTSC1000 3 end end @@ -369,6 +370,25 @@ probe TOUCHSCREEN_SOURCE TOUCHSCREEN_ILIT2901 end end + + chip drivers/i2c/hid + register "generic.hid" = ""FTSC1000"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" + register "generic.reset_delay_ms" = "150" + register "generic.reset_off_delay_ms" = "5" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" + register "generic.stop_delay_ms" = "30" + register "generic.stop_off_delay_ms" = "10" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" + register "generic.enable_delay_ms" = "45" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 38 on + probe TOUCHSCREEN_SOURCE TOUCHSCREEN_FTSC1000 + end + end end #I2C1 device ref i2c2 on chip drivers/i2c/sx9324 -- To view, visit https://review.coreboot.org/c/coreboot/+/87238?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icfe5f57c69d1bd98e0852a1aa3baed8c1444e4d9 Gerrit-Change-Number: 87238 Gerrit-PatchSet: 6 Gerrit-Owner: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Li <david_li(a)pegatron.corp-partner.google.com> Gerrit-CC: Samuel Chen <samuel_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025