Attention is currently required from: Carlos López, Julius Werner, Maximilian Brune, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Reviewer: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:00:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Held, Fred Reitberger, Intel coreboot Reviewers, Jason Glenesk, Matt DeVillier, Maximilian Brune.
Benjamin Doron has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86587?usp=email )
Change subject: treewide: Rename PM4LE -> PML4E
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86587?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I730235beea69b3720f080bbade083c2eeed26587
Gerrit-Change-Number: 86587
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:51:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Carlos López, Maximilian Brune, Philipp Hug, ron minnich.
Joel Bueno has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
Patch Set 5:
(2 comments)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85800/comment/d792f9c6_0da8a51d?us… :
PS4, Line 87: uint32_t high = be32dec(ptr);
> nit: […]
Should now be done as per request. Thanks!
https://review.coreboot.org/c/coreboot/+/85800/comment/f36d702a_8681939e?us… :
PS4, Line 95: uint32_t high = be32dec(ptr);
> same here
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Reviewer: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Attention is currently required from: Cliff Huang, Lance Zhao, Sean Rhodes, Tim Wawrzynczak.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86513?usp=email )
Change subject: acpi: Fix incorrect TPM2 table generation for CRB_TPM
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86513?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I153779aa1f3d84ffeb694543f9da1d09b120f98f
Gerrit-Change-Number: 86513
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:49:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Carlos López, Joel Bueno, Maximilian Brune, Philipp Hug, ron minnich.
Hello Carlos López, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85800?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Maximilian Brune, Verified+1 by build bot (Jenkins)
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
commonlib/device_tree: fix 64-bit misaligned member access
On RISC-V (or any other platform), pointers to 64-bit values in the
device tree (spanning 2 cells) are not guaranteed to be aligned to a
64-bit boundary, which can cause a load access fault on some
platforms (see [0]). This is observed with the default Spike device
tree. Thus, perform two 32-bit loads instead.
[0] https://lore.kernel.org/qemu-devel/41c1c574-da5c-654a-f993-4b87e089380e@red…
Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Signed-off-by: joel.bueno <joel.bueno(a)openchip.com>
---
M src/commonlib/device_tree.c
1 file changed, 14 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/85800/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Reviewer: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Attention is currently required from: Michał Żygowski, Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86369?usp=email )
Change subject: drivers/crb: Always generate TPM ACPI Tables
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86369?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I594bf25a207b809c1ae2632eb1aea0d0fb6df35e
Gerrit-Change-Number: 86369
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:48:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86188?usp=email )
Change subject: mb/starlabs/*: Unify IO genx_dec configuration across all boards
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86188?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I614b4cbf6ad502e69f463d71a2536b017c483907
Gerrit-Change-Number: 86188
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:46:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Carlos López, Joel Bueno, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85800/comment/a58e836a_eaa95a6d?us… :
PS4, Line 87: uint32_t high = be32dec(ptr);
nit:
could you add a comment above here like:
```
FDT spec only guarantees a 4 byte alignment.
```
https://review.coreboot.org/c/coreboot/+/85800/comment/3ee696bd_f9b61376?us… :
PS4, Line 95: uint32_t high = be32dec(ptr);
same here
--
To view, visit https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Reviewer: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Joel Bueno <joel.bueno(a)openchip.com>
Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes