Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86337?usp=email )
(
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: ec/google/chromeec: Implement early power off
......................................................................
ec/google/chromeec: Implement early power off
This commit implements the `google_chromeec_do_early_poweroff`
function for the Chrome EC. This allows the system to power
off before memory initialization by triggering an EC reset
with EC_REBOOT_COLD_AP_OFF.
BUG=b:339673254
TEST=Able to build and boot google/brox.
Change-Id: Ia53469feb2a020b38a5414728159b09c86c7e32d
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86337
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Caveh Jalali <caveh(a)chromium.org>
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Karthik Ramasubramanian: Looks good to me, approved
build bot (Jenkins): Verified
Caveh Jalali: Looks good to me, but someone else must approve
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 2e8961f..cc581ff 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -8,6 +8,7 @@
#include <device/device.h>
#include <device/path.h>
#include <elog.h>
+#include <halt.h>
#include <rtc.h>
#include <security/vboot/vboot_common.h>
#include <stdlib.h>
@@ -1669,3 +1670,9 @@
return false;
}
+
+void google_chromeec_do_early_poweroff(void)
+{
+ google_chromeec_reboot(EC_REBOOT_COLD_AP_OFF, 0);
+ halt();
+}
diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index b11b7a8..08d4f27 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -471,6 +471,14 @@
*/
bool google_chromeec_is_battery_present(void);
+/*
+ * Performs early power off.
+ *
+ * This function handles the necessary steps to initiate an early power off
+ * sequence.
+ */
+void google_chromeec_do_early_poweroff(void);
+
/**
* Determine if the UCSI stack is currently active.
*
--
To view, visit https://review.coreboot.org/c/coreboot/+/86337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia53469feb2a020b38a5414728159b09c86c7e32d
Gerrit-Change-Number: 86337
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Lawrence Chang, Nick Vaccaro.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86376?usp=email )
Change subject: mb/google/nissa/var/meliks: Update memory DQ/DQS map
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/meliks/memory.c:
https://review.coreboot.org/c/coreboot/+/86376/comment/8151a23c_384a24d0?us… :
PS1, Line 71: .UserBd = BOARD_TYPE_MOBILE,
@Lawrence, is it correct for meliks?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae3f2c65b4d1004d1d9ebf76b099fc7f50e8365f
Gerrit-Change-Number: 86376
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 13 Feb 2025 04:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, SH Kim.
Subrata Banik has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86377?usp=email )
Change subject: mb/google/nissa/var/meliks: Update overridetree.cb
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86377?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd6dfbeca7276dbacd72f9145ed7119566c8faef
Gerrit-Change-Number: 86377
Gerrit-PatchSet: 2
Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 13 Feb 2025 02:09:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Gavin Liu, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/blobs/+/86382?usp=email )
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/86382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Gerrit-Change-Number: 86382
Gerrit-PatchSet: 5
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Thu, 13 Feb 2025 01:44:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Jarried Lin, Yidi Lin, Yu-Ping Wu.
Gavin Liu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/blobs/+/86382?usp=email )
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/blobs/+/86382/comment/78628ec6_a42f6484?usp=e… :
PS3, Line 9: The static library that contains Mediatek private drivers in
: ARM-Trusted-Firmware
> The libbl31. […]
Done
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86382/comment/4a5c2931_a384c30f?usp=e… :
PS3, Line 297: linked with `bl31.elf`.
> move to next line
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/86382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Gerrit-Change-Number: 86382
Gerrit-PatchSet: 5
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Thu, 13 Feb 2025 01:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Hello Jarried Lin, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/86382?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
......................................................................
soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
The libbl31.a is a static library that contains MediaTek proprietary
drivers for ARM trusted firmware. The feature includes:
- UFS driver
- SMPU (Security Memory Protection Unit) driver
- SLBC driver
- CPU QOS driver
- MMinfra driver
- SMMU SID driver
BRANCH=rauru
BUG=b:317009620
TEST=Build pass with static library. Boot ok.
Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/libbl31.a
A soc/mediatek/mt8196/libbl31.a.md5
A soc/mediatek/mt8196/libbl31_release_note.txt
4 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/82/86382/5
--
To view, visit https://review.coreboot.org/c/blobs/+/86382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Gerrit-Change-Number: 86382
Gerrit-PatchSet: 5
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/blobs/+/86382?usp=email )
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/blobs/+/86382/comment/096ff7f5_b0e7c5d2?usp=e… :
PS3, Line 9: The static library that contains Mediatek private drivers in
: ARM-Trusted-Firmware
The libbl31.a is a static library that contains MediaTek proprietary drivers for ARM trusted firmware. The feature includes:
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86382/comment/b8302b03_a3b53f73?usp=e… :
PS3, Line 297: linked with `bl31.elf`.
move to next line
--
To view, visit https://review.coreboot.org/c/blobs/+/86382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Gerrit-Change-Number: 86382
Gerrit-PatchSet: 3
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Thu, 13 Feb 2025 01:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Hello Jarried Lin, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/86382?usp=email
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
......................................................................
soc/mediatek/mt8196: Add libbl31.a version 16174.21.0
The static library that contains MediaTek private drivers in
ARM-Trusted-Firmware:
- UFS driver
- SMPU (Security Memory Protection Unit) driver
- SLBC driver
- CPU QOS driver
- MMinfra driver
- SMMU SID driver
BRANCH=rauru
BUG=b:317009620
TEST=Build pass with static library. Boot ok.
Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/libbl31.a
A soc/mediatek/mt8196/libbl31.a.md5
A soc/mediatek/mt8196/libbl31_release_note.txt
4 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/82/86382/4
--
To view, visit https://review.coreboot.org/c/blobs/+/86382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ided5b662464be64cb8d9db938eb513ac7b1d6e18
Gerrit-Change-Number: 86382
Gerrit-PatchSet: 4
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>