coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: drivers/qemu/cirrus: Allow building for non-x86 architectures
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak, Paul Menzel. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82065?usp=email ) Change subject: drivers/qemu/cirrus: Allow building for non-x86 architectures ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82065/comment/4b3ae96b_e0a00e43?us… : PS2, Line 20: architectrures > architectures Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I168d3bf9b27d5eefa1d4844b861d73ec8437ee16 Gerrit-Change-Number: 82065 Gerrit-PatchSet: 3 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 19:15:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: drivers/qemu/cirrus: Allow building for non-x86 architectures
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak. David Hendricks has uploaded a new patch set (#3) to the change originally created by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82065?usp=email ) Change subject: drivers/qemu/cirrus: Allow building for non-x86 architectures ...................................................................... drivers/qemu/cirrus: Allow building for non-x86 architectures The Cirrus display driver uses port I/O functions and VGA support code for initialization, so it could only have been built on x86 so far, but the device can be used just fine on other architectures on the QEMU side as long as the emulated platform supports PCI. Previous commits add port I/O functions and enable building VGA code for more architectures including ARM* and RISC-V, which should allow this driver to be successfully built and used on these as well. Allow the Cirrus display driver to be built for non-x86 QEMU boards by changing the Kconfig dependencies. Make VGA text framebuffer support depend on x86, because it isn't usable at the standard 0xB8000 address on other architectures. Add a dependency on PCI since this is a PCI device and vexpress-a9 (qemu-armv7) doesn't have the (emulated) hardware for PCI. Change-Id: I168d3bf9b27d5eefa1d4844b861d73ec8437ee16 Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> --- M src/drivers/emulation/qemu/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/82065/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I168d3bf9b27d5eefa1d4844b861d73ec8437ee16 Gerrit-Change-Number: 82065 Gerrit-PatchSet: 3 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>

1 0

[XS] Change in coreboot[main]: drivers/pc80/vga: Allow building for non-x86 architectures
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak, Jérémy Compostella. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82064?usp=email ) Change subject: drivers/pc80/vga: Allow building for non-x86 architectures ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic3199fda500c51aa3261cd9eff9a5b0b052fd742 Gerrit-Change-Number: 82064 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 19:09:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/pc80/vga/vga: Move big buffer for vga_write_text out of stack
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak, Jérémy Compostella. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82063?usp=email ) Change subject: drivers/pc80/vga/vga: Move big buffer for vga_write_text out of stack ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icbc6da144988060532d686d199afd7f26cbc6679 Gerrit-Change-Number: 82063 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 19:08:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/qemu/cirrus: Add missing arch/io.h include
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82062?usp=email ) Change subject: drivers/qemu/cirrus: Add missing arch/io.h include ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I84c76e6e723c776f45d40d98029e33adb57005c0 Gerrit-Change-Number: 82062 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 19:03:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/qemu/bochs: Allow building for non-x86 architectures
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Patrick Rudolph. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80376?usp=email ) Change subject: drivers/qemu/bochs: Allow building for non-x86 architectures ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f72d7ea13e54ecf89d067394c02b572c5f92d24 Gerrit-Change-Number: 80376 Gerrit-PatchSet: 3 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 19:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/qemu/bochs: Use arch-independent data port
by David Hendricks (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Alper Nebi Yasak. David Hendricks has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/82061?usp=email ) Change subject: drivers/qemu/bochs: Use arch-independent data port ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82061?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I899beb742d42c26f3e57023f05ff459094fce5f1 Gerrit-Change-Number: 82061 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:57:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation/mainboard/lenovo: Add ThinkCentre M710s
by Matt DeVillier (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Angel Pons, Nicholas Chin, Nicholas Sudsgaard. Matt DeVillier has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email ) Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I90311257a28bd463712c4d43f8b83baa745509cc Gerrit-Change-Number: 80411 Gerrit-PatchSet: 24 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:50:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by Alicja Michalska (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Hendricks, Felix Held, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Matt DeVillier, Patrick Rudolph, Shuo Liu, Tim Chu, Vasiliy Khoruzhick, yuchi.chen(a)intel.com. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email ) Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Removed "always" - nitpick during code review meeting by Felix. -- To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Gerrit-Change-Number: 86131 Gerrit-PatchSet: 9 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: Support smmstore in RW_LEGACY
by Matt DeVillier (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Vladimir Serbinenko. Matt DeVillier has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/81507?usp=email ) Change subject: Support smmstore in RW_LEGACY ...................................................................... Patch Set 3: (1 comment) File src/drivers/smmstore/store.c: https://review.coreboot.org/c/coreboot/+/81507/comment/e6979518_422ea9f3?us… : PS3, Line 60: "smmstore.bin" do we want to hardcode the filename here? -- To view, visit https://review.coreboot.org/c/coreboot/+/81507?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86a617782f187adcce4429ea41ac40a9df58d6d3 Gerrit-Change-Number: 81507 Gerrit-PatchSet: 3 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:42:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025