coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[M] Change in coreboot[main]: mb/google/nissa: Create meliks variant
by Subrata Banik (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, SH Kim. Subrata Banik has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86373?usp=email ) Change subject: mb/google/nissa: Create meliks variant ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Anything wrong with this CL? Or Jenkins will trigger build again later automatically? Please try to take a look at https://qa.coreboot.org/job/coreboot-gerrit/273260/testReport/junit/(root)/… -- To view, visit https://review.coreboot.org/c/coreboot/+/86373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff5e27ef06a44976c2724751de0f9c6d5cf6eaaf Gerrit-Change-Number: 86373 Gerrit-PatchSet: 6 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 04:12:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/nissa: Create meliks variant
by SH Kim (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86373?usp=email ) Change subject: mb/google/nissa: Create meliks variant ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Anything wrong with this CL? Or Jenkins will trigger build again later automatically? -- To view, visit https://review.coreboot.org/c/coreboot/+/86373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff5e27ef06a44976c2724751de0f9c6d5cf6eaaf Gerrit-Change-Number: 86373 Gerrit-PatchSet: 6 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 03:54:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Add Fn key scancode
by Dtrain Hsu (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Dtrain Hsu has posted comments on this change by Dtrain Hsu. ( https://review.coreboot.org/c/coreboot/+/86474?usp=email ) Change subject: mb/trulo/var/uldrenite: Add Fn key scancode ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Please also add order the Kconfig in comment. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Gerrit-Change-Number: 86474 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 03:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Add Fn key scancode
by Dtrain Hsu (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86474?usp=email to look at the new patch set (#3). Change subject: mb/trulo/var/uldrenite: Add Fn key scancode ...................................................................... mb/trulo/var/uldrenite: Add Fn key scancode The Fn key on uldrenite emits a scancode of 94 (0x5e) and order the Kconfig. BUG=b:394749952 TEST=fn + top row (F1~F12) keys work fine Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/86474/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Gerrit-Change-Number: 86474 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Add Fn key scancode
by Eric Lai (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Eric Lai has posted comments on this change by Dtrain Hsu. ( https://review.coreboot.org/c/coreboot/+/86474?usp=email ) Change subject: mb/trulo/var/uldrenite: Add Fn key scancode ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Please also add order the Kconfig in comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/86474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Gerrit-Change-Number: 86474 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 03:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Add Fn key scancode
by Dtrain Hsu (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86474?usp=email to look at the new patch set (#2). Change subject: mb/trulo/var/uldrenite: Add Fn key scancode ...................................................................... mb/trulo/var/uldrenite: Add Fn key scancode The Fn key on uldrenite emits a scancode of 94 (0x5e). BUG=b:394749952 TEST=fn + top row (F1~F12) keys work fine Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/86474/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Gerrit-Change-Number: 86474 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: b/trulo/var/uldrenite: Add Fn key scancode
by Dtrain Hsu (Code Review) 17 Feb '25

17 Feb '25

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86474?usp=email ) Change subject: b/trulo/var/uldrenite: Add Fn key scancode ...................................................................... b/trulo/var/uldrenite: Add Fn key scancode The Fn key on uldrenite emits a scancode of 94 (0x5e). BUG=b:394749952 TEST=fn + top row (F1~F12) keys work fine Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/86474/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 213d499..d48cba1 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -640,12 +640,13 @@ select BOARD_GOOGLE_BASEBOARD_TRULO select BOARD_ROMSIZE_KB_32768 select CHROMEOS_WIFI_SAR if CHROMEOS - select SOC_INTEL_TCSS_USE_PDC_PMC_USBC_MUX_CONFIGURATION + select DRIVERS_WWAN_FM350GL + select ENFORCE_MEM_CHANNEL_DISABLE select HAVE_PCIE_WWAN select HAVE_WWAN_POWER_SEQUENCE - select DRIVERS_WWAN_FM350GL + select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD select SOC_INTEL_COMMON_BLOCK_HDA_VERB - select ENFORCE_MEM_CHANNEL_DISABLE + select SOC_INTEL_TCSS_USE_PDC_PMC_USBC_MUX_CONFIGURATION config BOARD_GOOGLE_VELL select BOARD_GOOGLE_BASEBOARD_BRYA -- To view, visit https://review.coreboot.org/c/coreboot/+/86474?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Gerrit-Change-Number: 86474 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/ovis/var/deku: Update CPU power limit for PL1 min/max
by Tony Huang (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub "Kuba" Czapiga, Kapil Porwal, Subrata Banik, Tarun. Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86473?usp=email ) Change subject: mb/google/ovis/var/deku: Update CPU power limit for PL1 min/max ...................................................................... mb/google/ovis/var/deku: Update CPU power limit for PL1 min/max Change PL1 min/max based on thermal team validation result. PL1_min = 20W PL1_max = 33W BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: Ie0fc882ccd26e32f3d5719480511125a9af1d014 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb M src/mainboard/google/rex/variants/deku/ramstage.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/86473/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 2fefcb0..a66640f 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -99,8 +99,8 @@ ## Power Limits Control register "controls.power_limits" = "{ .pl1 = { - .min_power = 28000, - .max_power = 28000, + .min_power = 20000, + .max_power = 33000, .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 32 * MSECS_PER_SEC, .granularity = 200, diff --git a/src/mainboard/google/rex/variants/deku/ramstage.c b/src/mainboard/google/rex/variants/deku/ramstage.c index 871313c..3932faf 100644 --- a/src/mainboard/google/rex/variants/deku/ramstage.c +++ b/src/mainboard/google/rex/variants/deku/ramstage.c @@ -15,8 +15,8 @@ .mch_id = PCI_DID_INTEL_MTL_P_ID_1, .cpu_tdp = 28, .power_limits_index = MTL_P_682_482_CORE, - .pl1_min_power = 19000, - .pl1_max_power = 28000, + .pl1_min_power = 20000, + .pl1_max_power = 33000, .pl2_min_power = 64000, .pl2_max_power = 64000, .pl4_power = 120000 @@ -25,8 +25,8 @@ .mch_id = PCI_DID_INTEL_MTL_P_ID_3, .cpu_tdp = 28, .power_limits_index = MTL_P_682_482_CORE, - .pl1_min_power = 19000, - .pl1_max_power = 28000, + .pl1_min_power = 20000, + .pl1_max_power = 33000, .pl2_min_power = 64000, .pl2_max_power = 64000, .pl4_power = 120000 -- To view, visit https://review.coreboot.org/c/coreboot/+/86473?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0fc882ccd26e32f3d5719480511125a9af1d014 Gerrit-Change-Number: 86473 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Decrease TDP PL1 value from 33W to 20 W
by Tony Huang (Code Review) 17 Feb '25

17 Feb '25

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86472?usp=email ) Change subject: mb/google/ovis/var/deku: Decrease TDP PL1 value from 33W to 20 W ...................................................................... mb/google/ovis/var/deku: Decrease TDP PL1 value from 33W to 20 W Based on thermal team validation result. Decrease tdp_pl1_override from 33W to 20W. BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: Iad20f7bf2c3ce93f234d4b53f94c6bcdfd5f5720 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/86472/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 3b4dce9..2fefcb0 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -31,7 +31,7 @@ register "tcc_offset" = "12" register "power_limits_config[MTL_P_682_482_CORE]" = "{ - .tdp_pl1_override = 33, + .tdp_pl1_override = 20, .tdp_pl2_override = 64, .tdp_pl4 = 120, }" -- To view, visit https://review.coreboot.org/c/coreboot/+/86472?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad20f7bf2c3ce93f234d4b53f94c6bcdfd5f5720 Gerrit-Change-Number: 86472 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set SYSTEM_TYPE_MINIPC for brask baseboard boards
by Eric Lai (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik. Eric Lai has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86469?usp=email ) Change subject: mb/google/brya: Set SYSTEM_TYPE_MINIPC for brask baseboard boards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86469?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I133a26223ad204dfad67e136cf342d2fb2a7205e Gerrit-Change-Number: 86469 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 02:38:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025