coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: Kconfig: Rework SYSTEM_TYPE_XX to better map to SMBIOS
by Eric Lai (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik. Eric Lai has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86454?usp=email ) Change subject: Kconfig: Rework SYSTEM_TYPE_XX to better map to SMBIOS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a35101ccc60daf4863568216ef145c9c701140b Gerrit-Change-Number: 86454 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 17 Feb 2025 02:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel
by Eric Lai (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik. Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86393?usp=email ) Change subject: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d920acb95275fbf72b83b822eddc41829511626 Gerrit-Change-Number: 86393 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 17 Feb 2025 02:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: sb/intel/common: Add GPIO serial blink console support
by Keith Hui (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Nicholas Chin. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/86390?usp=email ) Change subject: sb/intel/common: Add GPIO serial blink console support ...................................................................... Patch Set 2: (4 comments) File Documentation/technotes/console.md: https://review.coreboot.org/c/coreboot/+/86390/comment/73cc7051_e7008bd7?us… : PS1, Line 172: [Intel 7-series PCH](https://www.intel.com/content/dam/www/public/us/en/documents/datasheet… : datasheet > It would be good to mention the Intel document number for this (326776) as these links often break. Done File src/console/Kconfig: https://review.coreboot.org/c/coreboot/+/86390/comment/7d254c3f_fd2bbd1b?us… : PS1, Line 399: int "GPIO output pin (0-31)" > Could use a `range` instead (https://doc.coreboot.org/getting_started/kconfig.html). Done File src/southbridge/intel/common/gpio.c: https://review.coreboot.org/c/coreboot/+/86390/comment/bab990eb_605031f9?us… : PS1, Line 47: /* Temporarily set the GPIO to input, enable serial blink, then change it to output. > https://doc.coreboot.org/contributing/coding_style. […] Done https://review.coreboot.org/c/coreboot/+/86390/comment/ce74953e_afc69a80?us… : PS1, Line 195: CONSOLE_INTEL_GPSB) > `console/` seems to be for backend independent console code, so it wouldn't go there. […] Spun off into its own C file, but I left the code in sb/intel/common for proximity and convenience. -- To view, visit https://review.coreboot.org/c/coreboot/+/86390?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0741142fe21eba4989d28b96e795d3bfa3085466 Gerrit-Change-Number: 86390 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Feb 2025 02:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>

1 0

[M] Change in coreboot[main]: sb/intel/common: Add GPIO serial blink console support
by Keith Hui (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Keith Hui. Hello Intel coreboot Reviewers, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86390?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: sb/intel/common: Add GPIO serial blink console support ...................................................................... sb/intel/common: Add GPIO serial blink console support Intel ICH/PCHs from ICH8 onwards have the ability to blink arbitrary messages (in this case, our console) onto a GPIO line. Idea is to place an optical sensor over an LED controlled by the GPIO line with serial blink enabled to "watch" the blinking and extract the messages. Add support and documentation for serializing coreboot console over this channel. Change-Id: I0741142fe21eba4989d28b96e795d3bfa3085466 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M Documentation/technotes/console.md M src/console/Kconfig M src/console/console.c M src/include/console/console.h A src/include/console/gpsb.h M src/southbridge/intel/common/Makefile.mk M src/southbridge/intel/common/gpio.c M src/southbridge/intel/common/gpio.h A src/southbridge/intel/common/gpsb.c 9 files changed, 228 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/86390/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86390?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0741142fe21eba4989d28b96e795d3bfa3085466 Gerrit-Change-Number: 86390 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/byte: Set SYSTEM_TYPE_MINIPC
by Matt DeVillier (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86471?usp=email ) Change subject: mb/starlabs/byte: Set SYSTEM_TYPE_MINIPC ...................................................................... mb/starlabs/byte: Set SYSTEM_TYPE_MINIPC Ensures SMBIOS enclosure type set properly. Change-Id: I65ca75a57dbc4a9251316d48bf660dd631c716dd Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/86471/1 diff --git a/src/mainboard/starlabs/byte_adl/Kconfig b/src/mainboard/starlabs/byte_adl/Kconfig index 77a4ea4..51fa7aa 100644 --- a/src/mainboard/starlabs/byte_adl/Kconfig +++ b/src/mainboard/starlabs/byte_adl/Kconfig @@ -10,6 +10,7 @@ select INTEL_LPSS_UART_FOR_CONSOLE select NO_UART_ON_SUPERIO select SOC_INTEL_COMMON_BLOCK_HDA_VERB + select SYSTEM_TYPE_MINIPC select VALIDATE_INTEL_DESCRIPTOR config BOARD_STARLABS_BYTE_ADL -- To view, visit https://review.coreboot.org/c/coreboot/+/86471?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65ca75a57dbc4a9251316d48bf660dd631c716dd Gerrit-Change-Number: 86471 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: mb/purism/librem_cnl: Set SYSTEM_TYPE_MINIPC for Librem mini v1/v2
by Matt DeVillier (Code Review) 17 Feb '25

17 Feb '25

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86470?usp=email ) Change subject: mb/purism/librem_cnl: Set SYSTEM_TYPE_MINIPC for Librem mini v1/v2 ...................................................................... mb/purism/librem_cnl: Set SYSTEM_TYPE_MINIPC for Librem mini v1/v2 Ensures SMBIOS enslosure type set properly. Change-Id: I047e6319b70f2747796869151bf361afe4c3e961 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/purism/librem_cnl/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/86470/1 diff --git a/src/mainboard/purism/librem_cnl/Kconfig b/src/mainboard/purism/librem_cnl/Kconfig index ab6a67f..a718678 100644 --- a/src/mainboard/purism/librem_cnl/Kconfig +++ b/src/mainboard/purism/librem_cnl/Kconfig @@ -20,6 +20,7 @@ select HAVE_OPTION_TABLE select SOC_INTEL_WHISKEYLAKE select SUPERIO_ITE_IT8528E + select SYSTEM_TYPE_MINIPC config BOARD_PURISM_LIBREM_MINI_V2 select BOARD_PURISM_BASEBOARD_LIBREM_CNL @@ -27,6 +28,7 @@ select HAVE_OPTION_TABLE select SOC_INTEL_COMETLAKE_1 select SUPERIO_ITE_IT8528E + select SYSTEM_TYPE_MINIPC config BOARD_PURISM_LIBREM_14 select BOARD_PURISM_BASEBOARD_LIBREM_CNL -- To view, visit https://review.coreboot.org/c/coreboot/+/86470?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I047e6319b70f2747796869151bf361afe4c3e961 Gerrit-Change-Number: 86470 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/brya: Set SYSTEM_TYPE_MINIPC for brask baseboard boards
by Matt DeVillier (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86469?usp=email ) Change subject: mb/google/brya: Set SYSTEM_TYPE_MINIPC for brask baseboard boards ...................................................................... mb/google/brya: Set SYSTEM_TYPE_MINIPC for brask baseboard boards Brask devices are all Chromeboxes, so select SYSTEM_TYPE_MINIPC to ensure the SMBIOS enclosure type is set correctly. Change-Id: I133a26223ad204dfad67e136cf342d2fb2a7205e Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/86469/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index a258a9c..403153b 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -68,6 +68,7 @@ select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE select SOC_INTEL_ALDERLAKE_PCH_P + select SYSTEM_TYPE_MINIPC select TPM_GOOGLE_CR50 config BOARD_GOOGLE_BASEBOARD_HADES -- To view, visit https://review.coreboot.org/c/coreboot/+/86469?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I133a26223ad204dfad67e136cf342d2fb2a7205e Gerrit-Change-Number: 86469 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE
by Matt DeVillier (Code Review) 17 Feb '25

17 Feb '25

Attention is currently required from: Jason Nien, Martin Roth. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86468?usp=email ) Change subject: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE ...................................................................... mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE Frostflow is a 2-in-1 device, this sets the SMBIOS enclosure type properly. Change-Id: I6c3306270cbc80bb55fb536a1fc51a5546287649 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/86468/1 diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index dc28fbc..756db5f 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -11,6 +11,7 @@ select DRIVERS_GENESYSLOGIC_GL9755 select FEATURE_TABLET_MODE_DPTC select SOC_AMD_COMMON_BLOCK_ACPI_DPTC + select SYSTEM_TYPE_CONVERTIBLE config BOARD_GOOGLE_MARKARTH select BOARD_GOOGLE_BASEBOARD_SKYRIM @@ -67,7 +68,7 @@ select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP select SOC_AMD_COMMON_BLOCK_USE_ESPI select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP - select SYSTEM_TYPE_LAPTOP + select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CONVERTIBLE select TPM_GOOGLE_TI50 config DEVICETREE -- To view, visit https://review.coreboot.org/c/coreboot/+/86468?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c3306270cbc80bb55fb536a1fc51a5546287649 Gerrit-Change-Number: 86468 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE
by Matt DeVillier (Code Review) 17 Feb '25

17 Feb '25

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86467?usp=email ) Change subject: mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE ...................................................................... mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE Cave is a 2-in-1 device, this sets the SMBIOS enclosure type properly. Change-Id: I8f2ec82c97676aa315c18286b5e2eb94d46004ec Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/86467/1 diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 57d54d0..287d9383 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -20,7 +20,7 @@ select MEMORY_MAPPED_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_SKYLAKE - select SYSTEM_TYPE_LAPTOP + select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CONVERTIBLE config BOARD_GOOGLE_ASUKA select BOARD_GOOGLE_BASEBOARD_GLADOS @@ -43,6 +43,7 @@ select INTEL_GMA_HAVE_VBT select MAINBOARD_NO_FSP_GOP select NHLT_MAX98357 if INCLUDE_NHLT_BLOBS + select SYSTEM_TYPE_CONVERTIBLE config BOARD_GOOGLE_CHELL select BOARD_GOOGLE_BASEBOARD_GLADOS -- To view, visit https://review.coreboot.org/c/coreboot/+/86467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f2ec82c97676aa315c18286b5e2eb94d46004ec Gerrit-Change-Number: 86467 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/amd/cezanne/acpi: Add ACP MSG0 method
by Matt DeVillier (Code Review) 16 Feb '25

16 Feb '25

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Matt DeVillier has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/86466?usp=email ) Change subject: soc/amd/cezanne/acpi: Add ACP MSG0 method ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86466?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f641fbfe40b5df7f0ff2fc173510c5cf2a7f61 Gerrit-Change-Number: 86466 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 16 Feb 2025 22:22:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025