Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85845?usp=email )
Change subject: soc/intel/xeon_sp: Add Xeon ICX-SP support
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85845/comment/7d6a06c4_23d3e521?us… :
PS3, Line 9: Add support for the 1st Gen 10nm Xeon-SP CPUs. Supported and tested
> ICX might be advertised as 3rd gen Xeon-SP, but this term is intentionally not used as CPX is also 3 […]
Technically yes but what I'm worried about is many users will refer to public URLs to check the products, e.g., https://www.intel.com/content/www/us/en/ark.html#@PanelLabel595, thus not straightforward to find a match.
Back to the previous discussion for SKX/CPX code merge, if we have both concept of ?? nm and ?? gen to co-exist, it would be helpful to be consistent with the meaning of 'gen' as the global generation instead of per 'nm' generation. This is adequate to distinguish CPX (14nm gen3) and ICX (10nm gen3), and as well as others.
Your opinion?
https://review.coreboot.org/c/coreboot/+/85845/comment/a60b94cd_dc91faa0?us… :
PS3, Line 10: are dual socket systems with a LBG PCH.
> Yes. Mainboard support will be added as separate commit.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85845?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bb74c0db2c91c87bf623c079f89fd139780160b
Gerrit-Change-Number: 85845
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 07 Jan 2025 05:36:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85860?usp=email )
Change subject: soc/mediatek/common/dp: Move common functions to dptx_common.c
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/dp/dptx.c:
https://review.coreboot.org/c/coreboot/+/85860/comment/6abf743d_1152cdc1?us… :
PS3, Line 425: dptx_set_trainingstart
> It is difficult for me to realize whole flow within one or two days (plus verification on mt8188/mt8 […]
Created a bug for tracking.
File src/soc/mediatek/common/dp/dptx_common.c:
https://review.coreboot.org/c/coreboot/+/85860/comment/7456dc9f_3a371914?us… :
PS4, Line 281: union misc_t dptx_misc;
> Separate patch.
CB:85877
--
To view, visit https://review.coreboot.org/c/coreboot/+/85860?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5074feee9efa62f27c118eaf7adb25875ba4c16
Gerrit-Change-Number: 85860
Gerrit-PatchSet: 5
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 07 Jan 2025 05:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yidi Lin.
Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85799?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8196: Delay 0.5ms after enabling PMIF SPMI SW interface
......................................................................
soc/mediatek/mt8196: Delay 0.5ms after enabling PMIF SPMI SW interface
The initialization process of SPMI requires a certain amount of time
(0.5ms) to ensure all components are correctly configured and
synchronized. Otherwise, if the SPMI calibration fails, it will result
in the non-serial firmware failing to boot.
TEST=Build pass, non-serial firmware boot ok.
BUG=b:341054056
Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8196/pmif_spmi.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/85799/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85799?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Gerrit-Change-Number: 85799
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin.
Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85859?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek: Rename DP related header files
......................................................................
soc/mediatek: Rename DP related header files
Add `_common` postfix to the header files located in
common/dp/include/soc/. The patch helps MT8196 managing its own DP
register difition and macros in its include/soc folder.
BUG=b:382363408
TEST=emerge-geralt coreboot && emerge-cherry coreboot
Change-Id: I4ebfa2aa0dde759275c9826c605f3285c777f58d
Signed-off-by: Yidi Lin <yidilin(a)chromium.org>
---
R src/soc/mediatek/common/dp/include/soc/dp_intf_common.h
R src/soc/mediatek/common/dp/include/soc/dptx_common.h
R src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h
R src/soc/mediatek/common/dp/include/soc/dptx_reg_common.h
A src/soc/mediatek/mt8186/include/soc/dptx.h
A src/soc/mediatek/mt8188/include/soc/dp_intf.h
A src/soc/mediatek/mt8188/include/soc/dptx.h
A src/soc/mediatek/mt8188/include/soc/dptx_hal.h
A src/soc/mediatek/mt8188/include/soc/dptx_reg.h
A src/soc/mediatek/mt8195/include/soc/dp_intf.h
A src/soc/mediatek/mt8195/include/soc/dptx.h
A src/soc/mediatek/mt8195/include/soc/dptx_hal.h
A src/soc/mediatek/mt8195/include/soc/dptx_reg.h
13 files changed, 84 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/85859/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85859?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ebfa2aa0dde759275c9826c605f3285c777f58d
Gerrit-Change-Number: 85859
Gerrit-PatchSet: 5
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Attention is currently required from: Hung-Te Lin, Yidi Lin.
Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85860?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/common/dp: Move common functions to dptx_common.c
......................................................................
soc/mediatek/common/dp: Move common functions to dptx_common.c
Move the functions that can be shared with MT8196 to dptx_common.c.
BUG=b:382363408
TEST=emerge-geralt coreboot && emerge-cherry coreboot
Change-Id: Ic5074feee9efa62f27c118eaf7adb25875ba4c16
Signed-off-by: Yidi Lin <yidilin(a)chromium.org>
---
M src/soc/mediatek/common/dp/dptx.c
A src/soc/mediatek/common/dp/dptx_common.c
M src/soc/mediatek/common/dp/include/soc/dptx_common.h
M src/soc/mediatek/mt8188/Makefile.mk
M src/soc/mediatek/mt8195/Makefile.mk
5 files changed, 645 insertions(+), 617 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/85860/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85860?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5074feee9efa62f27c118eaf7adb25875ba4c16
Gerrit-Change-Number: 85860
Gerrit-PatchSet: 5
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Wonkyu Kim has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85781?usp=email )
Change subject: soc/intel/pantherlake: Update the Thunderbolt lcap_port_base to 21
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85781?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44f91f954a4ec06c56dcc90d97e7da2193e9acf2
Gerrit-Change-Number: 85781
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Comment-Date: Tue, 07 Jan 2025 04:02:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes