coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
258 discussions

[XS] Change in coreboot[main]: testetsttestsetsete
by Name of user not set (Code Review) 05 Jan '25

05 Jan '25

Name of user not set #1005756 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85854?usp=email ) Change subject: testetsttestsetsete ...................................................................... testetsttestsetsete Change-Id: I652bc4916f5c623be352d476b083098b8240d03d Signed-off-by: test <test(a)test.com> --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/85854/1 diff --git a/Makefile b/Makefile index 491e702..c49f8c6 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,5 @@ ## SPDX-License-Identifier: BSD-3-Clause +#testtest ifneq ($(words $(CURDIR)),1) $(error Error: Path to the main directory cannot contain spaces) -- To view, visit https://review.coreboot.org/c/coreboot/+/85854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I652bc4916f5c623be352d476b083098b8240d03d Gerrit-Change-Number: 85854 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1005756

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
by Hope Wang (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Jarried Lin. Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ...................................................................... Patch Set 30: (2 comments) File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/006907a5_6673daff?us… : PS30, Line 64: int > Sorry, I just found a few problems when reviewing CB:85666. […] https://review.coreboot.org/c/coreboot/+/85839 https://review.coreboot.org/c/coreboot/+/85128/comment/69be0ddd_7ffc698c?us… : PS30, Line 107: regval * chan->hw_info.ratio[0] * chan->hw_info.ref_volt > @jarried.lin@mediatek. […] Done in https://review.coreboot.org/c/coreboot/+/85839, regval uses u16 type. -- To view, visit https://review.coreboot.org/c/coreboot/+/85128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a Gerrit-Change-Number: 85128 Gerrit-PatchSet: 30 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 08:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct MT6363 buck5 enable API
by Hope Wang (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85838?usp=email ) Change subject: soc/mediatek/mt8196: Correct MT6363 buck5 enable API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why does the solution modify the mask/offset instead of deleting the function? Because the buck5 of mt6363 needs to be disabled in disable_pmic_ldo API. -- To view, visit https://review.coreboot.org/c/coreboot/+/85838?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0af1e0582ae8fc1e219f3cce536aed9985108be5 Gerrit-Change-Number: 85838 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 07:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add delay in pmif_spmi.c
by Hope Wang (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85799?usp=email ) Change subject: soc/mediatek/mt8196: Add delay in pmif_spmi.c ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85799/comment/9ea9956a_a9e7c4d8?us… : PS2, Line 7: Add delay in pmif_spmi.c > Can we be more specific? For example, `Delay 0.5ms before enabling cmd issue`. […] The 500 microseconds delay is implemented to ensure that the two fields, inf_en and arb_en of the PMIF can be written successfully. write32(&arb->mtk_pmif->inf_en, PMIF_SPMI_SW_CHAN); write32(&arb->mtk_pmif->arb_en, PMIF_SPMI_SW_CHAN); -- To view, visit https://review.coreboot.org/c/coreboot/+/85799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4 Gerrit-Change-Number: 85799 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 07:07:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[L] Change in coreboot[main]: mb/asus/p8x7x-series: Add Z77-A as a variant
by Keith Hui (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Nicholas Chin. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85836?usp=email ) Change subject: mb/asus/p8x7x-series: Add Z77-A as a variant ...................................................................... Patch Set 3: (1 comment) File src/mainboard/asus/p8x7x-series/variants/z77-a/hda/hda_verb.c: PS1: > Seems like an extra file which wasn't supposed to be committed? It is. Thanks for the catch. -- To view, visit https://review.coreboot.org/c/coreboot/+/85836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1a81b321c236bb1fd2763d69531958ef6f4b4e6 Gerrit-Change-Number: 85836 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 03:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: superio/nuvoton: Add NCT5535D
by Keith Hui (Code Review) 05 Jan '25

05 Jan '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85834?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: superio/nuvoton: Add NCT5535D ...................................................................... superio/nuvoton: Add NCT5535D NCT5535D is a 64-pin LPC super I/O chip found on many Asus P8x7x series mainboards with no publicly available datasheet. However, based on mb/asus/p8z77-v_lx2, this chip can probably be driven like a NCT6779D, on which this is based. Devices not present on this chip compared to NCT6779D are parallel port, serial port B, GPIOs 0,1,3,6. p8z77-v_lx2 still builds once modified for this chip, but is not tested further. Change-Id: I3fe0dd6fc3010a50b781ca7c5c39ea73b91978a5 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- A src/superio/nuvoton/nct5535d/Kconfig A src/superio/nuvoton/nct5535d/Makefile.mk A src/superio/nuvoton/nct5535d/acpi/superio.asl A src/superio/nuvoton/nct5535d/nct5535d.h A src/superio/nuvoton/nct5535d/superio.c 5 files changed, 302 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/85834/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85834?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3fe0dd6fc3010a50b781ca7c5c39ea73b91978a5 Gerrit-Change-Number: 85834 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/asus/p8z77-v_lx2: Change super I/O chip to nct5535d
by Keith Hui (Code Review) 05 Jan '25

05 Jan '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85835?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/asus/p8z77-v_lx2: Change super I/O chip to nct5535d ...................................................................... mb/asus/p8z77-v_lx2: Change super I/O chip to nct5535d Boardview indicates this board uses the smaller superio/nuvoton/nct5535d. Cut devices not present or remaining off from overridetree. Builds, but not function tested. Change-Id: Ie68f6f5b1be67ddabc8afee1dbd2db3c8b4f180b Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/Kconfig M src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb 2 files changed, 4 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/85835/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie68f6f5b1be67ddabc8afee1dbd2db3c8b4f180b Gerrit-Change-Number: 85835 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/asus/p8x7x-series: Add Z77-A as a variant
by Keith Hui (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Keith Hui, Nicholas Chin. Hello Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85836?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Nicholas Chin, Verified+1 by build bot (Jenkins) Change subject: mb/asus/p8x7x-series: Add Z77-A as a variant ...................................................................... mb/asus/p8x7x-series: Add Z77-A as a variant Constructed from a mix of similar boards, boardview and vendor firmware analysis. Not hardware tested. It has a RTL8111F LAN chip with no EEPROM for vital product data like LED configurations or MAC addresses. User will need to set their MAC address during 'make menuconfig'. Change-Id: Id1a81b321c236bb1fd2763d69531958ef6f4b4e6 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/Kconfig M src/mainboard/asus/p8x7x-series/Kconfig.name A src/mainboard/asus/p8x7x-series/variants/z77-a/board_info.txt A src/mainboard/asus/p8x7x-series/variants/z77-a/cmos.default A src/mainboard/asus/p8x7x-series/variants/z77-a/cmos.layout A src/mainboard/asus/p8x7x-series/variants/z77-a/data.vbt A src/mainboard/asus/p8x7x-series/variants/z77-a/early_init.c A src/mainboard/asus/p8x7x-series/variants/z77-a/gma-mainboard.ads A src/mainboard/asus/p8x7x-series/variants/z77-a/gpio.c A src/mainboard/asus/p8x7x-series/variants/z77-a/hda_verb.c A src/mainboard/asus/p8x7x-series/variants/z77-a/overridetree.cb 11 files changed, 516 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/85836/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1a81b321c236bb1fd2763d69531958ef6f4b4e6 Gerrit-Change-Number: 85836 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[S] Change in coreboot[main]: cbfs: Remove remnants of ext-win-*
by Felix Singer (Code Review) 05 Jan '25

05 Jan '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85619?usp=email ) Change subject: cbfs: Remove remnants of ext-win-* ...................................................................... cbfs: Remove remnants of ext-win-* Since commit 34a7e66faa46 ("util/cbfstool: Add a new mechanism to provide a memory map") the ext-win-base and ext-win-size option has been replaced with the "--mmap" option. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I33cfb59d9dbe88c4f618301ac1506e3281b1a483 Reviewed-on: https://review.coreboot.org/c/coreboot/+/85619 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/util/cbfstool/mmap_windows.md M Makefile.mk M util/cbfstool/cbfstool.c 3 files changed, 4 insertions(+), 10 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Nicholas Chin: Looks good to me, approved diff --git a/Documentation/util/cbfstool/mmap_windows.md b/Documentation/util/cbfstool/mmap_windows.md index 66685f3..654653c 100644 --- a/Documentation/util/cbfstool/mmap_windows.md +++ b/Documentation/util/cbfstool/mmap_windows.md @@ -36,9 +36,8 @@ `(4G - 16M) to 4G`. However, the platform is free to choose where the extended window lives in the host address space. Since `cbfstool` needs to know the exact location of the extended window, it allows the -platform to pass in two parameters `ext-win-base` and `ext-win-size` -that provide the base and the size of the extended window in host -address space. +platform to pass in one parameter `mmap` that provide the base and the +size of the extended window in host address space. `cbfstool` creates two memory map windows using the knowledge about the standard decode window and the information passed in by the platform diff --git a/Makefile.mk b/Makefile.mk index ca79d05..bc547de 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -988,7 +988,6 @@ # # CBFSTOOL_ADD_CMD_OPTIONS can be used by arch/SoC/mainboard to supply # add commands with any additional arguments for cbfstool. -# Example: --ext-win-base <base> --ext-win-size <size> define cbfs-add-cmd-for-region $(CBFSTOOL) $@.tmp \ add$(if $(filter stage,$(call extract_nth,3,$(1))),-stage)$(if \ diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 25f4847..5eb6335 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -1968,16 +1968,12 @@ " -U Unprocessed; don't decompress or make ELF\n" " -v Provide verbose output (-v=INFO -vv=DEBUG output)\n" " -h Display this help message\n\n" - " --ext-win-base Base of extended decode window in host address\n" - " space(x86 only)\n" - " --ext-win-size Size of extended decode window in host address\n" - " space(x86 only)\n" "COMMANDs:\n" " add [-r image,regions] -f FILE -n NAME -t TYPE [-A hash] \\\n" " [-c compression] [-b base-address | -a alignment] \\\n" " [-p padding size] [-y|--xip if TYPE is FSP] \\\n" " [-j topswap-size] (Intel CPUs only) [--ibb] \\\n" - " [--ext-win-base win-base --ext-win-size win-size] " + " [--mmio flash-base:mmio-base:size] " "Add a component\n" " " " -j valid size: 0x10000 0x20000 0x40000 0x80000 0x100000 \n" @@ -1990,7 +1986,7 @@ " [-S comma-separated-section(s)-to-ignore] \\\n" " [-a alignment] [-Q|--pow2page] \\\n" " [-y|--xip] [--ibb] \\\n" - " [--ext-win-base win-base --ext-win-size win-size] " + " [--mmio flash-base:mmio-base:size] " "Add a stage to the ROM\n" " add-flat-binary [-r image,regions] -f FILE -n NAME \\\n" " [-A hash] -l load-address -e entry-point \\\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/85619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33cfb59d9dbe88c4f618301ac1506e3281b1a483 Gerrit-Change-Number: 85619 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: cbfs: Remove remnants of ext-win-*
by Felix Singer (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85619?usp=email ) Change subject: cbfs: Remove remnants of ext-win-* ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33cfb59d9dbe88c4f618301ac1506e3281b1a483 Gerrit-Change-Number: 85619 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 03:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025