coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yang Wu (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Xinxiong Xu, Yu-Ping Wu. Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85889?usp=email ) Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85889/comment/ba2527f1_5497da6e?us… : PS2, Line 15: None > corsola Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 05:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yang Wu (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Xinxiong Xu, Yang Wu, Yu-Ping Wu. Hello Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85889?usp=email to look at the new patch set (#3). Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... drivers/mipi: Add support for STA_2082109QFH040022_50E panel Add STA panel STA_2082109QFH040022_50E serializable data to CBFS. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=build and check the CBFS include the panel BRANCH=corsola Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-STA_2082109QFH040022_50E.c 3 files changed, 133 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/85889/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM
by Yidi Lin (Code Review) 07 Jan '25

07 Jan '25

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yidi Lin (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Xinxiong Xu, Yang Wu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85889?usp=email ) Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85889/comment/27d264d6_00c78d5b?us… : PS2, Line 15: None corsola -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 04:11:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel
by Yidi Lin (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85890?usp=email ) Change subject: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Gerrit-Change-Number: 85890 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 04:10:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yidi Lin (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Xinxiong Xu, Yang Wu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85889?usp=email ) Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 04:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM
by Yidi Lin (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email ) Change subject: soc/mediatek/mt8196: Initialize MCUPM ...................................................................... Patch Set 1: (5 comments) File src/soc/mediatek/mt8196/mcupm.c: https://review.coreboot.org/c/coreboot/+/85888/comment/70520645_e0a660c0?us… : PS1, Line 9: #include <stdlib.h> what is this for ? https://review.coreboot.org/c/coreboot/+/85888/comment/9d0a787f_6a7ba31f?us… : PS1, Line 34: set Set https://review.coreboot.org/c/coreboot/+/85888/comment/641ff05a_dabc23c2?us… : PS1, Line 42: polling Poll https://review.coreboot.org/c/coreboot/+/85888/comment/19ada850_2fef478f?us… : PS1, Line 39: /* set CPUEB_STATE_VALID = 1 */ : setbits32p(SPM_MCUPM_SPMC_CON, CPUEB_STATE_VALID); : : /* polling CPUEB_STATE_FINISH_ACK = 1 */ : if (!retry(POLLING_ACK_TIME, : (read32p(SPM_MCUPM_SPMC_CON) & CPUEB_STATE_FINISH_ACK) == : CPUEB_STATE_FINISH_ACK, udelay(1))) { : printk(BIOS_WARNING, : "[EB_SPMC] Polling ACK timeout, %#x\n", : read32p(SPM_MCUPM_SPMC_CON)); : return -1; : } : : /* set CPUEB_STATE_VALID = 0 */ : clrbits32p(SPM_MCUPM_SPMC_CON, CPUEB_STATE_VALID); : : /* polling CPUEB_STATE_FINISH_ACK = 0 */ : if (!retry(POLLING_ACK_TIME, : (read32p(SPM_MCUPM_SPMC_CON) & CPUEB_STATE_FINISH_ACK) != : CPUEB_STATE_FINISH_ACK, udelay(1))) { : printk(BIOS_WARNING, : "[EB_SPMC] Polling ACK timeout, %#x\n", : read32p(SPM_MCUPM_SPMC_CON)); : return -1; : } Create a function to set value to `SPM_MCUPM_SPMC_CON` ``` static int xxxxx(uint32_t val) { clrsetbits32p(SPM_MCUPM_SPMC_CON, CPUEB_STATE_VALID, val); /* polling CPUEB_STATE_FINISH_ACK = 0 */ if (!retry(POLLING_ACK_TIME, (read32p(SPM_MCUPM_SPMC_CON) & CPUEB_STATE_FINISH_ACK) != CPUEB_STATE_FINISH_ACK, udelay(1))) { printk(BIOS_WARNING, "[EB_SPMC] Polling ACK timeout, %#x\n", read32p(SPM_MCUPM_SPMC_CON)); return -1; } } ``` https://review.coreboot.org/c/coreboot/+/85888/comment/db52cffd_c7db571e?us… : PS1, Line 101: MCUPM_CFGREG_SW_RSTN_SW_RSTN | MCUPM_CFGREG_SW_RSTN_DMA_BUSY_MASK); move to next line and align with first param. -- To view, visit https://review.coreboot.org/c/coreboot/+/85888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I223f245d384f32d54f6170a28b29573638f77296 Gerrit-Change-Number: 85888 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 08 Jan 2025 04:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel
by Yang Wu (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85890?usp=email to look at the new patch set (#3). Change subject: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel ...................................................................... mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel Add STA_2082109QFH040022_50E MIPI panel for wyrdeer. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/panel_wyrdeer.c 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/85890/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Gerrit-Change-Number: 85890 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel
by Yang Wu (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85890?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel ...................................................................... mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel Add STA_2082109QFH040022_50E MIPI panel for wyrdeer. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/panel_wyrdeer.c 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/85890/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Gerrit-Change-Number: 85890 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yang Wu (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Xinxiong Xu, Yidi Lin, Yu-Ping Wu. Hello Xinxiong Xu, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85889?usp=email to look at the new patch set (#2). Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... drivers/mipi: Add support for STA_2082109QFH040022_50E panel Add STA panel STA_2082109QFH040022_50E serializable data to CBFS. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=build and check the CBFS include the panel BRANCH=None Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-STA_2082109QFH040022_50E.c 3 files changed, 133 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/85889/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025