Attention is currently required from: Christian Walter, Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/74743?usp=email )
Change subject: mb/starlabs/starbook: Put options in CFR cbtable
......................................................................
Patch Set 35:
(1 comment)
File src/mainboard/starlabs/starbook/cfr.c:
https://review.coreboot.org/c/coreboot/+/74743/comment/751cb28f_239e7dd0?us… :
PS35, Line 380: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
:
> ```suggestion […]
looks fine to me?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6
Gerrit-Change-Number: 74743
Gerrit-PatchSet: 35
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 14:58:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Elyes Haouas, Maximilian Brune, Shuo Liu.
Hello Maximilian Brune, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85786?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Shuo Liu, Code-Review+2 by Maximilian Brune, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: util/cbfstool: Refine type and signatures
......................................................................
util/cbfstool: Refine type and signatures
As suggested by the linter:
> Prefer 'unsigned long' over 'unsigned long int' as the int is
> unnecessary
In fmap_bsearch(), offset being negative, changed its type to 'long',
and the return value of to 'long'.
fmap_find() uses the return value of fmap_bsearch(); and is declared as
'long int'. Per the linter warnings, replaced 'long int' by 'long'.
> Prefer 'long' over 'long int' as the int is unnecessary
Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art…
Cc: Nico Huber <nico.h(a)gmx.de>
Cc: Julius Werner <jwerner(a)chromium.org>
Cc: "Jérémy Compostella" <jeremy.compostella(a)intel.com>
Cc: Ron Minnich <rminnich(a)gmail.com>
Cc: Shuo Liu <shuo.liu(a)intel.com>
Cc: Arthur Heymans <arthur(a)aheymans.xyz>
Cc: Patrick Georgi <patrick(a)coreboot.org>
Cc: Elyes Haouas <ehaouas(a)noos.fr>
Change-Id: If94e70778d0302552f151c31d3073524162faf9e
Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr>
---
M util/cbfstool/cbfstool.c
M util/cbfstool/flashmap/fmap.c
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85786/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e
Gerrit-Change-Number: 85786
Gerrit-PatchSet: 2
Gerrit-Owner: Ariel Otilibili
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-CC: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas.
Ariel Otilibili has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email )
Change subject: util/cbfstool: Replace 'unsigned long int' by 'unsigned long'
......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/85786/comment/83ac4744_c01d5a5c?us… :
PS1, Line 99: unsigned long offset = -1;
> If it is unsigned, how it is = -1 ?
Indeed, Elyes; thanks for the feedback. I am pushing a new version, improving on your comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e
Gerrit-Change-Number: 85786
Gerrit-PatchSet: 1
Gerrit-Owner: Ariel Otilibili
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 11 Jan 2025 14:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Ariel Otilibili has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85783?usp=email )
Change subject: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long'
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/85783/comment/ca64144c_d6a87c42?us… :
PS1, Line 131: }
> Wondering if this cast is needed
Hello Elyes,
Thanks for having looked the patch. It seems so, fsp_reserved_bytes was declared as u32 [1], and depending the host, unsigned long and u32 may have different lengths [2].
[1] https://github.com/coreboot/coreboot/blob/aba7f44ecd3925c91f4249e03024af134…
[2] https://michas.eu/blog/c_ints.php?lang=en
--
To view, visit https://review.coreboot.org/c/coreboot/+/85783?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I940528dc4f8cb9b2d441d0f0d181cccebd315255
Gerrit-Change-Number: 85783
Gerrit-PatchSet: 1
Gerrit-Owner: Ariel Otilibili
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 11 Jan 2025 14:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Ariel Otilibili has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email )
Change subject: qualcomm/common: Remove dead code
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hello, any news on the patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85778?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e
Gerrit-Change-Number: 85778
Gerrit-PatchSet: 2
Gerrit-Owner: Ariel Otilibili
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 11 Jan 2025 14:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella, Naresh Solanki.
Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/glinda/cpu: Update cache info
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85640/comment/247c5d2e_09e7d9fd?us… :
PS3, Line 8:
Could you please describe why this had to be updated? I'm not familiar with the cache hierarchy on this platform.
File src/soc/amd/glinda/cpu.c:
https://review.coreboot.org/c/coreboot/+/85640/comment/b0ba9548_1dc6eb7a?us… :
PS3, Line 66: memcpy(info, &info_list[0], sizeof(*info));
Out of curiosity, is this copy necessary?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6
Gerrit-Change-Number: 85640
Gerrit-PatchSet: 3
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 13:36:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes