Attention is currently required from: Alexander Couzens, Nicholas Chin, Patrick Rudolph.
Hello Alexander Couzens, Nicholas Chin, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85924?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by Patrick Rudolph, Verified+1 by build bot (Jenkins)
Change subject: mb/*: Drop xhci_overcurrent_map II
......................................................................
mb/*: Drop xhci_overcurrent_map II
This is now copied from USBOCM1 built with main USB port config.
Boards to be patched here have mismatched xhci_overcurrent_map and
needs manual review and/or testing.
Change-Id: Ie60d34cae5ae94d148854b42f77ab4c02e8f49ef
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/dell/snb_ivb_workstations/variants/baseboard/devicetree.cb
M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/overridetree.cb
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/85924/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie60d34cae5ae94d148854b42f77ab4c02e8f49ef
Gerrit-Change-Number: 85924
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Alexander Couzens, Kevin Keijzer.
Hello Alexander Couzens, Kevin Keijzer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85923?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/*: Drop xhci_overcurrent_map I
......................................................................
mb/*: Drop xhci_overcurrent_map I
This is now copied from USBOCM1 built with main USB port config.
Boards patched here have matching EHCI and xHCI overcurrent mappings.
Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/asrock/b75m-itx/devicetree.cb
M src/mainboard/asrock/b75pro3-m/devicetree.cb
M src/mainboard/asrock/h77pro4-m/devicetree.cb
M src/mainboard/asus/p8x7x-series/devicetree.cb
M src/mainboard/compulab/intense_pc/devicetree.cb
M src/mainboard/dell/snb_ivb_latitude/variants/e5530/overridetree.cb
M src/mainboard/dell/snb_ivb_latitude/variants/e6230/overridetree.cb
M src/mainboard/dell/snb_ivb_latitude/variants/e6330/overridetree.cb
M src/mainboard/dell/snb_ivb_latitude/variants/e6430/overridetree.cb
M src/mainboard/dell/snb_ivb_latitude/variants/e6530/overridetree.cb
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/overridetree.cb
M src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/overridetree.cb
M src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb
M src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb
M src/mainboard/lenovo/s230u/devicetree.cb
M src/mainboard/lenovo/t430/devicetree.cb
M src/mainboard/lenovo/t430s/devicetree.cb
M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
M src/mainboard/lenovo/x230/devicetree.cb
M src/mainboard/roda/rv11/variants/rv11/devicetree.cb
M src/mainboard/roda/rv11/variants/rw11/devicetree.cb
M src/mainboard/supermicro/x9sae/devicetree.cb
27 files changed, 1 insertion(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/85923/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85923?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb
Gerrit-Change-Number: 85923
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Matt DeVillier.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85714?usp=email
to look at the new patch set (#17).
Change subject: mb/starlabs/starbook: Add AlderLake-N variant
......................................................................
mb/starlabs/starbook: Add AlderLake-N variant
Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starbook_adl_n.md
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/Kconfig.name
A src/mainboard/starlabs/starbook/variants/adl_n/Makefile.mk
A src/mainboard/starlabs/starbook/variants/adl_n/board.fmd
A src/mainboard/starlabs/starbook/variants/adl_n/data.vbt
A src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb
A src/mainboard/starlabs/starbook/variants/adl_n/devtree.c
A src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
A src/mainboard/starlabs/starbook/variants/adl_n/hda_verb.c
A src/mainboard/starlabs/starbook/variants/adl_n/ramstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/romstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/vboot.fmd
14 files changed, 1,119 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85714/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 17
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85715?usp=email
to look at the new patch set (#13).
Change subject: mb/starlabs/starbook: Add Meteor Lake (165H) variant
......................................................................
mb/starlabs/starbook: Add Meteor Lake (165H) variant
Change-Id: I6621585086c58d19574841314796ed9db779036e
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starbook_mtl.md
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/Kconfig.name
M src/mainboard/starlabs/starbook/dsdt.asl
A src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk
A src/mainboard/starlabs/starbook/variants/mtl/board.fmd
A src/mainboard/starlabs/starbook/variants/mtl/data.vbt
A src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb
A src/mainboard/starlabs/starbook/variants/mtl/devtree.c
A src/mainboard/starlabs/starbook/variants/mtl/gpio.c
A src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c
A src/mainboard/starlabs/starbook/variants/mtl/ramstage.c
A src/mainboard/starlabs/starbook/variants/mtl/romstage.c
14 files changed, 834 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85715/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/85715?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6621585086c58d19574841314796ed9db779036e
Gerrit-Change-Number: 85715
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Attention is currently required from: Matt DeVillier.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85709?usp=email
to look at the new patch set (#10).
Change subject: mb/starlabs/starfighter: Put options in CFR cbtable
......................................................................
mb/starlabs/starfighter: Put options in CFR cbtable
Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/mainboard/starlabs/starfighter/Kconfig
M src/mainboard/starlabs/starfighter/Makefile.mk
A src/mainboard/starlabs/starfighter/cfr.c
M src/mainboard/starlabs/starfighter/cmos.default
M src/mainboard/starlabs/starfighter/cmos.layout
5 files changed, 334 insertions(+), 91 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/85709/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/85709?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa
Gerrit-Change-Number: 85709
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/76583?usp=email )
Change subject: mb/starlabs/lite: Put options in CFR cbtable
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/starlabs/lite/cfr.c:
https://review.coreboot.org/c/coreboot/+/76583/comment/0398a438_ca25248d?us… :
PS14, Line 213: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
> this should be: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76583?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2
Gerrit-Change-Number: 76583
Gerrit-PatchSet: 15
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 20:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85710?usp=email )
Change subject: mb/starlabs/byte_adl: Put options in CFR cbtable
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/starlabs/byte_adl/cfr.c:
https://review.coreboot.org/c/coreboot/+/85710/comment/62aa626a_bbd14b84?us… :
PS7, Line 211: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
> should be: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85710?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11349397e41fb2c7a3f26ab172a2c4b30d24bc0a
Gerrit-Change-Number: 85710
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 19:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>