coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[S] Change in coreboot[main]: util/cbfstool: Refine type and signatures
by Felix Singer (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Ariel Otilibili, Maximilian Brune, Shuo Liu. Felix Singer has uploaded a new patch set (#5) to the change originally created by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email ) Change subject: util/cbfstool: Refine type and signatures ...................................................................... util/cbfstool: Refine type and signatures As suggested by the linter: > Prefer 'unsigned long' over 'unsigned long int' as the int is > unnecessary In fmap_bsearch(), removed needless assignment of offset; it is already set to 0 in the search loop. fmap_find() uses the return value of fmap_bsearch(); and is declared as 'long int'. Per the linter warnings, replaced 'long int' by 'long'. > Prefer 'long' over 'long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Change-Id: If94e70778d0302552f151c31d3073524162faf9e Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M util/cbfstool/cbfstool.c M util/cbfstool/flashmap/fmap.c 2 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85786/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e Gerrit-Change-Number: 85786 Gerrit-PatchSet: 5 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Ariel Otilibili Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[S] Change in coreboot[main]: util/cbfstool: Refine type and signatures
by Felix Singer (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Ariel Otilibili, Maximilian Brune, Shuo Liu. Felix Singer has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email ) Change subject: util/cbfstool: Refine type and signatures ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85786/comment/e29cf58b_37b0e136?us… : PS4, Line 23: Cc: Nico Huber <nico.h(a)gmx.de> : Cc: Julius Werner <jwerner(a)chromium.org> : Cc: "Jérémy Compostella" <jeremy.compostella(a)intel.com> : Cc: Ron Minnich <rminnich(a)gmail.com> : Cc: Shuo Liu <shuo.liu(a)intel.com> : Cc: Arthur Heymans <arthur(a)aheymans.xyz> : Cc: Patrick Georgi <patrick(a)coreboot.org> : Cc We usually don't add this kind of information to the commit message. Please don't add that in future commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e Gerrit-Change-Number: 85786 Gerrit-PatchSet: 4 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Ariel Otilibili Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sun, 12 Jan 2025 05:52:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: tests: Replace 'unsigned long int' by 'unsigned long'
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85788?usp=email ) Change subject: tests: Replace 'unsigned long int' by 'unsigned long' ...................................................................... tests: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Cc: Jakub Czapiga <czapiga(a)google.com> Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85788 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M tests/device/i2c-test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/tests/device/i2c-test.c b/tests/device/i2c-test.c index 4b96d94..36b9e4a 100644 --- a/tests/device/i2c-test.c +++ b/tests/device/i2c-test.c @@ -80,7 +80,7 @@ static void mock_expect_params_platform_i2c_transfer(void) { - unsigned long int expected_flags[] = {0, I2C_M_RD, I2C_M_TEN, I2C_M_RECV_LEN, + unsigned long expected_flags[] = {0, I2C_M_RD, I2C_M_TEN, I2C_M_RECV_LEN, I2C_M_NOSTART}; /* Flags should always be only within supported range */ -- To view, visit https://review.coreboot.org/c/coreboot/+/85788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Gerrit-Change-Number: 85788 Gerrit-PatchSet: 3 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com>

1 0

[XS] Change in coreboot[main]: tests: Replace 'unsigned long int' by 'unsigned long'
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Ariel Otilibili. Elyes Haouas has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85788?usp=email ) Change subject: tests: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Gerrit-Change-Number: 85788 Gerrit-PatchSet: 2 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Sun, 12 Jan 2025 04:52:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: lib: Replace 'unsigned long int' by 'unsigned long'
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85787?usp=email ) Change subject: lib: Replace 'unsigned long int' by 'unsigned long' ...................................................................... lib: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85787 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/ubsan.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Maximilian Brune: Looks good to me, approved diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 560493c..456a272 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -43,8 +43,8 @@ if (!location || !location->filename) location = &unknown_location; printk(BIOS_ERR, "%s %s:%lu:%lu\n", violation, location->filename, - (unsigned long int)location->line, - (unsigned long int)location->column); + (unsigned long)location->line, + (unsigned long)location->column); die("ubsan: unrecoverable error.\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/85787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Gerrit-Change-Number: 85787 Gerrit-PatchSet: 2 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: lib: Replace 'unsigned long int' by 'unsigned long'
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Ariel Otilibili. Elyes Haouas has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85787?usp=email ) Change subject: lib: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Gerrit-Change-Number: 85787 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Sun, 12 Jan 2025 04:51:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long'
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85783?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long' ...................................................................... intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Huang Jin <huang.jin(a)intel.com> Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> Change-Id: I940528dc4f8cb9b2d441d0f0d181cccebd315255 Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85783 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M src/drivers/intel/fsp1_1/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Elyes Haouas: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index 247df04..da71dd7 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -127,7 +127,7 @@ } else { fsp_reserved_bytes = fsp_memory->ResourceLength; printk(BIOS_DEBUG, "Reserving 0x%016lx bytes for FSP\n", - (unsigned long int)fsp_reserved_bytes); + (unsigned long)fsp_reserved_bytes); } /* Display SMM area */ -- To view, visit https://review.coreboot.org/c/coreboot/+/85783?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940528dc4f8cb9b2d441d0f0d181cccebd315255 Gerrit-Change-Number: 85783 Gerrit-PatchSet: 3 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: util/cbfstool: Refine type and signatures
by Elyes Haouas (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Ariel Otilibili, Maximilian Brune, Shuo Liu. Elyes Haouas has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email ) Change subject: util/cbfstool: Refine type and signatures ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e Gerrit-Change-Number: 85786 Gerrit-PatchSet: 4 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Ariel Otilibili Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sun, 12 Jan 2025 04:46:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/biostar/th61-itx: Drop early_init.c
by Nicholas Chin (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Keith Hui. Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85938?usp=email ) Change subject: mb/biostar/th61-itx: Drop early_init.c ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Timeless build did not change -- To view, visit https://review.coreboot.org/c/coreboot/+/85938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I768ace8e3f0486a0dc601a3e90084432280c6fef Gerrit-Change-Number: 85938 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 11 Jan 2025 22:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/starlite_adl: Put options in CFR cbtable
by Matt DeVillier (Code Review) 11 Jan '25

11 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85711?usp=email ) Change subject: mb/starlabs/starlite_adl: Put options in CFR cbtable ...................................................................... Patch Set 9: (1 comment) File src/mainboard/starlabs/starlite_adl/cfr.c: https://review.coreboot.org/c/coreboot/+/85711/comment/d5b2fc6e_62ca0612?us… : PS7, Line 320: void lb_board(struct lb_header *header) : { : char *current = (char *)lb_new_record(header); : struct lb_cfr *cfr_root = (struct lb_cfr *)current; : : cfr_write_setup_menu(cfr_root, sm_root); : } > should be: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If92f61dece7e67bfd2e29927198c9ebb81c4d363 Gerrit-Change-Number: 85711 Gerrit-PatchSet: 9 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sat, 11 Jan 2025 22:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025