Attention is currently required from: Keith Hui.
Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85940?usp=email )
Change subject: mb/hp/snb_ivb_laptops: Remove old USB configurations
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Timeless builds did not change
--
To view, visit https://review.coreboot.org/c/coreboot/+/85940?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc9e7892f978e52cfb30eb0239fcfd394c9f484e
Gerrit-Change-Number: 85940
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 22:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email )
Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
......................................................................
Patch Set 8: -Code-Review
(1 comment)
Patchset:
PS8:
in `src/ec/starlabs/merlin/variants/merlin/events.asl`, need to guard the call to `Notify (BAT0, 0x80)`
--
To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082
Gerrit-Change-Number: 85716
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Sat, 11 Jan 2025 22:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Keith Hui has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/85939?usp=email )
Change subject: mb/hp/pro_3500_series: Move USB port config to devicetree
......................................................................
Abandoned
Already done by CB:85831
--
To view, visit https://review.coreboot.org/c/coreboot/+/85939?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I397c940c8b7c70c8687df3b62e353681def56204
Gerrit-Change-Number: 85939
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Alexander Couzens, Nicholas Chin, Patrick Rudolph.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85924?usp=email )
Change subject: mb/*: Drop xhci_overcurrent_map II
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
> This is the kind of manual review I'm talking about. […]
Done
Patchset:
PS2:
Reviews are done and new clean-up patches are lined up.
There still remains 3 boards with really mismatching XHCI and EHCI overcurrent mapping. Of the three lenovo/x131e also requires a post-CB:81882 cleanup, so it gets its own patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie60d34cae5ae94d148854b42f77ab4c02e8f49ef
Gerrit-Change-Number: 85924
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 21:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>