coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend
by Subrata Banik (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Julius Werner, Nicholas Chin. Subrata Banik has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email ) Change subject: drivers/option: Add CBFS file based option backend ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > you might need to make the below changes to allow option to be picked from soc/mainboard > > ``` > git diff > diff --git a/src/Kconfig b/src/Kconfig > index 0a0643ebf6b..996971e9cf5 100644 > --- a/src/Kconfig > +++ b/src/Kconfig > @@ -149,6 +149,7 @@ config UTIL_GENPARSER > > choice > prompt "Option backend to use" > + default USE_CBFS_FILE_OPTION_BACKEND if HAVE_CBFS_FILE_OPTION_BACKEND > default USE_MAINBOARD_SPECIFIC_OPTION_BACKEND if HAVE_MAINBOARD_SPECIFIC_OPTION_BACKEND > default USE_OPTION_TABLE if NVRAMCUI_SECONDARY_PAYLOAD > default USE_UEFI_VARIABLE_STORE if DRIVERS_EFI_VARIABLE_STORE && \ > @@ -840,6 +841,15 @@ config NUM_THREADS > help > How many execution threads to cooperatively multitask with. > > +config HAVE_CBFS_FILE_OPTION_BACKEND > + bool > + default n > + help > + Enable this option if your mainboard stores coreboot options > + in files within the CBFS files. This option tells coreboot to > + read option values from these files instead of using other > + methods like embedded NVRAM. > + > config HAVE_MAINBOARD_SPECIFIC_OPTION_BACKEND > bool > help > ``` later SoC or mainboard layer can select HAVE_CBFS_FILE_OPTION_BACKEND depending on their need. -- To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Gerrit-Change-Number: 85905 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:55:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend
by Subrata Banik (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Julius Werner, Nicholas Chin. Subrata Banik has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email ) Change subject: drivers/option: Add CBFS file based option backend ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: you might need to make the below changes to allow option to be picked from soc/mainboard ``` git diff diff --git a/src/Kconfig b/src/Kconfig index 0a0643ebf6b..996971e9cf5 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -149,6 +149,7 @@ config UTIL_GENPARSER choice prompt "Option backend to use" + default USE_CBFS_FILE_OPTION_BACKEND if HAVE_CBFS_FILE_OPTION_BACKEND default USE_MAINBOARD_SPECIFIC_OPTION_BACKEND if HAVE_MAINBOARD_SPECIFIC_OPTION_BACKEND default USE_OPTION_TABLE if NVRAMCUI_SECONDARY_PAYLOAD default USE_UEFI_VARIABLE_STORE if DRIVERS_EFI_VARIABLE_STORE && \ @@ -840,6 +841,15 @@ config NUM_THREADS help How many execution threads to cooperatively multitask with. +config HAVE_CBFS_FILE_OPTION_BACKEND + bool + default n + help + Enable this option if your mainboard stores coreboot options + in files within the CBFS files. This option tells coreboot to + read option values from these files instead of using other + methods like embedded NVRAM. + config HAVE_MAINBOARD_SPECIFIC_OPTION_BACKEND bool help ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Gerrit-Change-Number: 85905 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:55:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add display driver
by Nancy Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email ) Change subject: soc/mediatek/mt8196: Add display driver ...................................................................... Patch Set 2: (23 comments) File src/soc/mediatek/common/display.c: https://review.coreboot.org/c/coreboot/+/85950/comment/eca5a211_2b97b8b0?us… : PS2, Line 46: __weak int mtk_edp_enable(void) > From another [comment](https://review.coreboot. […] This can't merged into mtk_edp_init. If this is merged in mtk_edp_init, then the flow is as following: EDP config/enable first and then display pipe initialization. In this flow, it could display garbage because display pipe didn't send data to eDP. So the correct sequence is to enable the EDP after both EDP and display config done. File src/soc/mediatek/mt8196/ddp.c: https://review.coreboot.org/c/coreboot/+/85950/comment/fa99a196_2639c8cd?us… : PS2, Line 17: clrbits32(&reg->datapath_con, BIT(4)); : setbits32(&reg->datapath_con, BIT(5)); > Single `clrsetbits32` call. Same for other blender types. OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/df8ade3f_b8ae403d?us… : PS2, Line 28: break; > Add `OTHER_BLENDER:` OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/e92370ae_42f26d5a?us… : PS2, Line 36: height << 16 | width > Define a macro for this […] OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/69093ef6_484cf030?us… : PS2, Line 38: ff > upper case OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/9f666de2_6ef501c9?us… : PS2, Line 130: 0xff > upper case OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/a28a18c5_6466c28b?us… : PS2, Line 196: /* mutex enable*/ > wrong style OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/8e339a6c_8c6f3311?us… : PS2, Line 205: blender_config(0, width, height, FIRST_BLENDER); : blender_config(1, width, height, OTHERS); : blender_config(2, width, height, OTHERS); : blender_config(3, width, height, LAST_BLENDER); : blender_start(0); : blender_start(1); : blender_start(2); : blender_start(3); > Use for loops. […] OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/20c8b8e0_c55657d2?us… : PS2, Line 233: /* async config*/ > wrong style OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/96cb3c40_8263e545?us… : PS2, Line 264: /* exdma start*/ > wrong style OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/f149564f_03255887?us… : PS2, Line 275: 0xffffffff > upper case OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/d8e4d11d_b3aa12c6?us… : PS2, Line 308: > Check that `width <= XXX && height <= XXX`, and change the type of `width` and `height` to u16 for ` […] OK, I will fix it File src/soc/mediatek/mt8196/include/soc/ddp.h: https://review.coreboot.org/c/coreboot/+/85950/comment/27893187_a25dba51?us… : PS2, Line 10: #define MAIN_PATH_OVL_NR 2 > Remove if unused OK, I will remove it. https://review.coreboot.org/c/coreboot/+/85950/comment/9a436097_d9d60f6e?us… : PS2, Line 15: /* 0x000 */ > Remove all of these comments, as we already have `check_member` below. OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/536c9919_5f24f2d1?us… : PS2, Line 58: check_member(ovlsys_cfg, rsz_in_cb2, 0xF70); > One blank line below. Same for others. OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/23aaf5f4_7099f8cc?us… : PS2, Line 110: 0xc30 > upper case OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/d23cca1f_3da46e01?us… : PS2, Line 279: }; > blank line below OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/0508c3e1_98423cbd?us… : PS2, Line 281: (void *)MMSYS_MUTEX_BASE, : (void *)MMSYS1_MUTEX_BASE, : (void *)OVLSYS_MUTEX_BASE, > ``` […] OK, I will fix it. https://review.coreboot.org/c/coreboot/+/85950/comment/36f044a3_2986c9a7?us… : PS2, Line 286: OVL_INPUT_FORMAT > Remove this unused name. OK, I will fix it https://review.coreboot.org/c/coreboot/+/85950/comment/e8f7e4bc_fe277263?us… : PS2, Line 317: /* DISPSYS mutex module*/ > wrong style OK, I will fix it https://review.coreboot.org/c/coreboot/+/85950/comment/e094fd25_ad28902f?us… : PS2, Line 343: /* DISPSYS1 mutex module*/ > wrong style OK, I will fix it https://review.coreboot.org/c/coreboot/+/85950/comment/ec1a2cff_26e69284?us… : PS2, Line 365: OTHERS > Can we rename to `OTHER_BLENDER`? OK, I will fix it https://review.coreboot.org/c/coreboot/+/85950/comment/d12b25eb_31c6c072?us… : PS2, Line 366: BLENDER_LAYER_MAX, > remove OK, I will fix it -- To view, visit https://review.coreboot.org/c/coreboot/+/85950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466 Gerrit-Change-Number: 85950 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: mb/*: Remove old USB configurations from SNB/IVB boards
by Nicholas Chin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Alexander Couzens, Keith Hui. Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85942?usp=email ) Change subject: mb/*: Remove old USB configurations from SNB/IVB boards ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85942?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I03b1bce9a12aa687a7c65db79efc2cddc1708a79 Gerrit-Change-Number: 85942 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:35:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend
by Nicholas Chin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Julius Werner, Subrata Banik. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email ) Change subject: drivers/option: Add CBFS file based option backend ...................................................................... Patch Set 4: (4 comments) Patchset: PS2: > Hi Nicholas, I'm going to address the review comments in this CL since we need this option to read t […] Oh, I didn't notice this by the time I pushed a new patchset. I don't do coreboot stuff for work but I am able to regularly work on CL in my free time if that works. File src/drivers/option/cbfs_file_option.c: https://review.coreboot.org/c/coreboot/+/85905/comment/98a21f4d_a1a12e41?us… : PS2, Line 11: cbfs_map > Note that when using boards with CONFIG_VBOOT, this will read from the current slot (RO/RW_A/RW_B). […] Done https://review.coreboot.org/c/coreboot/+/85905/comment/b5e14cae_684f667a?us… : PS2, Line 11: unsigned int *p > Actually, this is also a little dicey. `cbfstool add-int` creates a u64 in little-endian in CBFS. […] Done https://review.coreboot.org/c/coreboot/+/85905/comment/c186ee88_a60fc6d3?us… : PS2, Line 11: name > Since the option names are all over the place, should we group them under a prefix in CBFS (e.g. […] Done. I used the preprocessor to add an "option/" prefix to all calls to `get/set_uint_option)` for zero runtime overhead, especially since there's no access to things like `malloc` before ramstage. Not sure if there's a better way to do that. -- To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Gerrit-Change-Number: 85905 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:19:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: mb/google/fatcat: Remove chromeos-debug-fsp.fmd
by Eric Lai (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Pranava Y N, Subrata Banik. Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85971?usp=email ) Change subject: mb/google/fatcat: Remove chromeos-debug-fsp.fmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85971?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida430d415ae3f7dc93b89eb4d7c7ba59ed280e1b Gerrit-Change-Number: 85971 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 05:18:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend
by Nicholas Chin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Nicholas Chin. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85905?usp=email to look at the new patch set (#4). Change subject: drivers/option: Add CBFS file based option backend ...................................................................... drivers/option: Add CBFS file based option backend Add a new option backend that uses values stored in CBFS files, similar to the SeaBIOS runtime config options stored in files with the etc/ prefix. Options should be stored in cbfs with the option/ prefix. Values can be set using `cbfstool coreboot.rom add-int -i option/value -n option_name`. For simplicity, options should be stored in the COREBOOT (RO) FMAP region, which is the default for cbfstool. Tested with QEMU Q35 by setting various options for "sata_mode" and observing the console output for the SATA controller mode during i82801ix_sata initialization. Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/Kconfig M src/drivers/option/Makefile.mk A src/drivers/option/cbfs_file_option.c M src/include/option.h 4 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/85905/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Gerrit-Change-Number: 85905 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in coreboot[main]: drivers/option: Add CBFS file based option backend
by Nicholas Chin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Nicholas Chin. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85905?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/option: Add CBFS file based option backend ...................................................................... drivers/option: Add CBFS file based option backend Add a new option backend that uses values stored in CBFS files, similar to the SeaBIOS runtime config options stored in files with the etc/ prefix. Options should be stored in cbfs with the option/ prefix. Values can be set using `cbfstool coreboot.rom add-int -i option/value -n option_name`. For simplicity, options should be stored in the COREBOOT (RO) FMAP region, which is the default for cbfstool. Tested with QEMU Q35 by setting various options for "sata_mode" and observing the console output for the SATA controller mode during i82801ix_sata initialization. Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/Kconfig M src/drivers/option/Makefile.mk A src/drivers/option/cbfs_file_option.c M src/include/option.h 4 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/85905/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc0439ee42f13f49ae54d4855d1d9333c39b01f5 Gerrit-Change-Number: 85905 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email ) Change subject: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 04:59:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Workaround for codec enable with FPS
by Pranava Y N (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85992?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Workaround for codec enable with FPS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9883036b5e964cb55bd34c36398a501f69a8ecaa Gerrit-Change-Number: 85992 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 04:38:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025