Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84396?usp=email )
Change subject: mb/msi/ms7e06: Correct number of jacks in hda_verb.c
......................................................................
mb/msi/ms7e06: Correct number of jacks in hda_verb.c
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: I5cf34d8c4e27835d126eb66f2015d2e9d93b700f
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M src/mainboard/msi/ms7e06/hda_verb.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/84396/1
diff --git a/src/mainboard/msi/ms7e06/hda_verb.c b/src/mainboard/msi/ms7e06/hda_verb.c
index 51f9a50..96578fa 100644
--- a/src/mainboard/msi/ms7e06/hda_verb.c
+++ b/src/mainboard/msi/ms7e06/hda_verb.c
@@ -26,7 +26,7 @@
/* Alderlake HDMI */
0x80862818, /* Vendor ID */
0x80860101, /* Subsystem ID */
- 2, /* Number of entries */
+ 10, /* Number of entries */
AZALIA_SUBVENDOR(2, 0x80860101),
AZALIA_PIN_CFG(2, 0x04, 0x18560010),
AZALIA_PIN_CFG(2, 0x06, 0x18560010),
--
To view, visit https://review.coreboot.org/c/coreboot/+/84396?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5cf34d8c4e27835d126eb66f2015d2e9d93b700f
Gerrit-Change-Number: 84396
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84395?usp=email )
Change subject: mb/samsung/lumpy: Correct number of jacks in hda_verb.c
......................................................................
mb/samsung/lumpy: Correct number of jacks in hda_verb.c
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: I3a40e6229419ee7d1a238916ee6d49cf9314f6ab
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M src/mainboard/samsung/lumpy/hda_verb.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/84395/1
diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c
index d18d8d2..a2b60bf 100644
--- a/src/mainboard/samsung/lumpy/hda_verb.c
+++ b/src/mainboard/samsung/lumpy/hda_verb.c
@@ -6,12 +6,15 @@
/* coreboot specific header */
0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210
0x152D0924, // Subsystem ID
- 0x00000007, // Number of jacks
+ 0x00000008, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */
AZALIA_SUBVENDOR(0, 0x152D0924),
0x00170500,
+ 0x00170500,
+ 0x00170500,
+ 0x00170500,
/* Pin Widget Verb Table */
--
To view, visit https://review.coreboot.org/c/coreboot/+/84395?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a40e6229419ee7d1a238916ee6d49cf9314f6ab
Gerrit-Change-Number: 84395
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84394?usp=email )
Change subject: mb/facebook/fbg1701: Correct number of jacks in hda_verb.c
......................................................................
mb/facebook/fbg1701: Correct number of jacks in hda_verb.c
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: I60bb9e7df368b786e17bb49a6f35d27372fd21de
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M src/mainboard/facebook/fbg1701/hda_verb.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/84394/1
diff --git a/src/mainboard/facebook/fbg1701/hda_verb.c b/src/mainboard/facebook/fbg1701/hda_verb.c
index 2ace42d..eae4d03 100644
--- a/src/mainboard/facebook/fbg1701/hda_verb.c
+++ b/src/mainboard/facebook/fbg1701/hda_verb.c
@@ -6,7 +6,7 @@
/* coreboot specific header */
0x10EC0298, /* Codec Vendor - Device ID: Realtek ALC298 */
0x152D1165, /* Subsystem ID Quanta */
- 0x0000000C, /* Number of jacks */
+ 0x0000000E, /* Number of jacks */
/* HDA Codec Subsystem ID Verb Table */
AZALIA_SUBVENDOR(0, 0x152D1165),
--
To view, visit https://review.coreboot.org/c/coreboot/+/84394?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60bb9e7df368b786e17bb49a6f35d27372fd21de
Gerrit-Change-Number: 84394
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj, Subrata Banik, YH Lin.
David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84339?usp=email )
Change subject: mb/google/nissa/var/riven: enable WIFI SAR
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> I am not sure we need to use WIFI SAR ID in this scenario. […]
RF team teld us, maybe need six sar table.
Riven project --> there are two sar table for WIFI6 and WIFI7
Rynax project --> there are two sar table for WIFI6 and WIFI7
Ruduriks project --> there are two sar table for WIFI6 and WIFI7
--
To view, visit https://review.coreboot.org/c/coreboot/+/84339?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I647d64a008991a7a20791b2c87ea6308af6bb82e
Gerrit-Change-Number: 84339
Gerrit-PatchSet: 5
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Sep 2024 01:45:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin <yueherngl(a)google.com>
Attention is currently required from: Anil Kumar K, Bora Guvendik, Felix Held, Hannah Williams, Jamie Ryu, Subrata Banik.
Hello Anil Kumar K, Bora Guvendik, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84104?usp=email
to look at the new patch set (#23).
Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................
soc/intel/common/block/pmc: Add GPE1 functions
- Requires CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 flag.
- The existing static gpe functions has been renamed with gpe0.
- Add gpe1 functions.
BUG:362310295
TEST=Build with CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 flag,
boot google/fatcat or intel/ptlrvp DUT, and check if GPE1 sts bits have
been printed during boot. Search for:
[DEBUG] GPE1 STD STS: <event string>
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d
---
M src/soc/intel/common/block/include/intelblocks/pmclib.h
M src/soc/intel/common/block/pmc/pmclib.c
2 files changed, 123 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/84104/23
--
To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d
Gerrit-Change-Number: 84104
Gerrit-PatchSet: 23
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
YH Lin has posted comments on this change by YH Lin. ( https://review.coreboot.org/c/coreboot/+/84393?usp=email )
Change subject: nissa/riven: add the binding to the SAR tables
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Also refer to chrome-internal:7683624 for SAR table generations.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3061364ab335d6a10738eb858404cb834a770d2d
Gerrit-Change-Number: 84393
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Sep 2024 00:33:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj, Subrata Banik.
YH Lin has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84339?usp=email )
Change subject: mb/google/nissa/var/riven: enable WIFI SAR
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I am not sure we need to use WIFI SAR ID in this scenario. Relying on the connection type should be sufficient, IMO.
Uploaded CB:84393 as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84339?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I647d64a008991a7a20791b2c87ea6308af6bb82e
Gerrit-Change-Number: 84339
Gerrit-PatchSet: 5
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Sep 2024 00:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84393?usp=email
to look at the new patch set (#2).
Change subject: nissa/riven: add the binding to the SAR tables
......................................................................
nissa/riven: add the binding to the SAR tables
Tie the WIFI SAR tables based on the connection type.
BUG=b:362359938
TEST=emerge-nissa coreboot chromeos-bootimage
BRANCH=nissa
Change-Id: I3061364ab335d6a10738eb858404cb834a770d2d
Signed-off-by: YH Lin <yueherngl(a)google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/riven/variant.c
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/84393/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3061364ab335d6a10738eb858404cb834a770d2d
Gerrit-Change-Number: 84393
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
YH Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84393?usp=email )
Change subject: nissa/riven: add the binding to the SAR tables
......................................................................
nissa/riven: add the binding to the SAR tables
Tie the WIFI SAR tables based on the connection type.
BUG=b:362359938
TEST=emerge-nissa coreboot chromeos-bootimage
BRANCH=nissa
Change-Id: I3061364ab335d6a10738eb858404cb834a770d2d
Signed-off-by: YH Lin <yueherngl(a)google.com>
---
M src/mainboard/google/brya/variants/riven/variant.c
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/84393/1
diff --git a/src/mainboard/google/brya/variants/riven/variant.c b/src/mainboard/google/brya/variants/riven/variant.c
index 15460ce..a4215b4 100644
--- a/src/mainboard/google/brya/variants/riven/variant.c
+++ b/src/mainboard/google/brya/variants/riven/variant.c
@@ -2,6 +2,13 @@
#include <baseboard/variants.h>
#include <boardid.h>
+#include <fw_config.h>
+#include <sar.h>
+
+const char *get_wifi_sar_cbfs_filename(void)
+{
+ return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI_TYPE));
+}
void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/84393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3061364ab335d6a10738eb858404cb834a770d2d
Gerrit-Change-Number: 84393
Gerrit-PatchSet: 1
Gerrit-Owner: YH Lin <yueherngl(a)google.com>