Attention is currently required from: Cliff Huang, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84410?usp=email )
Change subject: soc/intel/ptl: Add GPE1 support in pmutil.c
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/pantherlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/84410/comment/70a3835b_6c384ff6?us… :
PS2, Line 111: _HAVE
USE?
https://review.coreboot.org/c/coreboot/+/84410/comment/8ea300de_135dc1c0?us… :
PS2, Line 181: if (std_gpe0_mask & PME_B0_EN)
: pmc_disable_gpe1(GPE1_EN(0), GPE1_PME_B0_EVENT_EN_BITS);
:
: if (std_gpe0_mask & TC_PME_B0_EN)
: pmc_disable_gpe1(GPE1_EN(0), GPE1_TC_PME_B0_EVENT_EN_BITS);
:
isn't `PME_B0_EN` is a super set of `TC_PME_B0_EN`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia79c49d399eff4b2f6978323b2f5e2bb167d8638
Gerrit-Change-Number: 84410
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Held.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84380?usp=email )
Change subject: soc/amd/glinda/.../iomap.h: Update for glinda
......................................................................
Patch Set 2:
(5 comments)
This change is ready for review.
File src/soc/amd/glinda/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/84380/comment/f0a3443a_5c709924?us… :
PS1, Line 14: #define GNB_IO_APIC_ADDR 0xfec01000 //TODO
> unless this is hardcoded somewhere else (which it shouldn't be), this is correct. […]
Done
https://review.coreboot.org/c/coreboot/+/84380/comment/5e405983_a0484614?us… :
PS1, Line 15: #define SPI_BASE_ADDRESS 0xfec10000 //TODO
> this is still used ass the spi mmio base
Done
https://review.coreboot.org/c/coreboot/+/84380/comment/1c7cf4bd_bccf763d?us… :
PS1, Line 18: #define ALINK_AHB_ADDRESS 0xfedc0000 //TODO Its not in the table anymore (maybe it moved in the PPR)
> that one is still there
I take your word for it, since I can't find it.
https://review.coreboot.org/c/coreboot/+/84380/comment/8a57cf5a_f322d032?us… :
PS1, Line 33: #define APU_UART4_BASE 0xfedd1000 //TODO not in the table but used on actual schematics (does it exist or not?)
> i see uart0.. […]
I was looking at table 147 in document 57254 (Rev 1.59) and I can't see UART4 there. But maybe the table is outdated.
https://review.coreboot.org/c/coreboot/+/84380/comment/2b47227e_837215e8?us… :
PS1, Line 40: /* I/O Ranges */
: #define ACPI_IO_BASE 0x0400
: #define ACPI_PM_EVT_BLK (ACPI_IO_BASE + 0x00)
: #define ACPI_PM1_STS (ACPI_PM_EVT_BLK + 0x00)
: #define ACPI_PM1_EN (ACPI_PM_EVT_BLK + 0x02)
: #define ACPI_PM1_CNT_BLK (ACPI_IO_BASE + 0x04)
: #define ACPI_PM_TMR_BLK (ACPI_IO_BASE + 0x08)
: #define ACPI_CSTATE_CONTROL (ACPI_IO_BASE + 0x10)
: #define ACPI_GPE0_BLK (ACPI_IO_BASE + 0x20)
: #define ACPI_GPE0_STS (ACPI_GPE0_BLK + 0x00)
These are not used anywhere and I also can't find them in the PPR.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84380?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If282ce5687b8a2bdae03ebfc5a37fe5b8b17647a
Gerrit-Change-Number: 84380
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Felix Held, Hannah Williams, Jamie Ryu, Paul Menzel.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )
Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................
Patch Set 27:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/84104/comment/df52d593_14ca6a31?us… :
PS27, Line 237: HAVE
should be `USE`
--
To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d
Gerrit-Change-Number: 84104
Gerrit-PatchSet: 27
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84409?usp=email )
Change subject: mb/google/fatcat: Add HDA verb tables
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84409/comment/6fc5fb27_4f8d13a7?us… :
PS1, Line 57: * Disable AGC and set AGC limit to -1.5dB
> `please, no space before tabs`
Please fix.
https://review.coreboot.org/c/coreboot/+/84409/comment/33c861da_1992a699?us… :
PS1, Line 57: * Disable AGC and set AGC limit to -1.5dB
> `code indent should use tabs where possible`
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d55
Gerrit-Change-Number: 84409
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 02:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84408?usp=email )
Change subject: mb/google/fatcat: Add FW_CONFIG
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84408/comment/9179c015_103394fe?us… :
PS1, Line 2: field DEBUG 0 1
: option NONE 0
: option RMT 1
: end
why we need to use FW_CONFIG for debug feature ?
https://review.coreboot.org/c/coreboot/+/84408/comment/558d1428_bc3fd9fa?us… :
PS1, Line 1: fw_config
: field DEBUG 0 1
: option NONE 0
: option RMT 1
: end
: field AUDIO 8 10
: option NONE 0
: option PTL_ALC1019_ALC5682I_I2S 1
: option PTL_MAX98373_ALC5682_SNDW 2
: option PTL_ALC722_SNDW 3
: option PTL_ALC5682I_MAX9857A_I2S 4
: option PTL_ALC256_HDA 5
: option PTL_MAX98360_ALC5682I_I2S 6
: end
: field WIFI 11
: option WIFI_CNVI 0
: option WIFI_PCIE 1
: end
: field TOUCHSCREEN 12 14
: option NONE 0
: option I2C4 1
: option GSPI0 2
: option THC0_SPI 3
: option THC0_I2C 4
: end
: field TOUCHPAD 16 18
: option NONE 0
: option THC1I2C_HYNITRON 1
: option I2C5_HYNITRON 2
: end
: field X1SLOT 19 20
: option NONE 0
: option SD 1
: option ETH 2
: end
: field STORAGE 21 22
: option TOP_NVME 0 # RP5
: option BOTTOM_NVME 1 # RP9
: option UFS 2
: end
: field FPS 23 24
: option NONE 0
: option SPI 1
: option USB2 2
: end
: field WWAN 25 26
: option NONE 0
: option PCIE 1
: option USB 2
: end
: field CNVI_BT 27
: option BT_USB 0
: option BT_PCIE 1
: end
: end
:
what is the source of truth here ? please hold on FW config CL as we need to work with YH/HW folks to conclude that SKU configuration first then we will decide the FW_CONFIG depending on BoM configuration.
I don't think we need to use X1SLOT, TOUCHPAD, TOUCHSCREEN, CNVI_BT (is always USB for cros), FPS (always SPI), DEBUG etc.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84408?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d54
Gerrit-Change-Number: 84408
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 02:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.
Hello Kapil Porwal, Pranava Y N, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84410?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/ptl: Add GPE1 support in pmutil.c
......................................................................
soc/intel/ptl: Add GPE1 support in pmutil.c
This change is to add the required GPE1 override functions for PTL.
The override functions are called in Intel common pmclib.c. NOTE that
GPE1 bits are SOC-specific and they are related to GPE0 events.
1. When CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 is set, the SOC
GPE1 override functions soc_pmc_disable_std_gpe1() and
soc_pmc_enable_std_gpe1() are required in order to configure GPE1 bits
properly according to the corresponding GPE0 bits.
2. The mapping for GPE1 bits to their readable string is also provided
BUG=b:362310295
TEST=This cannot be tested directly. Build with
CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 in google/fatcat or
inte/ptlrvp. Boot to OS, Check both GPE0 and GPE1 EN bits.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Ia79c49d399eff4b2f6978323b2f5e2bb167d8638
---
M src/soc/intel/pantherlake/pmutil.c
1 file changed, 112 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/84410/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia79c49d399eff4b2f6978323b2f5e2bb167d8638
Gerrit-Change-Number: 84410
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree
......................................................................
Patch Set 1:
(13 comments)
Patchset:
PS1:
Could you please add minimal override tree support without dumping all possible IOs at once? We should take devices one at a time and add their required changes when we're ready to enable them.
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/3dcc93f7_7ef64e33?us… :
PS1, Line 3: # GPE configuration
: # Note that GPE events called out in ASL code rely on this
: # route. i.e. If this route changes then the affected GPE
: # offset bits also need to be changed.
: register "pmc_gpe0_dw0" = "GPP_B"
: register "pmc_gpe0_dw1" = "GPP_D"
: register "pmc_gpe0_dw2" = "GPP_E"
this should do to baseboard devicetree
https://review.coreboot.org/c/coreboot/+/84407/comment/93033073_bb95d40d?us… :
PS1, Line 45:
: # EC host command ranges are in 0x800-0x8ff & 0x200-0x20f
: register "gen1_dec" = "0x00fc0801"
: register "gen2_dec" = "0x000c0201"
: # EC memory map range is 0x900-0x9ff
: register "gen3_dec" = "0x00fc0901"
same as previous comment
https://review.coreboot.org/c/coreboot/+/84407/comment/f841f763_a17c4706?us… :
PS1, Line 52: # This disabled autonomous GPIO power management for early PO
: register "gpio_override_pm" = "1"
: register "gpio_pm[COMM_0]" = "0"
: register "gpio_pm[COMM_1]" = "0"
: register "gpio_pm[COMM_3]" = "0"
: register "gpio_pm[COMM_4]" = "0"
: register "gpio_pm[COMM_5]" = "0"
we don't need to override to zero value, unless defined the value should be zero
https://review.coreboot.org/c/coreboot/+/84407/comment/e12e5a8c_714c5691?us… :
PS1, Line 69: # Enable s0ix
: register "s0ix_enable" = "1"
this should do to baseboard devicetree
https://review.coreboot.org/c/coreboot/+/84407/comment/cd86d616_f9471c94?us… :
PS1, Line 114: # Intel Common SoC Config
we generally maintain a table to understand the I2Cx mapping, can you please apply that here as well ?
https://review.coreboot.org/c/coreboot/+/84407/comment/01e0100e_ac498c74?us… :
PS1, Line 223:
please use consistent tab
https://review.coreboot.org/c/coreboot/+/84407/comment/48329c87_4c984a6f?us… :
PS1, Line 223: use usb2_port1 as usb2_port
: use tcss_usb3_port0 as usb3_port
: device generic 0 alias conn0 on end
: end
: chip drivers/intel/pmc_mux/conn
: use usb2_port2 as usb2_port
: use tcss_usb3_port1 as usb3_port
: device generic 1 alias conn1 on end
: end
: chip drivers/intel/pmc_mux/conn
: use usb2_port3 as usb2_port
: use tcss_usb3_port2 as usb3_port
: device generic 2 alias conn2 on end
: end
: chip drivers/intel/pmc_mux/conn
: use usb2_port4 as usb2_port
: use tcss_usb3_port3 as usb3_port
: device generic 3 alias conn3 on end
: end
: end
I also don't believe we need PMC MUX when we are planning to use PDC<->PMC communication in PTL
https://review.coreboot.org/c/coreboot/+/84407/comment/34d089df_01fcb984?us… :
PS1, Line 246: device ref pcie_rp1 off
: # register "pcie_rp[PCIE_RP(1)]" = "{
: # .clk_src = 3,
: # .clk_req = 3,
: # .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: # }"
: end # Gbe
please don't add GBE support which is non-POR for Chrome, if you wish to keep RP0 enabled then keep it on in devicetree.cb
https://review.coreboot.org/c/coreboot/+/84407/comment/18475431_ab66d175?us… :
PS1, Line 253: device ref pcie_rp2 on
: register "pcie_rp[PCIE_RP(2)]" = "{
: .clk_src = 5,
: .clk_req = 5,
: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: }"
: end # WWAN
: device ref pcie_rp3 on
: # Enable PCH PCIE x1 slot using CLK 3
: register "pcie_rp[PCIE_RP(3)]" = "{
: .clk_src = 2,
: .clk_req = 2,
: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: }"
: chip soc/intel/common/block/pcie/rtd3
: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A08)"
: register "enable_delay_ms" = "100"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D19)"
: register "reset_delay_ms" = "20"
: register "srcclk_pin" = "2"
: device generic 0 on end
: end
: end # PCIE x1 slot
: device ref pcie_rp4 on
: register "pcie_rp[PCH_RP(4)]" = "{
: .clk_src = 4,
: .clk_req = 4,
: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: }"
: chip soc/intel/common/block/pcie/rtd3
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
: register "srcclk_pin" = "4"
: device pci 00.0 on end
: end
: end # discrete WLAN
all IOs should be part of FW_CONFIG.
https://review.coreboot.org/c/coreboot/+/84407/comment/94c47c5e_bf2539fd?us… :
PS1, Line 305: device ref pcie_rp9 on
: register "pcie_rp[PCIE_RP(9)]" = "{
: .clk_src = 1,
: .clk_req = 1,
: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: }"
: chip soc/intel/common/block/pcie/rtd3
: register "is_storage" = "true"
: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B16)"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E03)"
: register "srcclk_pin" = "1"
: device generic 0 on end
: end
: end # Gen5 M.2 SSD / x4 PCIe slot
please don't need Gen5 support. we will add depending on FW config later
https://review.coreboot.org/c/coreboot/+/84407/comment/4c717505_b25f79ca?us… :
PS1, Line 330: lnlrvp_ish
please don't enable everything as part of base CL. Kindly keep ISH off for now
https://review.coreboot.org/c/coreboot/+/84407/comment/cc2ca6c1_f67fc015?us… :
PS1, Line 654: device ref hda on
: chip drivers/intel/soundwire
: device generic 0 on
: chip drivers/soundwire/alc711
: # SoundWire Link 1 ID 1
: register "desc" = ""Headset Codec""
: device generic 1.1 on end
: end
: end
: end
: chip drivers/generic/max98357a
: register "hid" = ""MX98357A""
: register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E19)"
: register "sdmode_delay" = "5"
: device generic 0 on end
: end
: chip drivers/generic/max98357a
: register "hid" = ""MX98360A""
: register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E19)"
: register "sdmode_delay" = "5"
: device generic 0 on end
: end
: end
:
: end
please use consistent spacing
--
To view, visit https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 02:54:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No