Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84169?usp=email )
Change subject: soc/qclib_common.h: Fix Wunterminated-string-initialization error on qclib_cb_if_table
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/84169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50a70f1161ea5f9926dcce51be1156ec86b4b709
Gerrit-Change-Number: 84169
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84400?usp=email
to look at the new patch set (#2).
Change subject: [wip]crossgcc: Upgrade CMake from 3.30.2 to 3.30.3
......................................................................
[wip]crossgcc: Upgrade CMake from 3.30.2 to 3.30.3
Change-Id: I2faaf22f166f3d8bbb098e5bcb529f997243b87f
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.30.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.30.3.tar.gz.cksum
3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/84400/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84400?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2faaf22f166f3d8bbb098e5bcb529f997243b87f
Gerrit-Change-Number: 84400
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Felix Held, Hannah Williams, Jamie Ryu, Paul Menzel.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )
Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................
Patch Set 27:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/84104/comment/f953e61d_12722402?us… :
PS27, Line 237: HAVE
> shoudn't we need to clear and disable GPE1 events regardless we use GPE1 or not. after all, they still exists. _USE_ flag exposes GPE1 blocks in FADT and ACPI (GEP1 handers) _Lnn events are added instead of GPE0 _Lnn methods.
if we are not using GPE aka USE flag is set, we assume not to touch the GPE1 as ideally we don't expect any HW block will be able to reflect their state information in GPE1.
If we are always relying on GPE1 when the HAVE flag is set, then there is no meaning of keeping the USE flag. HAVE flag is exposing the SoC capability and USE flag is telling if we are using that capability or not.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d
Gerrit-Change-Number: 84104
Gerrit-PatchSet: 27
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Fred Reitberger, Jason Glenesk.
Hello Felix Held, Fred Reitberger, Jason Glenesk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84376?usp=email
to look at the new patch set (#4).
Change subject: soc/amd/glinda/chipset.cb: Update for glinda
......................................................................
soc/amd/glinda/chipset.cb: Update for glinda
This also updates the mainboards depending on it.
Change-Id: I1138f27bfd47f6fa70a0c2afcc65a5553a609d57
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/mainboard/amd/birman/devicetree_glinda.cb
M src/mainboard/amd/birman_plus/devicetree_glinda.cb
M src/soc/amd/glinda/chipset.cb
3 files changed, 103 insertions(+), 68 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/84376/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/84376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1138f27bfd47f6fa70a0c2afcc65a5553a609d57
Gerrit-Change-Number: 84376
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Attention is currently required from: Felix Held.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84384?usp=email )
Change subject: soc/amd/glinda/include/smu.h: Update mailbox register addresses
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84384/comment/ed9278e5_80f772c1?us… :
PS1, Line 7: Updating MESSAGE and RESOPONSE address for SMU Mail box for STX
> soc/amd/glinda/include/smu. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I427186aa9f0fb0650b2ab8d6171a51a33edf2778
Gerrit-Change-Number: 84384
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Maximilian Brune.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84384?usp=email
to look at the new patch set (#2).
Change subject: soc/amd/glinda/include/smu.h: Update mailbox register addresses
......................................................................
soc/amd/glinda/include/smu.h: Update mailbox register addresses
Signed-off-by: Avinash Munduru <AvinashMunduru(a)amd.com>
Change-Id: I427186aa9f0fb0650b2ab8d6171a51a33edf2778
Tested-by: Avinash Munduru <Avinash.Munduru(a)amd.com>
Reviewed-by: Anand Vaikar <Anand.Vaikar(a)amd.com>
---
M src/soc/amd/glinda/include/soc/smu.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/84384/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I427186aa9f0fb0650b2ab8d6171a51a33edf2778
Gerrit-Change-Number: 84384
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>