Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Zheng Bao.
Marshall Dawson has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84195?usp=email )
Change subject: cezanne: Add recovery AB support option
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84195/comment/f22fd148_692ab078?us… :
PS1, Line 9: Non A/B recovery
This would simply be no recovery method, right? (Although vboot is an alternative methodology.) Also, I'd mention that details of A/B recovery are in the NDA spec #56995.
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/84195/comment/2e1f08d8_1c4044d9?us… :
PS1, Line 412: "Recovery A/B"
maybe "Use A/B Recovery scheme"?
https://review.coreboot.org/c/coreboot/+/84195/comment/c429b1d9_f93e6e5b?us… :
PS1, Line 415: Recovery A/B
How about "Enable the PSP A/B Recovery mechanism"? Also, should we put some words in here about vboot? I think we'd probably recommend not using with vboot although I suspect they could coexist in the image.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84195?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1c8028faee9c544628d65fd77be2a378ed7eab6
Gerrit-Change-Number: 84195
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 17:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin Roth, Saurabh Mishra, Subrata Banik.
Jérémy Compostella has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )
Change subject: src/include: Introducing a new SET_32_BIT_FLAG(x) macro.
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
Patchset:
PS14:
I am not in favor of `SET_32_BIT_FLAG()`. This macro name is confusing to me. It seems like it would set a bit in a register instead of specifying a bit. I would be more in favor of a less cumbersome name like `BIT_FLAG_32()`.
I would also recommend to add a comment on the definition explaining why we have to define an unusual macro instead of the more commonly accepted `BIT_32`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Gerrit-Change-Number: 84142
Gerrit-PatchSet: 14
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 03 Sep 2024 17:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Matt DeVillier.
Tim Wawrzynczak has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84192?usp=email )
Change subject: acpi/acpigen: Increase max package length for acpigen_pop_len()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Wow where did you run into that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84192?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8f72fa84cfdae480fec42b0968bd7cefcdb96bdc
Gerrit-Change-Number: 84192
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 16:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: KunYi Chen.
Elyes Haouas has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................
Patch Set 28:
(4 comments)
Patchset:
PS28:
Please include only what you use
NB: I've checked only src/mainboard/lattepanda/mu/romstage_fsp_params.c and src/mainboard/lattepanda/mu/smihandler.c
File src/mainboard/lattepanda/mu/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/68d91f00_c095ad6d?us… :
PS28, Line 3: #include <assert.h>
: #include <console/console.h>
: #include <fsp/api.h>
: #include <soc/romstage.h>
: #include <spd_bin.h>
: #include <soc/meminit.h>
: #include <baseboard/variants.h>
I'm not sure if you are using all of those files
File src/mainboard/lattepanda/mu/smihandler.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/4ef5f213_7e7558c6?us… :
PS28, Line 4: #include <arch/io.h>
not sure if this is used
https://review.coreboot.org/c/coreboot/+/83719/comment/531f6b7e_f305732e?us… :
PS28, Line 6: #include <intelblocks/smihandler.h>
looks like it is not used
--
To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Gerrit-Change-Number: 83719
Gerrit-PatchSet: 28
Gerrit-Owner: KunYi Chen <kunyi.chen(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: KunYi Chen <kunyi.chen(a)gmail.com>
Gerrit-Comment-Date: Tue, 03 Sep 2024 16:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Anand Vaikar, Bao Zheng, Felix Held, Zheng Bao, ritul guru.
Marshall Dawson has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84194?usp=email )
Change subject: amdfwtool: Set L2 table size as 0x400
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84194/comment/36bb5517_cf152310?us… :
PS1, Line 10: Cezann
nit: Cezanne
https://review.coreboot.org/c/coreboot/+/84194/comment/4538d98b_643fc08d?us… :
PS1, Line 12: birman, Chausie, Skyrim, mayan
another nit, capitalize or lower case all the names consistently.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84194?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2c0af6579dbe2a3a61e1fe9c79d69491fd45a5bb
Gerrit-Change-Number: 84194
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 16:10:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jon Murphy, Martin Roth, Raul Rangel, Tim Van Patten.
Matt DeVillier has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/blobs/+/84180?usp=email )
Change subject: 3rdparty/blobs/mb/google/zork: Update signed PSP verstage binaries
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/84180?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ia0473f0a40d9b10d28c863274f3b25bc968b4c7e
Gerrit-Change-Number: 84180
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Tue, 03 Sep 2024 16:03:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Jon Murphy, Martin Roth, Raul Rangel, Tim Van Patten.
Matt DeVillier has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/blobs/+/84179?usp=email )
Change subject: 3rdparty/blobs/mb/google/zork: Update PSP signing token
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/84179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Idb11284cf4ef3abcfdd9186d672b995d82c35ad1
Gerrit-Change-Number: 84179
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Tue, 03 Sep 2024 16:03:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes